git cl patch from gerrit gets stuck |
|||
Issue description
$ git cl patch 528098
Gets stuck
Python debugger shows it's stuck here :
Thread 0x7f8844da7740
File "/usr/local/google/home/primiano/tools/depot_tools/git_cl.py", line 6018, in <module>
sys.exit(main(sys.argv[1:]))
File "/usr/local/google/home/primiano/tools/depot_tools/git_cl.py", line 6000, in main
return dispatcher.execute(OptionParser(), argv)
File "/usr/local/google/home/primiano/tools/depot_tools/subcommand.py", line 252, in execute
return command(parser, args[1:])
File "/usr/local/google/home/primiano/tools/depot_tools/git_cl.py", line 5334, in CMDpatch
options.nocommit, options.directory)
File "/usr/local/google/home/primiano/tools/depot_tools/git_cl.py", line 2141, in CMDPatchWithParsedIssue
patchset = parsed_issue_arg.patchset or self.GetMostRecentPatchset()
File "/usr/local/google/home/primiano/tools/depot_tools/git_cl.py", line 1961, in GetMostRecentPatchset
return self.GetIssueProperties()['patchsets'][-1]
File "/usr/local/google/home/primiano/tools/depot_tools/git_cl.py", line 1969, in GetIssueProperties
self._props = self.RpcServer().get_issue_properties(issue, True)
File "/usr/local/google/home/primiano/tools/depot_tools/rietveld.py", line 685, in get_issue_properties
super(CachingRietveld, self).get_issue_properties)
File "/usr/local/google/home/primiano/tools/depot_tools/rietveld.py", line 661, in _lookup
function_cache[args] = update(*args)
File "/usr/local/google/home/primiano/tools/depot_tools/rietveld.py", line 87, in get_issue_properties
data = json.loads(self.get(url, retry_on_404=True))
File "/usr/local/google/home/primiano/tools/depot_tools/rietveld.py", line 404, in get
return self._send(request_path, **kwargs)
File "/usr/local/google/home/primiano/tools/depot_tools/rietveld.py", line 475, in _send
time.sleep(min(10, 1+retry*2))
Fun thing, why rietveld.py? This is supposed to be a gerrit CL.
,
Jun 8 2017
,
Jun 8 2017
Do you have "git config gerrit.host true" set in this repo? If not, there's no way for git-cl-patch to detect gerrit vs rietveld from just an integer. That number is a potentially valid number on both systems, so it falls back to the default which hasn't changed yet. If you pass --rietveld/--gerrit, or pass a full url to the change instead of just a number, then it won't have to fall back to the default.
,
Jun 8 2017
Ahhh very likely. I did ssh on my other workstation, so it's extremely likely that I didn't flip the switch there. Makes sense, thanks for the explanation. |
|||
►
Sign in to add a comment |
|||
Comment 1 by primiano@chromium.org
, Jun 8 2017