Make AudioManagerBase::ShutdownOnAudioThread to always work correctly when device thread is the main thread |
|||
Issue descriptionCurrently AudioManagerBase::ShutdownOnAudioThread() has Mac-specific code which closes audio input streams; that it because the device thread of AudioThread on Mac is in fact the main thread AudioManager lives on. So this Mac-specific part of AudioManagerBase::ShutdownOnAudioThread() actually assumes a specific AudioThread implementation, which violates encapsulation. Also, we want to be able to run AudioManager on the main thread of the audio process/another utility process on any platform.
,
Jun 9 2017
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea81900f783ce26a298dfe95bb0488fbe7c3dc2e commit ea81900f783ce26a298dfe95bb0488fbe7c3dc2e Author: Olga Sharonova <olka@chromium.org> Date: Tue Aug 29 08:04:56 2017 Making AudioManagerBase::ShutdownOnAudioThread() platform-agnostic Moved from https://codereview.chromium.org/2929823002/ TBR=alokp@chromium.org Bug: 731124 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idd7c8bd6de3002356772ac7d9068fe2937cb53dc Reviewed-on: https://chromium-review.googlesource.com/637696 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#498046} [modify] https://crrev.com/ea81900f783ce26a298dfe95bb0488fbe7c3dc2e/media/audio/audio_manager.cc [modify] https://crrev.com/ea81900f783ce26a298dfe95bb0488fbe7c3dc2e/media/audio/audio_manager_base.cc [modify] https://crrev.com/ea81900f783ce26a298dfe95bb0488fbe7c3dc2e/media/audio/mac/audio_manager_mac.cc
,
Aug 29 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by olka@chromium.org
, Jun 9 2017