New issue
Advanced search Search tips

Issue 731101 link

Starred by 2 users
Status: Started
Owner:
emaxx@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Add more error/debug logging for the component cloud policy stack

Project Member Reported by emaxx@chromium.org, Jun 8 2017 
A lot of errors around the component cloud policy (that is, policy for extensions) don't result in any log messages, which means that the component policy can be not fetched or not applied silently.

It will be useful to add more logging into this piece. One category would be to emit ERROR/WARNING log messages when there are some errors in the process of fetching and applying the policy. Another category would be verbose debug-only log messages that would allow to have a more detailed insight into the current state in the developer builds.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ac7b378fc716a389d97d5cc10d42bbfd47cd1dd

commit 1ac7b378fc716a389d97d5cc10d42bbfd47cd1dd
Author: Maksim Ivanov <emaxx@chromium.org>
Date: Wed Jun 28 22:43:18 2017

More error/debug logging for component cloud policy

* Better error/warning logging coverage for the failure flows - that is,
  failed data fetching, failed validation, etc.
* Some debug-only verbose logging - for transient errors (network error),
  for the internal jobs being started or canceled, etc.
* A bit of general cleanup: comments, constness, C++11 features.

TEST=existing tests; manual test against a typical managed account to
     check that no log spamming is introduced

Bug: chromium:731101
Change-Id: If3f382143b3888da200f47ae59871bd2c1f02ff3
Reviewed-on: https://chromium-review.googlesource.com/528195
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483178}
[modify] https://crrev.com/1ac7b378fc716a389d97d5cc10d42bbfd47cd1dd/components/policy/core/common/cloud/component_cloud_policy_store.cc
[modify] https://crrev.com/1ac7b378fc716a389d97d5cc10d42bbfd47cd1dd/components/policy/core/common/cloud/component_cloud_policy_store.h
[modify] https://crrev.com/1ac7b378fc716a389d97d5cc10d42bbfd47cd1dd/components/policy/core/common/cloud/component_cloud_policy_updater.cc
[modify] https://crrev.com/1ac7b378fc716a389d97d5cc10d42bbfd47cd1dd/components/policy/core/common/cloud/component_cloud_policy_updater.h
[modify] https://crrev.com/1ac7b378fc716a389d97d5cc10d42bbfd47cd1dd/components/policy/core/common/cloud/external_policy_data_updater.cc
[modify] https://crrev.com/1ac7b378fc716a389d97d5cc10d42bbfd47cd1dd/components/policy/core/common/cloud/external_policy_data_updater.h

Comment 2 by emaxx@chromium.org, Jul 12 2017

Status: Started (was: Assigned)
►

Sign in to add a comment