New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731100 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Can we remove kUsedPolicyCertificatesOnce?

Project Member Reported by atwilson@chromium.org, Jun 8 2017

Issue description

We migrated away from this pref years ago - can we finally remove it? Worst thing that can happen is you might get a multi-profile session with a policy-provided trust root, I guess.
 

Comment 1 by pmarko@chromium.org, Jun 12 2017

I think we can - CL https://codereview.chromium.org/117263002 which landed 3 years, 5 months ago, had code to migrate from that pref to a different pref in local state, so any profile logged in in the last 3 years should not have that pref anymore.

Comment 2 by pmarko@chromium.org, Jun 12 2017

Status: Started (was: Untriaged)
CL: https://chromium-review.googlesource.com/c/530848/

Comment 3 by pmarko@chromium.org, Jun 12 2017

Components: Enterprise
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e9f1b26e22fa66124b13ed4317a361c3694c691

commit 2e9f1b26e22fa66124b13ed4317a361c3694c691
Author: Pavol Marko <pmarko@chromium.org>
Date: Mon Jun 26 10:10:42 2017

Remove kUsedPolicyCertificatesOnce profile pref

This CL removes the kUsedPolicyCertificatesOnce profile pref. It has
been replaced by the kUsedPolicyCertificates local state pref in
https://codereview.chromium.org/117263002.

BUG= 731100 

Change-Id: I7874e143410957905c384732bcd0a1c24a15bffc
Reviewed-on: https://chromium-review.googlesource.com/530848
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482224}
[modify] https://crrev.com/2e9f1b26e22fa66124b13ed4317a361c3694c691/chrome/browser/chromeos/policy/policy_cert_service_factory.cc
[modify] https://crrev.com/2e9f1b26e22fa66124b13ed4317a361c3694c691/chrome/browser/chromeos/policy/policy_cert_service_factory.h
[modify] https://crrev.com/2e9f1b26e22fa66124b13ed4317a361c3694c691/chrome/common/pref_names.cc
[modify] https://crrev.com/2e9f1b26e22fa66124b13ed4317a361c3694c691/chrome/common/pref_names.h

Comment 5 by pmarko@chromium.org, Jun 26 2017

Status: Fixed (was: Started)
Done. Please note again that this was about removing a migration path from an old pref to a new pref.

The only reasonable verification I can think of would be verifying that the policy-provided trust root used -> multi-profile disabled logic still works fine as a regression test.
Status: Verified (was: Fixed)

Sign in to add a comment