New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731094 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

[CFM Test Automation] Add telemetry API support for CfMs running meetings (thor) app

Project Member Reported by dtosic@chromium.org, Jun 8 2017

Issue description

We want to able to automate our tests running Meetings on CfM.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/739e8c71cc6585b37b52fd7fff3c6ecbe29e1a63

commit 739e8c71cc6585b37b52fd7fff3c6ecbe29e1a63
Author: Denis Tosic <dtosic@chromium.org>
Date: Wed Jun 14 15:14:34 2017

Adds util class for interacting with the hotlane telemetry API

This file wraps JS commands exponsed on the Google Meet pages on a CfM.
It is inteded for usage in test automation. Not yet used anywhere.

BUG= chromium:731094 
TEST=manualy

Change-Id: I710114b5c19006fb833a0bbda1319b5a82fbcd36
Reviewed-on: https://chromium-review.googlesource.com/528200
Commit-Ready: Denis Tosic <dtosic@chromium.org>
Tested-by: Denis Tosic <dtosic@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[add] https://crrev.com/739e8c71cc6585b37b52fd7fff3c6ecbe29e1a63/client/common_lib/cros/cfm_meetings_api.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/66ffb0a193efe5954e783f529c7b2948f284ee0e

commit 66ffb0a193efe5954e783f529c7b2948f284ee0e
Author: harpreet <harpreet@google.com>
Date: Thu Jun 29 21:16:35 2017

Renaming cfm_util and refactoring code as needed.

Move common kiosk methods from cfm_util to kiosk_utils and rename
cfm_util to cfm_hangouts_api. This will purely be a JS API wrapper for
gcomm api's similar to cfm_meetings_api which is a JS API wrapper for
hotlane.

BUG= chromium:731094 
TEST=Tested on a local setup

Change-Id: Ic233ffe76b884fe2e49ae10104a1bbd700b5d04f
Reviewed-on: https://chromium-review.googlesource.com/546890
Commit-Ready: Harpreet Grewal <harpreet@chromium.org>
Tested-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Krishna Gavini <krishnargv@chromium.org>
Reviewed-by: Kristoffer Erlandsson <kerl@google.com>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
Reviewed-by: Denis Tosic <dtosic@chromium.org>

[rename] https://crrev.com/66ffb0a193efe5954e783f529c7b2948f284ee0e/client/common_lib/cros/cfm_hangouts_api.py
[modify] https://crrev.com/66ffb0a193efe5954e783f529c7b2948f284ee0e/client/common_lib/cros/kiosk_utils.py
[modify] https://crrev.com/66ffb0a193efe5954e783f529c7b2948f284ee0e/client/site_tests/enterprise_RemoraRequisition/enterprise_RemoraRequisition.py
[modify] https://crrev.com/66ffb0a193efe5954e783f529c7b2948f284ee0e/client/cros/multimedia/cfm_facade_native.py
[modify] https://crrev.com/66ffb0a193efe5954e783f529c7b2948f284ee0e/client/site_tests/enterprise_KioskEnrollment/enterprise_KioskEnrollment.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4d981891fb255953a068cb1b528c622d2d7beb17

commit 4d981891fb255953a068cb1b528c622d2d7beb17
Author: harpreet <harpreet@google.com>
Date: Thu Jun 29 23:59:30 2017

Additional refactoring of cfm hangouts api class

Follow up refactoring CL after crrev.com/c/546890

BUG= chromium:731094 
TEST=Tested on a local setup

Change-Id: I501830ffb3d8b6007adb3142cd0c0b13285491a5
Reviewed-on: https://chromium-review.googlesource.com/557282
Tested-by: Harpreet Grewal <harpreet@chromium.org>
Trybot-Ready: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
Commit-Queue: Harpreet Grewal <harpreet@chromium.org>

[modify] https://crrev.com/4d981891fb255953a068cb1b528c622d2d7beb17/client/common_lib/cros/cfm_hangouts_api.py
[modify] https://crrev.com/4d981891fb255953a068cb1b528c622d2d7beb17/client/cros/multimedia/cfm_facade_native.py

Summary: [CFM Test Automation] Add telemetry API support for CfMs running meetings (thor) app (was: [CFM Test Automation] Add telemetry API support for CfMs running meetings instead of hangouts)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5ff098676ba20c730e469608cd57fc52631844f5

commit 5ff098676ba20c730e469608cd57fc52631844f5
Author: Denis Tosic <dtosic@chromium.org>
Date: Thu Jul 06 04:54:53 2017

Improve landing/in-call page evaluation

The previous implementation was prone to a race condition (which resulted in a
null pointer) when navigating between pages.

TEST=manually
BUG= chromium:731094 

Change-Id: I04778d4e9e533837a7b56e9dd25177ba0fd67453
Reviewed-on: https://chromium-review.googlesource.com/558907
Commit-Ready: Harpreet Grewal <harpreet@chromium.org>
Commit-Ready: Denis Tosic <dtosic@chromium.org>
Tested-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[modify] https://crrev.com/5ff098676ba20c730e469608cd57fc52631844f5/client/common_lib/cros/cfm_meetings_api.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/47a23a15177839c59bea17a347c4a9d0f35e1d52

commit 47a23a15177839c59bea17a347c4a9d0f35e1d52
Author: harpreet <harpreet@google.com>
Date: Fri Jul 07 14:44:49 2017

Adding support for Meet app along with basic sanity test

Added support for meet app to cfm facades which include instantiating
the appropriate cfm api object. Also added a basic sanity test to
exercise the meetings apis. This is a very basic barebones test which
could be expanded later as needed.

BUG= chromium:731094 
TEST=Tested on a local setup.

Change-Id: I31a1c0d72a679e18bbae03b6a468a62dc31041b4
Reviewed-on: https://chromium-review.googlesource.com/557449
Commit-Ready: Harpreet Grewal <harpreet@chromium.org>
Commit-Ready: Denis Tosic <dtosic@chromium.org>
Tested-by: Harpreet Grewal <harpreet@chromium.org>
Tested-by: Denis Tosic <dtosic@chromium.org>
Reviewed-by: Katie Roberts-Hoffman <katierh@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Claes Malmnäs <malmnas@google.com>
Reviewed-by: Denis Tosic <dtosic@chromium.org>

[modify] https://crrev.com/47a23a15177839c59bea17a347c4a9d0f35e1d52/client/cros/multimedia/cfm_facade_native.py
[modify] https://crrev.com/47a23a15177839c59bea17a347c4a9d0f35e1d52/server/cros/multimedia/cfm_facade_adapter.py
[add] https://crrev.com/47a23a15177839c59bea17a347c4a9d0f35e1d52/server/site_tests/enterprise_CFM_MeetAppSanity/control
[add] https://crrev.com/47a23a15177839c59bea17a347c4a9d0f35e1d52/server/site_tests/enterprise_CFM_MeetAppSanity/enterprise_CFM_MeetAppSanity.py
[modify] https://crrev.com/47a23a15177839c59bea17a347c4a9d0f35e1d52/client/common_lib/cros/cfm_hangouts_api.py
[modify] https://crrev.com/47a23a15177839c59bea17a347c4a9d0f35e1d52/client/common_lib/cros/cfm_meetings_api.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/56ba79d8c09519d8a4a67cbc192b93284dde6b7f

commit 56ba79d8c09519d8a4a67cbc192b93284dde6b7f
Author: harpreet <harpreet@google.com>
Date: Wed Jul 12 05:19:58 2017

Add Meet app sanity test to ebuild

Test check for basic functionality of starting and ending a call. To be
expanded to cover other basic meet app functionality.

BUG= chromium:731094 
TEST=Tested on a local setup.

Change-Id: I970fb7f73d9cb11a83014b4ba78e1043c2821e8b
Reviewed-on: https://chromium-review.googlesource.com/564160
Commit-Ready: Harpreet Grewal <harpreet@chromium.org>
Tested-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
Reviewed-by: Denis Tosic <dtosic@chromium.org>

[modify] https://crrev.com/56ba79d8c09519d8a4a67cbc192b93284dde6b7f/chromeos-base/autotest-server-tests/autotest-server-tests-9999.ebuild

Comment 8 by dtosic@chromium.org, Jul 12 2017

Status: Verified (was: Assigned)
Marking this one as fixed as we have a first working test with the API.

Sign in to add a comment