New issue
Advanced search Search tips

Issue 731066 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 852147
Owner:
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug


Participants' hotlists:
media-router-follow-up


Sign in to add a comment

[Dice] Enable multi account for extensions

Project Member Reported by droger@chromium.org, Jun 8 2017

Issue description

Project Member

Comment 1 by sheriffbot@chromium.org, Jul 10 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by ew...@chromium.org, Feb 12 2018

Blocking: -716053 807826
Cc: msarda@chromium.org
This seems like it's related to Dice, so marking as blocking milestone 3. David, is this actually launch blocking for M3, or could we punt this to later?

Comment 3 by droger@chromium.org, Feb 13 2018

Labels: -Pri-3 M-66 Pri-2
I'm not familiar with this, but we probably want it for M3.

Comment 4 by ew...@chromium.org, Feb 16 2018

If we determine this isn't strictly blocking for M3 rollout, let's punt it, since we have a lot of work left to do for M3 still.

Comment 5 by ew...@chromium.org, Feb 16 2018

Cc: ew...@chromium.org

Comment 6 by msarda@chromium.org, Feb 19 2018

Labels: OS-Linux OS-Mac OS-Windows
Status: Assigned (was: Available)
Marking assigned as this is blocking for Dice M3.

Comment 7 by ew...@chromium.org, Feb 20 2018

Can you elaborate a bit on what exactly is required here?

Comment 8 by ew...@chromium.org, Feb 21 2018

Blocking: -807826
Labels: Hotlist-DICE-Followup
Discussed today in person. This is not strictly blocking for M3.

Comment 9 by ew...@chromium.org, Mar 20 2018

Cc: sabineb@chromium.org
Labels: -M-66
Removing milestone label, since this will probably come at some point in the future.
I actually have a CL for this, ready to land:
https://chromium-review.googlesource.com/c/chromium/src/+/928763

I never landed it though, because apparently this feature was never launched on any platforms. So, if we do this we are not fixing a bug, but actually launching something new.
Since I don't even understand what this feature is, and the engineer who wrote the feature didn't know how we could even test it, I don't think we can reasonably do this.

I don't know what the next step is though:
- should we delete the feature and the code?
- should we launch it? (which I think is significant work)

Comment 11 by ew...@chromium.org, Mar 22 2018

Cc: sko...@chromium.org droger@chromium.org mfo...@chromium.org
Owner: ----
Status: Available (was: Assigned)
IIUC, this is to allow extensions in the browser to get access to *all* the user's signed-in accounts (via OAuth), as opposed to just the sync account, correct?

Yeah, I don't think this is fixing a bug, it's definitely launching a new capability. My suspicion is that this is more work than it's worth (at least for now), until we have a compelling use case.

One potential use case: Mihai and I had a conversation with the Cast team a while back. They were potentially interested in this functionality (so you could cloud cast to any signed-in account). cc'ing a couple folks that we'd chatted with about that in case they are interested in bringing this discussion up again.

For the time-being, I think it makes sense to de-prioritize this until we complete the Dice launch. I defer to you all (including Sabine) on figuring out the roadmap for this.
Components: Internals>Cast>Providers
Owner: johnpallett@chromium.org
I'm not aware of a need for this for Media Router, but routing to our PM for further comment.
Status: Assigned (was: Available)
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 23 2018

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Available)
Owner: powerb@chromium.org
Project Member

Comment 17 by sheriffbot@chromium.org, Sep 3

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: 852147
Status: Duplicate (was: Available)
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/739d153853a0fa5244ced0c4f3eaa87d3cef01fb

commit 739d153853a0fa5244ced0c4f3eaa87d3cef01fb
Author: David Roger <droger@chromium.org>
Date: Thu Oct 11 17:21:25 2018

Multi-account for extensions with Dice

Dice allows enabling multi-account support for extensions.
Since account consistency is now per-profile, this CL refactors the
multi-account support to be per profile as well.

The existing command line switch is removed and replaced by a
base::Feature, which is disabled by default.
Unlike the switch, the feature only enables multi-account for
Dice, and there is no way to enable multi-account when dice is
not enabled.

Bug:  731066 
Change-Id: Ice8534f0227bf04bab11aeacb572fb1accde1abd
Reviewed-on: https://chromium-review.googlesource.com/c/928763
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598813}
[modify] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/chrome/browser/extensions/api/identity/identity_api.cc
[modify] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/chrome/browser/extensions/api/identity/identity_api.h
[add] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/chrome/browser/extensions/api/identity/identity_api_unittest.cc
[modify] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/chrome/browser/extensions/api/identity/identity_get_accounts_function.cc
[modify] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc
[modify] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/chrome/test/BUILD.gn
[modify] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/components/signin/core/browser/account_reconcilor.h
[modify] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/components/signin/core/browser/profile_management_switches.cc
[modify] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/components/signin/core/browser/profile_management_switches.h
[modify] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/components/signin/core/browser/signin_switches.cc
[modify] https://crrev.com/739d153853a0fa5244ced0c4f3eaa87d3cef01fb/components/signin/core/browser/signin_switches.h

Sign in to add a comment