New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 731058 link

Starred by 2 users
Status: Duplicate
Merged: issue 726645
Owner:
msramek@chromium.org
Closed: Jun 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Regression: In Incognito window, Print preview for NTP is seen blank on selecting Selection only option.

Reported by ngu...@etouch.net, Jun 8 2017 
Chrome Version: 60.0.3112.24 (Official Build) 16a564bd7c034b8f6e008d0887fc46c7aae48488-refs/branch-heads/3112@{#242} (32/64-bit) 
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

What steps will reproduce the problem?
1) Launch chrome and open a new Incognito window.
2) Using mouse drag and select all text on NTP and give 'Print' command.
3) Click on 'More settings' button, select 'Background graphics' and 'Selection only' options.
4) Observe the Preview section.

The Preview section is seen blank on selecting 'Background graphics' and 'Selection only' options.

The Preview section should not be blank on selecting 'Background graphics' and 'Selection only' options.

This is a Regression issue broken in M-60, will soon update other info
Manual bisect:
Good build: 60.0.3109.0 
Bad build: 60.0.3110.0
incog_actual.mp4
619 KB View Download
incog_expected.mp4
807 KB View Download

Comment 1 by rbasuvula@chromium.org, Jun 8 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: msramek@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:60.0.3109.0 (Revision:474118).
Bad build:60.0.3110.0 (Revision:474499).

You are probably looking for a change made after 474383 (known good), but no later than 474384 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/dc44616c932d390c6ee11c2eb5931d51e7df91a7..a8852f2672df3b8c9f1daeadbcee5243191de8f5

From the CL above, assigning the issue to the concern owner

@msramek: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2902843002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3124.0

Comment 2 by ranjitkan@chromium.org, Jun 8 2017

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Thanks.!

Comment 3 by msramek@chromium.org, Jun 8 2017

Labels: -Pri-1 -ReleaseBlock-Stable -Type-Bug-Regression Pri-2 Type-Bug
Mergedinto: 726645
Status: Duplicate (was: Assigned)
The preview is blank in both the expected and actual video, so this is not a regression. It has worked that way on the old Incognito NTP as well.

It's also arguable whether it's a bug in the first place - if you print only the selected text, which is white, on a white background (because the black background is not in itself part of selection), obviously nothing will be visible. This is going to happen on any site with similar properties.

We could perhaps add a print-specific stylesheet that inverts the colors. That way, the background would be always white, regardless of selection, and the text always black. But you would not be able to print the NTP as it really looks like. I don't think it really matters, because this page is really not intended to be printed.
►

Sign in to add a comment