New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731038 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Alignment of 'Some settings belonging to..' Text and Picture is not proper for Multiple sign-in User in chrome://md-settings

Project Member Reported by mmanchala@chromium.org, Jun 8 2017

Issue description

Chrome Version: 61.0.3123.0/9628.0.0 dev-channel Candy,Daisy,Minnie,Peppy,Jerry
OS: (Chrome

What steps will reproduce the problem?
(1) Sign in to user -> logout -> sign in to another user -> Go to Uber tray -> click on user I'd and select 'Sign in to another user...' option
for Multiple sign-in
2)Now in First user go to chrome://md-settings page and observe alignment of 'Some settings belonging to..' Text and Picture (Please refer Screenshot)
 
Expected: Alignment of 'Some settings belonging to..' Text and Picture should be proper
Actual: Instead alignment of 'Some settings belonging to..' Text and Picture is not proper

This is a Regression issue as issue is working fine in 59.0.3071.91/9460.60.0  Beta-channel Candy

 
Note:
1.Issue is not seen in chrome://setting
2.Issue is seen in M-60 also
3.Issue is not applicable to Linux and Windows

@stevenjb: Please confirm the Issue
 
Actual.jpg
110 KB View Download
Expected.jpg
80.9 KB View Download
Labels: -M-61 M-60
Status: Started (was: Assigned)
Should be a simple fix.

Comment 2 by dpa...@chromium.org, Jun 12 2017

Labels: Hotlist-MD-Settings-General
Labels: Merge-Request-60
Status: Fixed (was: Started)
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 20 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
What is the CL here?
Huh. The CL has the correct issue # and it closed...

Here is the CL:
https://codereview.chromium.org/2944213002/

Committed: https://chromium.googlesource.com/chromium/src/+/9ce0a3b055104bd88dda0412d766a22f8423b378

Labels: -Merge-Review-60 Merge-Approved-60
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 27 2017

Cc: josa...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 27 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7da8f0e4de20f6fe2624da443989db5859c6537f

commit 7da8f0e4de20f6fe2624da443989db5859c6537f
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jun 27 16:21:05 2017

Settings: Fix alignment of secondary user warning

BUG= 731038 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2944213002
Cr-Original-Commit-Position: refs/heads/master@{#480844}
Review-Url: https://codereview.chromium.org/2957123002 .
Cr-Commit-Position: refs/branch-heads/3112@{#479}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/7da8f0e4de20f6fe2624da443989db5859c6537f/chrome/browser/resources/settings/basic_page/basic_page.html

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment