Letters in omnibox drop-down move horizontally upon redraw
Reported by
mr.ber...@gmail.com,
Jun 8 2017
|
||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.86 Safari/537.36 Steps to reproduce the problem: 1. Open Omnibox, type "numbers" 2. Type "space, backspace" repeatedly What is the expected behavior? Bold letters in suggestions don't move What went wrong? They move, compare video. Did this work before? N/A Chrome version: 59.0.3071.86 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 25.0 r0 Microsoft Windows [Version 10.0.15063] Same in 61.0.3122.0 (Official Build) canary (64-bit) (cohort: 64-Bit)
,
Jun 9 2017
I feel like the problem is related to a "bold" and a "non-bold" space: note that the part of text typed into the omnibox ("numbers" or "numbers ") is non-bold, while the rest is bold in the suggestion. But then, it's only a brief flickering, and and the final rendering after several hundred ms is the same for "numbers" and "numbers ".
I cannot really make out the problem in your screencast, as your top suggestion keeps switching, which is not the case for me. The changes in position are so tiny that they are really only visible when the top suggestion remains the same and you see the immediate horizontal repositioning, as in my video.
I see the issue on my external 1920x1200 monitor, as well as on my 1920x1080 built-in display (same laptop computer). No HiDpi monitor, I guess.
In incognito mode, I cannot reproduce the issue because there are no Google suggestions. Same in guest profile. I have tried an empty profile (no extensions etc, but I find it difficult to reproduce the same suggestions in this one.
Furthermore, I have noticed another issue which may be related, see attached video. In this one, again, I type only space and backspace, and you see "spanish" briefly appear and immediately disappear in the omnibox. This probably unwanted redrawing my be causing the other effect, to.
,
Jun 9 2017
Note that in #2, I press space only once, and backspace only once, even though at times it looks as if I press backspace twice (once to delete the autocomplete text in the omnibox, and once to delete the previous space).
,
Jun 9 2017
Thank you for providing more feedback. Adding requester "brajkumar@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2017
Having switched to google.com (by calling google.com/ncr a couple of times) and having searched for "numbers" a couple of times in an empty profile, I was able to reproduce the original issue starting from an empty profile, with no extensions or anything else.
,
Jun 12 2017
,
Jun 13 2017
,
Jun 20 2017
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.5 using reported Stable version #59.0.3071.86, latest stable version #59.0.3071.104 and latest canary #61.0.3135.4. This is a Regression issue broken in M-53 Please find the bisect information from below: Bisect Information: ===================== Good build: 53.0.2749.0 Revision(396053) Bad Build : 53.0.2750.0 Revision(396337) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/59d51f9a4cea0fd3d0c27eaf069442b9f556ea9a..d1b22fc961b1a2677c32f61a2a5640850b66adb9 unable to find exact suspect from Changelog Could anyone from dev team please look into it Thanks...!!
,
Jun 20 2017
You said this is not high DPI, but can you confirm your system is set to scale factor 100%? This looks to me like some sort of RenderText drawing artifact from non-1x scale factors. Assigning to someone who would know better.
,
Jun 21 2017
pkasting: Yes, the scale factor is set to "100% (Recommended)" on both external monitor and internal laptop display, and the issue appears on both.
,
Jun 21 2017
Hmm. Very strange. I could imagine this appearing from run breaks in answers or something, but that doesn't look like it would apply in this case. It seems clear that some of the glyphs are shifting by subpixels. I don't know why that would be, or who would know the answer.
,
Jun 21 2017
The bug happens at 1x as well. I dont think this is a HiDPI issue. It seems more like the bold and not bold 'space' character.
,
Jun 21 2017
Maybe the issue is that bold space vs. not bold space differ by some number of subpixels, and we rasterize by layout out the glyphs on subpixel bounds, then snapping closer to the pixel grid; that's why it's possible for letters in the middle of the subsequent run to appear to shift. If that's the case, I don't know what the ideal solution is. I don't think using a bold vs. non-bold space is really a problem we should fix. Maybe somebody who's worked closely with font rasterization has a thought, but I don't know who that would be.
,
Jun 21 2017
We had similar problems in Blink a couple of years ago when we first enabled subpixel positioning. I can't remember exactly how we fixed it off the top of my head but I believe we now align the start of each line box (where the regular text is one line box and the bold part is another one) to a device pixel boundary.
,
Jun 21 2017
,
Jun 26 2017
,
Jun 28 2017
,
Jun 28 2017
From the merged-in bug, according to shrike@, on Mac "This happens all the way back to M46 (I didn't check before that). Given that it's been around so long I'm reducing its priority. Marking as Hotlist-PlatformExcellence - this would be a good bug to fix in one of our Mac team fixits." There's a good chance the regression range listed earlier on this bug is wrong, or at least wrong on Mac. On the other bug, I noted "I think it might have to do with caching, in AutocompleteResult or in SearchProvider."
,
Jun 28 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 28 2018
Still repros. Comments #13/14 describe the current thoughts on the cause and possible direction for solutions. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by brajkumar@chromium.org
, Jun 9 2017Labels: Needs-Feedback
866 KB
866 KB View Download