New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731035 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

LayoutTest virtual/new-remote-playback-pipeline/media/controls/video-controls-overflow-menu-hide-on-click-panel.html is failing on Windows

Project Member Reported by tansell@chromium.org, Jun 8 2017

Issue description

The following layout test(s) is failing on Windows:

virtual/new-remote-playback-pipeline/media/controls/video-controls-overflow-menu-hide-on-click-panel.html

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38a757e7c3e7a65d134a266493d71cf727e95967

commit 38a757e7c3e7a65d134a266493d71cf727e95967
Author: tansell <tansell@chromium.org>
Date: Thu Jun 08 11:51:16 2017

LayoutTest: Disable virtual/new-remote-playback-pipeline/media/controls/video-controls-overflow-menu-hide-on-click-panel.html on Windows

BUG= 731035 
TBR=dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2932633003
Cr-Commit-Position: refs/heads/master@{#477941}

[modify] https://crrev.com/38a757e7c3e7a65d134a266493d71cf727e95967/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc6270044eadb6375b2887e53da26eda610223e4

commit dc6270044eadb6375b2887e53da26eda610223e4
Author: tansell <tansell@chromium.org>
Date: Fri Jun 09 02:26:25 2017

LayoutTests: Disable virtual/new-remote-playback-pipeline/media/controls/controls-cast-overlay-slow-fade.html on Windows.

BUG= 731035 
TBR=dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2924293003
Cr-Commit-Position: refs/heads/master@{#478164}

[modify] https://crrev.com/dc6270044eadb6375b2887e53da26eda610223e4/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by tzik@chromium.org, Jun 12 2017

Owner: avayvod@chromium.org
Status: Assigned (was: Untriaged)
Assigning this to a media_controls owner.

avayvod: Please look into this.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae4989c1e47f0cb8a774a8e9b077687555855f59

commit ae4989c1e47f0cb8a774a8e9b077687555855f59
Author: tzik <tzik@chromium.org>
Date: Mon Jun 12 05:31:05 2017

Mark virtual/new-remote-playback-pipeline/media/controls/video-controls-overflow-menu-hide-on-click-panel.html flaky on Mac

This layout test has been marked flaky on Windows, but also flaky on Mac.
A failure log is:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/20666

TBR=tzik@chromium.org
NOTRY=true

Bug:  731035 
Change-Id: I5ab087150375eef210e145694aabc89c025d7b7b
Reviewed-on: https://chromium-review.googlesource.com/530905
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478555}
[modify] https://crrev.com/ae4989c1e47f0cb8a774a8e9b077687555855f59/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13f15264c3b2b5151bd0076bf53490401314f8ff

commit 13f15264c3b2b5151bd0076bf53490401314f8ff
Author: Anton Vayvod <avayvod@google.com>
Date: Fri Jun 16 22:15:31 2017

[RemotePlayback] Fix Internals::mediaPlayerRemoteRouteAvailabilityChanged

Make RemotePlayback not use the backend for availability monitoring when
it's disabled thus allowing mediaPlayerRemoteRouteAvailabilityChanged to
work reliably.
LayoutTests relying on prompt() to not throw NotSupportedError have to
enable the backend (prompt-twice-throws.html).

BUG= 731035 

Change-Id: Ie03beecc470465f1329cc9281489d4f377e0f98f
Reviewed-on: https://chromium-review.googlesource.com/534714
Commit-Queue: Anton Vayvod <avayvod@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480197}
[modify] https://crrev.com/13f15264c3b2b5151bd0076bf53490401314f8ff/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/94021c7ec45a7226064a9f523dc161c58737f256/third_party/WebKit/LayoutTests/media/remoteplayback/prompt-throws-when-backend-disabled.html
[modify] https://crrev.com/13f15264c3b2b5151bd0076bf53490401314f8ff/third_party/WebKit/LayoutTests/media/remoteplayback/prompt-twice-throws.html
[modify] https://crrev.com/13f15264c3b2b5151bd0076bf53490401314f8ff/third_party/WebKit/LayoutTests/media/remoteplayback/util.js
[delete] https://crrev.com/94021c7ec45a7226064a9f523dc161c58737f256/third_party/WebKit/LayoutTests/media/remoteplayback/watch-availability-works-when-backend-disabled.html
[delete] https://crrev.com/94021c7ec45a7226064a9f523dc161c58737f256/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/controls-cast-overlay-slow-fade-expected.txt
[modify] https://crrev.com/13f15264c3b2b5151bd0076bf53490401314f8ff/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/13f15264c3b2b5151bd0076bf53490401314f8ff/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Status: Fixed (was: Assigned)

Sign in to add a comment