local_ntp.js: Automatically compute checksum |
||
Issue description
Currently, a sha256 hash of local_ntp.js is listed in both local_ntp_source.cc and in local_ntp.html. This makes development quite inconvenient - every time the js is changed, both places have to be updated. It'd be better to automatically update/insert this value during the build process.
Ideas for how to do this: For the .cc, we could generate a header that contains a #define with the value. For the .html, we could either insert it manually (like we already do for "{{CONFIG_INTEGRITY}}"), or we could (ab)use "$i18n{}".
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16f732f4e7a150c7cf1e1104a163814677dd5fb6 commit 16f732f4e7a150c7cf1e1104a163814677dd5fb6 Author: Marc Treib <treib@chromium.org> Date: Thu Jul 13 13:23:25 2017 Local NTP: Automatically compute integrity checksum for local_ntp.js Bug: 731027 Change-Id: I7892f91a072b9b63505102f80ecd2cb5532380c7 Reviewed-on: https://chromium-review.googlesource.com/568033 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#486359} [modify] https://crrev.com/16f732f4e7a150c7cf1e1104a163814677dd5fb6/chrome/browser/BUILD.gn [modify] https://crrev.com/16f732f4e7a150c7cf1e1104a163814677dd5fb6/chrome/browser/resources/local_ntp/local_ntp.html [modify] https://crrev.com/16f732f4e7a150c7cf1e1104a163814677dd5fb6/chrome/browser/resources/local_ntp/local_ntp.js [add] https://crrev.com/16f732f4e7a150c7cf1e1104a163814677dd5fb6/chrome/browser/search/BUILD.gn [modify] https://crrev.com/16f732f4e7a150c7cf1e1104a163814677dd5fb6/chrome/browser/search/local_ntp_source.cc [add] https://crrev.com/16f732f4e7a150c7cf1e1104a163814677dd5fb6/chrome/browser/search/tools/generate_integrity_header.py
,
Jul 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by treib@chromium.org
, Jul 12 2017