New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 731026 link

Starred by 1 user
Status: Fixed
Owner:
█ ananta@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
skare@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 717091



Sign in to add a comment

Try Chrome again dialog appears mid-screen

Project Member Reported by grt@chromium.org, Jun 8 2017 
Chrome Version: 61.0.3123.0 (Developer Build) (32-bit)
OS: Win10

What steps will reproduce the problem?
(1) P50 w/ hi-res display at 200%
(2) connect and disconnect to external display (not yet sure if this is necessary)
(2) out\Deb\chrome.exe --user-data-dir=c:\src\chromium\src\out\Deb\foo --try-chrome-again=0

What is the expected result? the toast appears above the notification area of the task bar.

What happens instead? heavily clipped toast appears in the middle of the screen (see attached).

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Mid-screen toast.png
1.1 MB View Download

Comment 1 by grt@chromium.org, Jun 8 2017 

printf debugging in TryChromeDialogView::ComputeWindowPosition tells me:

work_area: (origin: (0, 0), size: (1920, 1040))
origin: (1549, 846)
computed position: (origin: (774, 423), size: (186, 97))

1920x1040 seems like the scaled screen dimensions, which are then being scaled down a second time by ScreenToDIPRectInWindow.

Does this ring any bells, Ananta? I'll try rebooting now to see if Windows starts reporting things differently. I see all kinds of odd things after switching to an external display then back to the internal hidpi display on this thing.

Comment 2 by grt@chromium.org, Jun 8 2017 

Reboot changed nothing. I think this is unrelated to occasionally using an external display, and all related to hidpi.

Comment 3 by ananta@chromium.org, Jun 9 2017 

Will take a look tomorrow.
Thanks Greg

Comment 4 by grt@chromium.org, Jun 9 2017

Blocking: 717091

Comment 5 by ananta@chromium.org, Jul 26 2017

Status: Started (was: Assigned)
Started
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/655c7008fb0dc647d743c706797d55e5cccd9f65

commit 655c7008fb0dc647d743c706797d55e5cccd9f65
Author: ananta <ananta@chromium.org>
Date: Wed Jul 26 18:35:03 2017

Fix the problem with the TryChromeAgain toast appearing in the wrong place on scale factors other than 1

Reason being we were converting a rectangle which was already in DIPS to DIPs. Fix is to
return a smaller rectangle with the correct origin. Additionally the
size passed to set the toast region has to be in pixels.

BUG= 731026 

Reset to tip

Review-Url: https://codereview.chromium.org/2992493002
Cr-Commit-Position: refs/heads/master@{#489707}

[modify] https://crrev.com/655c7008fb0dc647d743c706797d55e5cccd9f65/chrome/browser/ui/views/try_chrome_dialog_view.cc

Comment 7 by ananta@chromium.org, Jul 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment