Issue metadata
Sign in to add a comment
|
Regression: Alphabet is not properly visible in suggestion list of omnibox.
Reported by
abom...@etouch.net,
Jun 8 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:61.0.3124.0 Revision e88b4570354eca47bc65a98bbba6013f73c6c816-refs/heads/master@{#477839} OS: Mac(10.12.3,10.11.6) What steps will reproduce the problem? 1. Launch chrome and type any alphabet in Omnibox, Observe. Actual: Alphabet is not visible properly in suggestion list. Expected: Alphabet should be visible properly in suggestion list This is regression issue, broken in ‘M 61’ and below is manual bisect info: Good build:61.0.3123.0 Bad build:61.0.3124.0 Note: Issue is not seen on Windows and Linux OS.
,
Jun 8 2017
Able to reproduce the issue on Mac 10.12.4 using chrome reported version-61.0.3124.0. Manual Bisect: ------------- Good build:61.0.3123.0-Revision-477506 Bad build:61.0.3124.0 -Revision-477839 Per revision bisect info: ------------------------- You are probably looking for a change made after 477708 (known good), but no later than 477709 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/1e531eb4ecf2fbf80ce97b92e00de76f46969c8a..8f997af7a224a5c15eece32f1dea70d5a3c676f3 tommycli@, Could you please take look into this issue. Since it is a recent regression ,adding 'Release block stable' label to this issue . Please remove if it is not required. Thank you..!!
,
Jun 8 2017
In your cl did you mean to say NSHeight(renderRect) rather than NSWidth(renderRect)?
,
Jun 8 2017
shrike: Yes, your diagnosis is exactly correct. How embarrassing...
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edcd7da1e6157b263551180f0e26c1a826452d53 commit edcd7da1e6157b263551180f0e26c1a826452d53 Author: tommycli <tommycli@chromium.org> Date: Fri Jun 09 22:01:49 2017 Omnibox UI: Fix Cocoa suggestion lines for short lines (again). BUG= 731025 Review-Url: https://codereview.chromium.org/2924303002 Cr-Commit-Position: refs/heads/master@{#478432} [modify] https://crrev.com/edcd7da1e6157b263551180f0e26c1a826452d53/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm
,
Jun 9 2017
,
Jun 13 2017
Verified the fix on Mac 10.12.5 using Chrome dev version #61.0.3128.0 as per the comment #0. Attaching screen shot for reference. Observed that alphabet was visible properly in suggestion list as expected. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Jun 15 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by abom...@etouch.net
, Jun 8 2017