Convert ARC auth implementation to be customer of Identity Service |
|||||||||
Issue descriptionThe ARC auth implementation is responsible for seeding Android with the information of the Google account that the user is using as their authenticated account in Chrome. This implementation (in //chrome/browser/chromeos/arc/auth) should be moved away from directly depending on signin code (//components/signin, google_apis/gaia) to depending on the Identity Service. See blocking bugs for concrete work items required to make this happen.
,
Jun 8 2017
,
Jun 8 2017
,
Jun 8 2017
,
Nov 1 2017
,
Nov 7 2017
,
Dec 7 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e3550d572933d5dd57a47ce32d7a56f53f01887 commit 1e3550d572933d5dd57a47ce32d7a56f53f01887 Author: Marc Treib <treib@chromium.org> Date: Thu Apr 26 08:14:01 2018 Migrate Arc unit tests to IdentityManager identity::IdentityManager is the new API that replaces SigninManager[Base]. This includes ArcTermsOfServiceDefaultNegotiatorTest and ArcSupportHostTest. Bug: 825190 , 731023 Change-Id: I316c90c6d278e52d723468d63bc21cd288b2642b Reviewed-on: https://chromium-review.googlesource.com/1025898 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#553949} [modify] https://crrev.com/1e3550d572933d5dd57a47ce32d7a56f53f01887/chrome/browser/chromeos/arc/arc_support_host_unittest.cc [modify] https://crrev.com/1e3550d572933d5dd57a47ce32d7a56f53f01887/chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78ad1e6721949ebe27212347bed02ab4a08fcc7a commit 78ad1e6721949ebe27212347bed02ab4a08fcc7a Author: Max Morin <maxmorin@chromium.org> Date: Thu Apr 26 11:20:28 2018 Revert "Migrate Arc unit tests to IdentityManager" This reverts commit 1e3550d572933d5dd57a47ce32d7a56f53f01887. Reason for revert: Failing tests, see crbug.com/837201 Original change's description: > Migrate Arc unit tests to IdentityManager > > identity::IdentityManager is the new API that replaces SigninManager[Base]. > > This includes ArcTermsOfServiceDefaultNegotiatorTest and ArcSupportHostTest. > > Bug: 825190 , 731023 > Change-Id: I316c90c6d278e52d723468d63bc21cd288b2642b > Reviewed-on: https://chromium-review.googlesource.com/1025898 > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553949} TBR=yusukes@chromium.org,treib@chromium.org Change-Id: Iba9649631ec8633c0b89b867a60e89d3d63a01ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825190 , 731023, 837201 Reviewed-on: https://chromium-review.googlesource.com/1030150 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553979} [modify] https://crrev.com/78ad1e6721949ebe27212347bed02ab4a08fcc7a/chrome/browser/chromeos/arc/arc_support_host_unittest.cc [modify] https://crrev.com/78ad1e6721949ebe27212347bed02ab4a08fcc7a/chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5d0c430e0a16f0c67bea814c5674c3f96dd259b commit a5d0c430e0a16f0c67bea814c5674c3f96dd259b Author: Marc Treib <treib@chromium.org> Date: Fri May 04 09:06:46 2018 Reland "Migrate Arc unit tests to IdentityManager" Original CL: https://crrev.com/c/1025898 Revert: https://crrev.com/c/1030150 Patchset 1 contains the original CL. What's changed from there is to set up the primary account without providing a refresh token (like the tests did before this change). Original change's description: > Revert "Migrate Arc unit tests to IdentityManager" > > This reverts commit 1e3550d572933d5dd57a47ce32d7a56f53f01887. > > Reason for revert: Failing tests, see crbug.com/837201 > > Original change's description: > > Migrate Arc unit tests to IdentityManager > > > > identity::IdentityManager is the new API that replaces SigninManager[Base]. > > > > This includes ArcTermsOfServiceDefaultNegotiatorTest and ArcSupportHostTest. > > > > Bug: 825190 , 731023 > > Change-Id: I316c90c6d278e52d723468d63bc21cd288b2642b > > Reviewed-on: https://chromium-review.googlesource.com/1025898 > > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > > Commit-Queue: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553949} > > TBR=yusukes@chromium.org,treib@chromium.org > > Change-Id: Iba9649631ec8633c0b89b867a60e89d3d63a01ad > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 825190 , 731023, 837201 > Reviewed-on: https://chromium-review.googlesource.com/1030150 > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553979} Bug: 825190 , 731023, 837201 Change-Id: I83753ba9036eb9f93ba32c74302dbd151b03c0bf Reviewed-on: https://chromium-review.googlesource.com/1030451 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556017} [modify] https://crrev.com/a5d0c430e0a16f0c67bea814c5674c3f96dd259b/chrome/browser/chromeos/arc/arc_support_host_unittest.cc [modify] https://crrev.com/a5d0c430e0a16f0c67bea814c5674c3f96dd259b/chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc [modify] https://crrev.com/a5d0c430e0a16f0c67bea814c5674c3f96dd259b/services/identity/public/cpp/identity_manager.h
,
Aug 1
,
Sep 3
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by blundell@chromium.org
, Jun 8 2017