sensor layout tests fail on Mac on swarming |
|||||||||||
Issue descriptionThe following layout tests fail on Mac when run on the swarming bots; * sensor/ambient-light-sensor.html [ Failure ] * sensor/gyroscope.html [ Failure ] * sensor/orientation-sensor.html [ Failure ] The errors appear to be; ------------- CONSOLE MESSAGE: line 26: Frequency is limited to 60 Hz. CONSOLE MESSAGE: line 49: Frequency is limited to 60 Hz. This is a testharness.js-based test. PASS AmbientLightSensor: Test that "onerror" is send when sensor is not supported. PASS AmbientLightSensor: Test that "onerror" is send when start() call has failed. PASS AmbientLightSensor: Test that frequency is capped to 60.0 Hz. PASS AmbientLightSensor: Test that configuration is removed for a stopped sensor. PASS AmbientLightSensor: Test that frequency is capped to the maximum supported from frequency. PASS AmbientLightSensor: Test that frequency is limited to the minimum supported from frequency. PASS AmbientLightSensor: Test that sensor can be successfully created and its states are correct. PASS AmbientLightSensor: Test that sensor can be constructed with default configuration. PASS AmbientLightSensor: Test that addConfiguration and removeConfiguration is called. PASS AmbientLightSensor: Test that onChange is called and sensor reading is valid (onchange reporting). PASS AmbientLightSensor: Test that onChange is called and sensor reading is valid (continuous reporting). PASS AmbientLightSensor: Test that sensor receives suspend / resume notifications when page visibility changes. PASS AmbientLightSensor: Test that sensor reading is correct. FAIL AmbientLightSensor: Test that frequency hint works (onchange reporting). assert_equals: expected 2 but got 1 PASS AmbientLightSensor: Test that frequency hint works (continuous reporting). Harness: the test ran to completion. ------------- CONSOLE MESSAGE: line 26: Frequency is limited to 60 Hz. CONSOLE MESSAGE: line 49: Frequency is limited to 60 Hz. This is a testharness.js-based test. PASS Gyroscope: Test that "onerror" is send when sensor is not supported. PASS Gyroscope: Test that "onerror" is send when start() call has failed. PASS Gyroscope: Test that frequency is capped to 60.0 Hz. PASS Gyroscope: Test that configuration is removed for a stopped sensor. PASS Gyroscope: Test that frequency is capped to the maximum supported from frequency. PASS Gyroscope: Test that frequency is limited to the minimum supported from frequency. PASS Gyroscope: Test that sensor can be successfully created and its states are correct. PASS Gyroscope: Test that sensor can be constructed with default configuration. PASS Gyroscope: Test that addConfiguration and removeConfiguration is called. PASS Gyroscope: Test that onChange is called and sensor reading is valid (onchange reporting). PASS Gyroscope: Test that onChange is called and sensor reading is valid (continuous reporting). PASS Gyroscope: Test that sensor receives suspend / resume notifications when page visibility changes. PASS Gyroscope: Test that sensor reading is correct. PASS Gyroscope: Test that frequency hint works (onchange reporting). FAIL Gyroscope: Test that frequency hint works (continuous reporting). assert_equals: expected 2 but got 1 Harness: the test ran to completion. ------------- CONSOLE MESSAGE: line 26: Frequency is limited to 60 Hz. CONSOLE MESSAGE: line 49: Frequency is limited to 60 Hz. CONSOLE MESSAGE: line 26: Frequency is limited to 60 Hz. CONSOLE MESSAGE: line 49: Frequency is limited to 60 Hz. This is a testharness.js-based test. PASS AbsoluteOrientationSensor: Test that "onerror" is send when sensor is not supported. PASS AbsoluteOrientationSensor: Test that "onerror" is send when start() call has failed. PASS AbsoluteOrientationSensor: Test that frequency is capped to 60.0 Hz. PASS AbsoluteOrientationSensor: Test that configuration is removed for a stopped sensor. PASS AbsoluteOrientationSensor: Test that frequency is capped to the maximum supported from frequency. PASS AbsoluteOrientationSensor: Test that frequency is limited to the minimum supported from frequency. PASS AbsoluteOrientationSensor: Test that sensor can be successfully created and its states are correct. PASS AbsoluteOrientationSensor: Test that sensor can be constructed with default configuration. PASS AbsoluteOrientationSensor: Test that addConfiguration and removeConfiguration is called. PASS AbsoluteOrientationSensor: Test that onChange is called and sensor reading is valid (onchange reporting). PASS AbsoluteOrientationSensor: Test that onChange is called and sensor reading is valid (continuous reporting). PASS AbsoluteOrientationSensor: Test that sensor receives suspend / resume notifications when page visibility changes. PASS AbsoluteOrientationSensor: Test that sensor reading is correct. PASS AbsoluteOrientationSensor: Test that frequency hint works (onchange reporting). FAIL AbsoluteOrientationSensor: Test that frequency hint works (continuous reporting). assert_equals: expected 3 but got 2 PASS Test AbsoluteOrientationSensor.populateMatrix() method works correctly. PASS RelativeOrientationSensor: Test that "onerror" is send when sensor is not supported. PASS RelativeOrientationSensor: Test that "onerror" is send when start() call has failed. PASS RelativeOrientationSensor: Test that frequency is capped to 60.0 Hz. PASS RelativeOrientationSensor: Test that configuration is removed for a stopped sensor. PASS RelativeOrientationSensor: Test that frequency is capped to the maximum supported from frequency. PASS RelativeOrientationSensor: Test that frequency is limited to the minimum supported from frequency. PASS RelativeOrientationSensor: Test that sensor can be successfully created and its states are correct. PASS RelativeOrientationSensor: Test that sensor can be constructed with default configuration. PASS RelativeOrientationSensor: Test that addConfiguration and removeConfiguration is called. PASS RelativeOrientationSensor: Test that onChange is called and sensor reading is valid (onchange reporting). PASS RelativeOrientationSensor: Test that onChange is called and sensor reading is valid (continuous reporting). PASS RelativeOrientationSensor: Test that sensor receives suspend / resume notifications when page visibility changes. PASS RelativeOrientationSensor: Test that sensor reading is correct. FAIL RelativeOrientationSensor: Test that frequency hint works (onchange reporting). assert_equals: expected 2 but got 1 PASS RelativeOrientationSensor: Test that frequency hint works (continuous reporting). PASS Test RelativeOrientationSensor.populateMatrix() method works correctly. Harness: the test ran to completion. -------------
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef284701964ccddc1c0878926e32d6ffc0254a59 commit ef284701964ccddc1c0878926e32d6ffc0254a59 Author: tansell <tansell@chromium.org> Date: Thu Jun 08 11:12:49 2017 LayoutTests: Disabling sensor tests which fail on Mac swarming. The following layout tests fail on Mac when run on the swarming bots; * sensor/accelerometer.html * sensor/ambient-light-sensor.html * sensor/gyroscope.html * sensor/orientation-sensor.html The problem seems to be related to frequency being limited to 60Hz? BUG=731018, 717344 TBR=mcgreevy@chromium.org,dpranke@chromium.org,qyearsley@chromium.org,reillyg@chromium.org Review-Url: https://codereview.chromium.org/2925243002 Cr-Commit-Position: refs/heads/master@{#477940} [modify] https://crrev.com/ef284701964ccddc1c0878926e32d6ffc0254a59/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56752fc224c8d7af28f92332edca9d1853f25626 commit 56752fc224c8d7af28f92332edca9d1853f25626 Author: tansell <tansell@chromium.org> Date: Thu Jun 08 15:12:31 2017 LayoutTests: Disabling sensor tests which fail on Mac swarming. The following layout tests fail on Mac when run on the swarming bots; * sensor/magnetometer.html The problem seems to be related to frequency being limited to 60Hz? BUG=731018, 717344 TBR=mcgreevy@chromium.org,dpranke@chromium.org,qyearsley@chromium.org,reillyg@chromium.org Review-Url: https://codereview.chromium.org/2926073004 Cr-Commit-Position: refs/heads/master@{#477970} [modify] https://crrev.com/56752fc224c8d7af28f92332edca9d1853f25626/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 8 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db3258114828a8013686b1ade97f60d4e8211308 commit db3258114828a8013686b1ade97f60d4e8211308 Author: tansell <tansell@chromium.org> Date: Thu Jun 22 06:42:31 2017 LayoutTests: The sensor tests are crashing when DCHECK is enabled (on Mac) BUG=731018, 717344 TBR=mcgreevy@chromium.org,dpranke@chromium.org,qyearsley@chromium.org,reillyg@chromium.org,alexander.shalamov@intel.com NOTRY=true Review-Url: https://codereview.chromium.org/2950063003 Cr-Commit-Position: refs/heads/master@{#481467} [modify] https://crrev.com/db3258114828a8013686b1ade97f60d4e8211308/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 22 2017
,
Jul 3 2017
,
Jul 3 2017
Example of assertion hit: FATAL:sensorproxy.cpp(128)] Check failed: reading_data.timestamp > reading_.timestamp (0 vs. 1.82991)Timestamps must increase monotonically
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0e7f7ef3c8058198e5bbaf587db91d81841f3b7 commit f0e7f7ef3c8058198e5bbaf587db91d81841f3b7 Author: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Date: Thu Jul 06 10:37:40 2017 [Sensors] Stop processing pending reading notifications SensorProxy should not process reading notifications pending in IPC channel after the wrapped sensor got suspended or stopped. Such processing is unnecessary and it causes a flaky assertion hit during layout tests run when reading is processed after shared buffer is zeroed. Bug: 731018 Change-Id: Iba0d45a4ebfb4f1b424eb118b470bbfea656f174 Reviewed-on: https://chromium-review.googlesource.com/559096 Commit-Queue: Mikhail Pozdnyakov (OOO till Jul 17th) <mikhail.pozdnyakov@intel.com> Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#484533} [modify] https://crrev.com/f0e7f7ef3c8058198e5bbaf587db91d81841f3b7/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp [modify] https://crrev.com/f0e7f7ef3c8058198e5bbaf587db91d81841f3b7/third_party/WebKit/Source/modules/sensor/SensorProxy.h
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8dda22a0f658ad4b99cf50252eb13d8a628a33e commit a8dda22a0f658ad4b99cf50252eb13d8a628a33e Author: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Date: Thu Jul 06 10:57:45 2017 [Sensor] Fix layout tests on Mac swarming Flakiness of 'checkFrequencyHintWorks()' in layout tests was caused by the fact that the 'slowSensor.onreading' wrapper is sometimes called before the 'fastSensor.onreading' wrapper. Bug: 731018 Change-Id: I6557f23b43731bc21afab03a295502ade7f359b7 Reviewed-on: https://chromium-review.googlesource.com/559126 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Mikhail Pozdnyakov (OOO till Jul 17th) <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#484538} [modify] https://crrev.com/a8dda22a0f658ad4b99cf50252eb13d8a628a33e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/a8dda22a0f658ad4b99cf50252eb13d8a628a33e/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js
,
Jul 17 2017
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=sensor%2F shows that the flakiness is actually gone
,
Aug 12 2017
Still a bunch of flakyiness - see https://chromium-swarm.appspot.com/task?id=37eec44c4bc55610&refresh=10&show_raw=1 for example; --------------------------- 04:02:44.392 43715 worker/2 shadow-dom/focus-method-with-delegatesFocus.html passed 04:02:44.478 43714 renderer crash, pid = None, error_line = #CRASHED - renderer 04:02:44.478 43714 killed pid 49556 04:02:44.481 43714 worker/1 sensor/gyroscope.html crashed, (stderr lines): 04:02:44.482 43714 [49558:775:0812/040244.313558:42075517019597:FATAL:SensorProxy.cpp(125)] Check failed: reading_data.timestamp() > reading_.timestamp() (0 vs. 1.26058)Timestamps must increase monotonically 04:02:44.482 43714 0 Content Shell Framework 0x000000010decab4c base::debug::StackTrace::StackTrace(unsigned long) + 28 04:02:44.482 43714 1 Content Shell Framework 0x000000010deeee10 logging::LogMessage::~LogMessage() + 224 04:02:44.482 43714 2 Content Shell Framework 0x0000000111bf5a35 blink::SensorProxy::UpdateSensorReading() + 309 04:02:44.482 43714 3 Content Shell Framework 0x0000000111bf5beb blink::SensorProxy::SensorReadingChanged() + 139 04:02:44.482 43714 4 Content Shell Framework 0x000000010dceac83 device::mojom::blink::SensorClientStubDispatch::Accept(device::mojom::blink::SensorClient*, mojo::Message*) + 371 04:02:44.482 43714 5 Content Shell Framework 0x000000010e2058eb mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) + 955 04:02:44.482 43714 6 Content Shell Framework 0x000000010e205206 mojo::FilterChain::Accept(mojo::Message*) + 150 04:02:44.482 43714 7 Content Shell Framework 0x000000010e206c35 mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) + 117 04:02:44.482 43714 8 Content Shell Framework 0x000000010e210afa mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::Message*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) + 1034 04:02:44.482 43714 9 Content Shell Framework 0x000000010e2102a6 mojo::internal::MultiplexRouter::Accept(mojo::Message*) + 294 04:02:44.482 43714 10 Content Shell Framework 0x000000010e205206 mojo::FilterChain::Accept(mojo::Message*) + 150 04:02:44.482 43714 11 Content Shell Framework 0x000000010e2004e5 mojo::Connector::ReadSingleMessage(unsigned int*) + 421 04:02:44.482 43714 12 Content Shell Framework 0x000000010e200fd1 mojo::Connector::ReadAllAvailableMessages() + 97 04:02:44.482 43714 13 Content Shell Framework 0x000000010e200e89 mojo::Connector::OnHandleReadyInternal(unsigned int) + 137 04:02:44.482 43714 14 Content Shell Framework 0x000000010c6ce0d5 mojo::SimpleWatcher::DiscardReadyState(base::Callback<void (unsigned int), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, unsigned int, mojo::HandleSignalsState const&) + 21 04:02:44.482 43714 15 Content Shell Framework 0x000000010e21c98a mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) + 362 04:02:44.482 43714 16 Content Shell Framework 0x000000010e21ce2f void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, 0ul, 1ul, 2ul, 3ul>(void (mojo::SimpleWatcher::* const&&&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&&&, base::IndexSequence<0ul, 1ul, 2ul, 3ul>) + 191 04:02:44.482 43714 17 Content Shell Framework 0x000000010decb48b base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 251 04:02:44.482 43714 18 Content Shell Framework 0x000000010dc645b0 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(blink::scheduler::internal::WorkQueue*, bool, blink::scheduler::LazyNow, base::TimeTicks*) + 1232 04:02:44.482 43714 19 Content Shell Framework 0x000000010dc61ff4 blink::scheduler::TaskQueueManager::DoWork(bool) + 804 04:02:44.482 43714 20 Content Shell Framework 0x000000010dc667f9 base::internal::Invoker<base::internal::BindState<void (blink::scheduler::TaskQueueManager::*)(bool), base::WeakPtr<blink::scheduler::TaskQueueManager>, bool>, void ()>::Run(base::internal::BindStateBase*) + 185 04:02:44.482 43714 21 Content Shell Framework 0x000000010decb48b base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 251 04:02:44.483 43714 22 Content Shell Framework 0x000000010df07429 base::MessageLoop::RunTask(base::PendingTask*) + 441 04:02:44.483 43714 23 Content Shell Framework 0x000000010df0777e base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 206 04:02:44.483 43714 24 Content Shell Framework 0x000000010df07ae9 base::MessageLoop::DoWork() + 441 04:02:44.483 43714 25 Content Shell Framework 0x000000010df0c09a base::MessagePumpCFRunLoopBase::RunWork() + 42 04:02:44.483 43714 26 Content Shell Framework 0x000000010def09ca base::mac::CallWithEHFrame(void () block_pointer) + 10 04:02:44.483 43714 27 Content Shell Framework 0x000000010df0b98f base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63 04:02:44.483 43714 28 CoreFoundation 0x00007fff8eee8321 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 04:02:44.483 43714 29 CoreFoundation 0x00007fff8eec921d __CFRunLoopDoSources0 + 557 04:02:44.483 43714 30 CoreFoundation 0x00007fff8eec8716 __CFRunLoopRun + 934 04:02:44.483 43714 31 CoreFoundation 0x00007fff8eec8114 CFRunLoopRunSpecific + 420 04:02:44.483 43714 32 Foundation 0x00007fff908db4e2 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277 04:02:44.483 43714 33 Content Shell Framework 0x000000010df0c7fe base::MessagePumpNSRunLoop::DoRun(base::MessagePump::Delegate*) + 126 04:02:44.483 43714 34 Content Shell Framework 0x000000010df0b1ac base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 92 04:02:44.483 43714 35 Content Shell Framework 0x000000010df06e72 base::MessageLoop::Run() + 146 04:02:44.483 43714 36 Content Shell Framework 0x000000010df3c908 base::RunLoop::Run() + 168 04:02:44.483 43714 37 Content Shell Framework 0x0000000111fb0740 content::RendererMain(content::MainFunctionParams const&) + 768 04:02:44.483 43714 38 Content Shell Framework 0x000000010c8011a3 content::ContentMainRunnerImpl::Run() + 563 04:02:44.483 43714 39 Content Shell Framework 0x000000010f8ee1e6 service_manager::Main(service_manager::MainParams const&) + 2582 04:02:44.483 43714 40 Content Shell Framework 0x000000010c800564 content::ContentMain(content::ContentMainParams const&) + 68 04:02:44.483 43714 41 Content Shell Framework 0x000000010c096106 ContentMain + 70 04:02:44.483 43714 42 libdyld.dylib 0x00007fffa4642235 start + 1 04:02:44.483 43714 04:02:44.501 43676 [27645/30215] sensor/gyroscope.html failed unexpectedly (renderer crashed) 04:02:44.496 43714 worker/1 killing primary driver 04:02:44.498 43714 worker/1 killing secondary driver 04:02:44.498 43714 worker/1 sensor/gyroscope.html failed: 04:02:44.498 43714 worker/1 renderer crashed -------------------------
,
Aug 12 2017
,
Aug 12 2017
,
Aug 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e2fde0b14bf5884912303f27f7fe56ead63bbb8 commit 6e2fde0b14bf5884912303f27f7fe56ead63bbb8 Author: Tim 'mithro' Ansell <tansell@chromium.org> Date: Sat Aug 12 15:00:15 2017 LayoutTests: Disabling flaky sensor based tests on Mac. They are randomly failing the following DCHECK; FATAL:sensorproxy.cpp(128)] Check failed: reading_data.timestamp > reading_.timestamp (0 vs. 1.82991)Timestamps must increase monotonically Example at https://chromium-swarm.appspot.com/task?id=37eec44c4bc55610&refresh=10&show_raw=1 BUG=731018 TBR=mikhail.pozdnyakov@intel.com,qyearsley@chromium.org,jeffcarp@chromium.org,mcgreevy@chromium.org,dpranke@chromium.org,alexander.shalamov@intel.com,reillyg@chromium.org Change-Id: I2223b5d6b05e3e46253a791b9909174914fb5654 Reviewed-on: https://chromium-review.googlesource.com/612005 Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org> Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org> Cr-Commit-Position: refs/heads/master@{#493973} [modify] https://crrev.com/6e2fde0b14bf5884912303f27f7fe56ead63bbb8/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 15 2017
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/345c35b5d07085034e1182451fa546095a6a700d commit 345c35b5d07085034e1182451fa546095a6a700d Author: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Date: Fri Aug 18 05:53:28 2017 SensorProxy should handle list of active frequencies synchronously This allows stop polling immediately after SensorProxy::RemoveConfiguration call and makes the code path simpler. This patch also fixes a flaky assertion hit when layout tests run and shared buffer is zeroed before polling is stopped. Bug: 731018 Change-Id: Id7721deaa7ad0811844fe67fc060ee8da33bbfbf Reviewed-on: https://chromium-review.googlesource.com/615241 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#495473} [modify] https://crrev.com/345c35b5d07085034e1182451fa546095a6a700d/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js [modify] https://crrev.com/345c35b5d07085034e1182451fa546095a6a700d/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp [modify] https://crrev.com/345c35b5d07085034e1182451fa546095a6a700d/third_party/WebKit/Source/modules/sensor/SensorProxy.h
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b23c34c24dfd02ae49232f39cc3019397b38345 commit 0b23c34c24dfd02ae49232f39cc3019397b38345 Author: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Date: Tue Aug 22 10:20:22 2017 [sensors] Improve accuracy of reporting interval This patch decreases minimum waiting interval treshold to 0.01 seconds making reporting intervals more accurate. The corresponding layout test is simplified. Bug: 731018 Change-Id: I6efa89af02d4496dd959948b2a57c02108df36d2 Reviewed-on: https://chromium-review.googlesource.com/625620 Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#496269} [modify] https://crrev.com/0b23c34c24dfd02ae49232f39cc3019397b38345/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js [modify] https://crrev.com/0b23c34c24dfd02ae49232f39cc3019397b38345/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js [modify] https://crrev.com/0b23c34c24dfd02ae49232f39cc3019397b38345/third_party/WebKit/Source/modules/sensor/Sensor.cpp
,
Aug 23 2017
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=sensor%2F is not showing a single sensor failure since the latest patches landed.
,
Jun 18 2018
Reopening this issue as the dashboard in comment #19 still shows flakiness of these tests on MacOS.
,
Jun 18 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 Deleted