New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731016 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 749367
issue 750116



Sign in to add a comment

Move board information from VPD to mosys

Project Member Reported by hungte@chromium.org, Jun 8 2017

Issue description

Currently we rely on factory process to provision few VPD values into device - at least rlz_brand_code and customization_id.

This started from that rlz_brand_code should be bound to device instead of from disk image (which makes it harder to share images). However it falls to same problem the regional (go/cros-regional-vpd) vpds have: (1) it's hard to make sure partners have filled right values (2) RO VPD values can't be updated once it's written (3) dogfood and early builds may not have right information provisioned.

Regional VPDs were solved by an update-able JSON database. rlz_brand_code and customization_id are more hardware-dependent so they should be solved in same way chassis id was introduced (go/cros-chassis-id) - provided by a command (mosys) allowing per-board customization.

The proposal is to add two mosys platform sub command:

 mosys platform brand # prints rlz_brand_code
 mosys platform customization # prints customization_id, if needed

Programs reading these values should use mosys instead.

(Chrome reads from from machine-info, and we may keep same name in machine-info file so Chrome won't need to be changed).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c3de65982da78823ee142e97d7c95a89f71e134c

commit c3de65982da78823ee142e97d7c95a89f71e134c
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jun 09 10:42:17 2017

login: Reads machine information from mosys.

Some values (rlz_brand_code, customization_id) were expected to be
provisioned in factory, but this is getting harder and harder when there
are more forked projects (or projects sharing same image, same factory
flow).

The long term plan is to move all board customization to be based on
some hardware-based identifier. As a result, we want to change those
information to come from system commands, no need to exist in VPD.

This change adds two mosys calls, each mapped to one VPD value, to
machine info. Existing devices with rlz_brand_code and customization_id
provisioned will see same value, and new devices without those VPDs will
get same information from mosys.

BUG= chromium:731016 
TEST=manually installed to DUT, reboot and see new machine info.

Change-Id: I5322e89c85330e53b9e9e29bcf53b42568ebc2f9
Reviewed-on: https://chromium-review.googlesource.com/527977
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/c3de65982da78823ee142e97d7c95a89f71e134c/login_manager/init/scripts/write-machine-info

Comment 2 by hungte@chromium.org, Jun 29 2017

Status: Started (was: Untriaged)

Comment 3 by hungte@chromium.org, Jul 12 2017

Cc: yhong@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/0413467b1b0af78e303038ce8a05578fc2d3eaa1

commit 0413467b1b0af78e303038ce8a05578fc2d3eaa1
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jul 21 04:21:18 2017

platform: Remove HWID from probing logic.

It is incorrect to probe mosys platform by HWID, because:

1. HWID is provisioned in factory by assigned configuration file, and
   there's no promise for that its leading name should be, nor
   indication to the mapping of target platform.

2. Most of the HWID probe string in mosys were wrong. We only had "X86"
   as prefix on MARIO, not any other devices, which means the probing
   didn't work for a long time.

To prevent wasting more time in probing and reduce incorrect assumption,
I'd like to remove probing of HWID in all the implementations.

Also corrected probe_frid prototype, which seem to have been cloned from
probe_hwid and kept the incorrect parameter names.

BRANCH=None
BUG= chromium:731016 
TEST=emerge-eve mosys; mosys platform name

Change-Id: I1277f6c3818ffb51e82b94b8464b8740573a7f33
Reviewed-on: https://chromium-review.googlesource.com/574983
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>

[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/rambi/rambi.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/samsung/stumpy/stumpy.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/beltino/beltino.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/mario/cr48.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/hp/spring/spring.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/lib/acpi/chromeos_acpi.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/reef/reef.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/auron/auron.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/samus/samus.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/samsung/alex/series5.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/acer/parrot/parrot.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/glados/glados.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/cyan/cyan.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/strago/strago.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/fizz/fizz.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/lenovo/stout/stout.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/experimental/kiev/kiev.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/skate/skate.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/samsung/lumpy/lumpy.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/lib/misc/probe.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/include/lib/probe.h
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/slippy/slippy.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/hp/butterfly/butterfly.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/acer/zgb/chromia700.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/link/link.c
[modify] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/include/lib/acpi.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/22a8fdf7b923af41b7b43fb08982b2712dd7a97a

commit 22a8fdf7b923af41b7b43fb08982b2712dd7a97a
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jul 21 04:21:19 2017

platform: Flatten platform folders.

Adding OEM name as one extra layer does not really help in finding right
platform, and is actually causing more problems before project is
officially launched; and that is why all modern projects always live in
"google" folder.

As a result, it seems more reasonable to just move every board into
platform/, which also makes it easier to maintain platform_list.c.

BRANCH=none
BUG= chromium:731016 
TEST=emerge-eve mosys; mosys platform name

Change-Id: Ie473efadc2a3e336c969c645462dfbedb516cfd8
Reviewed-on: https://chromium-review.googlesource.com/575613
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Duncan Laurie <dlaurie@google.com>

[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/kiev/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/samus/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/peach/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stout/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyan/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/butterfly/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/strago/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/gru/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/link/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/alex/vpd.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/daisy/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/pinky/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/slippy/sys.c
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/hp/Kconfig
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/lumpy/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/pinky/psu.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/kiev/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/smaug/smaug.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/oak/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/reef/reef.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/pinky/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/nyan/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/reef/reef.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/slippy/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/fizz/fizz.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/peach/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/zgb/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/kiev/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/glados/Makefile
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/acer/Kconfig
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/butterfly/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/fizz/fizz.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/nyan/psu.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/oak/oak.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/reef/Makefile
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/hp/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/alex/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/beltino/beltino.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/parrot/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/link/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/slippy/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stout/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyan/gpio.c
[modify] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/skate/skate.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/samus/samus.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/slippy/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/link/Makefile
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/skate/skate.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stumpy/sensors.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/spring/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stumpy/stumpy.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/peach/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyclone/cyclone.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/storm/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/link/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyclone/cyclone.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/glados/glados.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stumpy/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/gru/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/auron/Makefile
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/lenovo/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/strago/strago.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/samus/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/slippy/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/z600/z600.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/samus/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stout/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/strago/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/skate/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/auron/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/mario/cr48.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/parrot/parrot.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/mario/cr48.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/glados/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/rambi/psu.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/parrot/parrot.c
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/experimental/Kconfig
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyan/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/reef/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/zgb/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/skate/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyan/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/fizz/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/oak/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/alex/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/glados/glados.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/oak/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/kiev/sensors.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/mario/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/beltino/beltino.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/fizz/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/daisy/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/beltino/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/butterfly/storage.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/daisy/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/z600/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/lumpy/Makefile
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/lenovo/Kconfig
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/skate/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/pinky/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/alex/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/link/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/kiev/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/mario/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/fizz/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/spring/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/strago/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/z600/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/kiev/kiev.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/zgb/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/kiev/kiev.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/zgb/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/strago/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/zgb/chromia700.h
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/google/Kconfig
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyclone/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stout/storage.c
[modify] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/Kconfig
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stout/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/pinky/pinky.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/butterfly/butterfly.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stumpy/stumpy.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/butterfly/butterfly.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/butterfly/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/spring/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/samus/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/spring/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stumpy/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/smaug/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/kiev/vpd.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/mario/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyan/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/peach/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/smaug/smaug.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/reef/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/mario/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/nyan/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/rambi/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/auron/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/zgb/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/beltino/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/daisy/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/butterfly/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/fizz/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stout/stout.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/gru/gru.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/daisy/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stout/battery.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/auron/auron.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/samus/samus.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/rambi/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/gru/gru.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stout/stout.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/skate/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/auron/auron.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/parrot/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/mario/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyan/cyan.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stout/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyan/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/lumpy/lumpy.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyan/cyan.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/slippy/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/oak/oak.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/zgb/vpd.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/lumpy/sensors.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyclone/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/parrot/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/auron/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/storm/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stumpy/vpd.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/spring/spring.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/lumpy/memory.c
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/experimental/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/spring/spring.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/alex/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/z600/z600.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/rambi/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/reef/eeprom.c
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/samsung/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/glados/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/glados/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/nyan/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/kiev/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/auron/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/link/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/z600/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/link/link.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stumpy/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/strago/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/strago/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/lumpy/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/link/link.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/rambi/rambi.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/lumpy/lumpy.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/rambi/Makefile
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/acer/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/daisy/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/rambi/rambi.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/gru/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/pinky/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/spring/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/strago/strago.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/rambi/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/reef/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/storm/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/samus/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/lumpy/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stumpy/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/skate/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/storm/storm.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/smaug/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/daisy/daisy.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/nyan/nyan.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/peach/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/samus/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stout/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/daisy/daisy.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/nyan/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/spring/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/nyan/nyan.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/butterfly/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/beltino/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/mario/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/alex/series5.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/storm/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/peach/peach.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/alex/series5.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/beltino/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/gru/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyclone/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/rambi/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/peach/peach.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/parrot/nvram.c
[delete] https://crrev.com/0413467b1b0af78e303038ce8a05578fc2d3eaa1/platform/samsung/Kconfig
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/smaug/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/cyclone/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/alex/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/glados/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/parrot/vpd.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/lumpy/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/storm/storm.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/beltino/sensors.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/auron/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/zgb/ec.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/zgb/chromia700.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/rambi/gpio.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/beltino/eeprom.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/pinky/pinky.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/slippy/memory.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/butterfly/nvram.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/beltino/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/link/sys.c
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/stumpy/Makefile
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platform/slippy/slippy.h
[rename] https://crrev.com/22a8fdf7b923af41b7b43fb08982b2712dd7a97a/platf
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/d0d55f76a6252720dd4b52f675dc0dab07620b37

commit d0d55f76a6252720dd4b52f675dc0dab07620b37
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jul 21 11:09:29 2017

lib: smbios: Add 'smbios_sysinfo_get_sku_number'

The 'smbios_sysinfo_get_sku' returns a string. In current Coreboot, this
is written in form 'sku%d'. To make it easier for interface to fetch SKU
number, add a helper function smbios_sysinfo_get_sku_number that returns
SKU number in integer form.

BRANCH=none
BUG= chromium:731016 
TEST=emerge-chell mosys; mosys platform name

Change-Id: Ic3ef651d907fcd8c5e14e9ed5c9040f37de6c0b2
Reviewed-on: https://chromium-review.googlesource.com/579254
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/d0d55f76a6252720dd4b52f675dc0dab07620b37/include/lib/smbios.h
[modify] https://crrev.com/d0d55f76a6252720dd4b52f675dc0dab07620b37/lib/smbios/mosys_callbacks.c

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/59aded740273a36d50afa2281faeab851a617668

commit 59aded740273a36d50afa2281faeab851a617668
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Jul 25 05:54:05 2017

lib: Move SKU information to a new module (lib/misc/sku).

To support devices sharing same image and firmware, we will need to
probe system information by adding another layer - lookup in the "SKU" table.

To standardize and simplify the way of defining SKU table, a new module
"lib/misc/sku.c" is added and provides functions like:
 sku_get_number
 sku_get_brand
 sku_get_chassis
 sku_get_customization
 sku_get_model
 sku_get_data

These are fallback implementations for platform commands if
`sys->cb->sku_number` is implemented and the platform_intf->sku_table is
filled with an array of struct sku_table.

BRANCH=none
BUG= chromium:731016 
TEST=emerge-eve mosys; mosys platform name

Change-Id: Ibb20003a128163012f01c773f7210252c86d91bf
Reviewed-on: https://chromium-review.googlesource.com/577473
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[add] https://crrev.com/59aded740273a36d50afa2281faeab851a617668/lib/misc/sku.c
[add] https://crrev.com/59aded740273a36d50afa2281faeab851a617668/include/lib/sku.h
[modify] https://crrev.com/59aded740273a36d50afa2281faeab851a617668/include/lib/probe.h
[modify] https://crrev.com/59aded740273a36d50afa2281faeab851a617668/include/mosys/platform.h
[modify] https://crrev.com/59aded740273a36d50afa2281faeab851a617668/core/command/platform.c
[modify] https://crrev.com/59aded740273a36d50afa2281faeab851a617668/lib/misc/Makefile
[modify] https://crrev.com/59aded740273a36d50afa2281faeab851a617668/lib/misc/probe.c

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/e3603b43f3886611276d14b23ac4dffaa6642e97

commit e3603b43f3886611276d14b23ac4dffaa6642e97
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Jul 25 14:00:23 2017

reef: Support SKU based mapping for platform info.

To support devices sharing same image and same firmware, we need to
identify system by SKU number (which is a root of trust from hardware
straps).

This is an initial attempt to convert Reef into new model. Few devices
have brand code defined and few devices have model or chassis id
defined. Customization value may be added in future.

BRANCH=none
BUG= chromium:731016 
TEST=emerge-reef mosys; mosys platform name; mosys platform chassis

Change-Id: I9b06db5937cdfd064c2f0654725b9299def6d762
Reviewed-on: https://chromium-review.googlesource.com/577474
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/e3603b43f3886611276d14b23ac4dffaa6642e97/platform/reef/sys.c
[modify] https://crrev.com/e3603b43f3886611276d14b23ac4dffaa6642e97/platform/reef/reef.c

Comment 9 by hungte@chromium.org, Jul 25 2017

Labels: OS-Chrome
Blocking: 749367
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/a3db9a3b70cc58321317575cd3fc85c24b9567e9

commit a3db9a3b70cc58321317575cd3fc85c24b9567e9
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Jul 27 05:41:52 2017

glados: Support SKU based mapping for platform info.

Old glados projects don't really have SKU straps, but we still want to
do the transition because (1) poppy is sharing glados platform
implementation and may have SKU straps in future, (2) factory flow will
stop provisioning the SKU information VPD values soon.

As a result, we want to move the definition of chassis, RLZ brand code,
and customization into platform probing list.

This is an initial venison that customization IDs were not included yet.

BRANCH=none
BUG= chromium:731016 
TEST=emerge-chell mosys; mosys platform name

Change-Id: I6712805e5036b1107b97a12a42aa91451d3a5a1e
Reviewed-on: https://chromium-review.googlesource.com/577475
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/a3db9a3b70cc58321317575cd3fc85c24b9567e9/platform/glados/sys.c
[modify] https://crrev.com/a3db9a3b70cc58321317575cd3fc85c24b9567e9/platform/glados/glados.c

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/0d49941532865febd4a858b714cbeb5db17582f1

commit 0d49941532865febd4a858b714cbeb5db17582f1
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Jul 27 05:41:52 2017

reef: Add more SKU mappings.

Add blue, bruce, whitetip, and nasher.

BRANCH=none
BUG= chromium:731016 
TEST=emerge-reef mosys; mosys platform name

Change-Id: Ib67d2e85203c4f32d7c89ccc0a3003ab4ae461ee
Reviewed-on: https://chromium-review.googlesource.com/584655
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/0d49941532865febd4a858b714cbeb5db17582f1/platform/reef/reef.c

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/f7e0ede073a3965d5cff5b972927ee67d1612b5b

commit f7e0ede073a3965d5cff5b972927ee67d1612b5b
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Jul 27 09:42:53 2017

lib: sku: 'customization' fallback to model name when not defined in VPD.

Future projects should use model (project) name for customization ID if
needed. This is currently used by both firmware updater to find rootkey,
and OOBE to find initial wallpaper and applications.

BRANCH=None
BUG= chromium:731016 
TEST=emerge-eve mosys; vpd -d customization_id; dump_vpd_log --force; reboot;
     mosys platform customization  # prints EVE

Change-Id: I6ad28968c5e00d17470aa0ebc3711d2f4775acb3
Reviewed-on: https://chromium-review.googlesource.com/584566
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/f7e0ede073a3965d5cff5b972927ee67d1612b5b/lib/misc/sku.c
[modify] https://crrev.com/f7e0ede073a3965d5cff5b972927ee67d1612b5b/include/lib/sku.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 27 2017

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/docs/+/e726da6dfeaa2123b4df19bcfc87f6983d5b3c4f

commit e726da6dfeaa2123b4df19bcfc87f6983d5b3c4f
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Jul 27 16:11:02 2017

Blocking: 750116
Hungte, can't this be closed? Your change has been merged quite a while back.
Status: Fixed (was: Started)
Wondering if we'll add more stuff, but for now it's probably fine to close.

Comment 19 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment