New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 730983 link

Starred by 1 user
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Jun 2017
Cc:
█ junov@chromium.org
█ zakerinasab@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 713891



Sign in to add a comment

color: fast/canvas/webgl/texImage-imageBitmap-from-image fails with --enable-color-correct-rendering

Project Member Reported by ccameron@chromium.org, Jun 8 2017 
These tests are failing when color correct rendering is enabled.
* fast/canvas/webgl/texImage-imageBitmap-from-image-resize.html
* fast/canvas/webgl/texImage-imageBitmap-from-image.html

Comment 1 by ccameron@chromium.org, Jun 8 2017

Cc: zakerinasab@chromium.org junov@chromium.org
The immediate fix for this is to change ImageSource to use ColorBehavior::transformToGlobalTarget instead of ColorBehavior::tag.

Taking a step back, we can also makeColorSpace(SRGB) the result of ImageSource::CreateFrameAtIndex, and this passes.

The next step back is that we can make ApplyColorSpaceConversion in ImageBitmap.cpp do image 
= image->makeColorSpace(SRGB).

The next step back (which I think is the correct one) is to do this makeColorSpace(SRGB) be done when are about to hand the data from the ImageBitmap over to WebGL (looking where that is ATM).
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64db61998368ffd368f477a57b749f9a5a0dc9aa

commit 64db61998368ffd368f477a57b749f9a5a0dc9aa
Author: ccameron <ccameron@chromium.org>
Date: Mon Jun 12 08:27:05 2017

color: Convert BitmapImage to sRGB ahead of time

We are always sending these images to sRGB canvases, so do the
conversion ahead of time.

This fixes a bug wherein, when a WebGLRenderingContext reads a
BitmapImage it wants the image to be in sRGB (if not-none was
requested). We will eventually need to decide how a color-canvas-using
WebGLRenderingContext should handle non-sRGB images.

BUG= 730983 

Review-Url: https://codereview.chromium.org/2924373002
Cr-Commit-Position: refs/heads/master@{#478564}

[modify] https://crrev.com/64db61998368ffd368f477a57b749f9a5a0dc9aa/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/64db61998368ffd368f477a57b749f9a5a0dc9aa/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Comment 3 by ccameron@chromium.org, Jun 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment