New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730966 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 729905

Blocking:
issue 703492



Sign in to add a comment

eCryptfs -> ext4crypto: Run migration tool by Chrome for ARC Kiosk user.

Project Member Reported by kinaba@chromium.org, Jun 8 2017

Issue description

Split out the sub task of  Bug 703492  to here, and asked help from fukino@-san.
(Thank you very much for your help!)

 Bug 729905  was mainly a Cryptohomed-side task to make it possible to switch Kiosk sign-in to be migration aware.
This is the task for Chrome-side work.

Once  Bug 729905  is done, the remaining Chrome-side task is to:
(1) Immediately start the migration when the accounted started signing-in and if "encryption is old" error is returned from Cryptohome.
(2) Show the progress UI if needed (*)
(3) When finished either successfully or unsuccessfully, (clean the home directory if the filesystem was unrecoverably broken,) and restart.

All of them are a part of the migration flow of the regular user,
so I'm hoping it can be done by mostly reusing the code already implemented.
 
mitsuji@,
I want to re-confirm about the UI.

In  crbug.com/703492#c5  it is said "No UI necessary."
Does it mean totally no UI is needed, even the progress bar screen?

Kiosk log-in already seems to show a "Initializing application..." with
loading circle animation, so just doing the migration silently behind it may work indeed,
but I'm not fully sure.
Cc: abodenha@chromium.org vidster@chromium.org
Owner: vidster@chromium.org
+vidster@, +abodenha@

Yes this was based on a conversation I had with abodenha@ a while back. 

vidster@ any input/feedback on this approach? 

Comment 3 by fukino@chromium.org, Jun 16 2017

In my WIP CL (https://codereview.chromium.org/2944553003/), I reused the migration UI to show the progress bar.
As the migration can take some time and the device will be rebooted after the migration,
I think showing the progress bar can be useful to avoid some confusions.

Comment 4 by fukino@chromium.org, Jun 20 2017

Labels: -M-60 M-61
Updating target milestone to M61, based on https://bugs.chromium.org/p/chromium/issues/detail?id=703492#c43
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a07fb43185f855ed04446008efebf80564ef3c9

commit 9a07fb43185f855ed04446008efebf80564ef3c9
Author: fukino <fukino@chromium.org>
Date: Wed Jun 28 02:34:17 2017

cros: Enable Ext4 dircrypto migration for ARC kiosk mode.

When old encryption is detected in ARC kiosk session, we should migrate
the encryption. As it is for kiosk situation, we skip all checks
(user confirmation, battery, and space) and start migration immediately.
This CL also adds UMA stats for the kiosk migration.

BUG= 730966 
TEST=manually tested by following https://docs.google.com/document/d/1JS6wtZ6VxKDN0SvphuvvydixPkiTwlxzJ17DZUsMEzM/edit#

Review-Url: https://codereview.chromium.org/2944553003
Cr-Commit-Position: refs/heads/master@{#482856}

[modify] https://crrev.com/9a07fb43185f855ed04446008efebf80564ef3c9/chrome/browser/chromeos/login/arc_kiosk_controller.cc
[modify] https://crrev.com/9a07fb43185f855ed04446008efebf80564ef3c9/chrome/browser/chromeos/login/arc_kiosk_controller.h
[modify] https://crrev.com/9a07fb43185f855ed04446008efebf80564ef3c9/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/9a07fb43185f855ed04446008efebf80564ef3c9/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h
[modify] https://crrev.com/9a07fb43185f855ed04446008efebf80564ef3c9/tools/metrics/histograms/enums.xml

Owner: fukino@chromium.org
Status: Fixed (was: Assigned)
I believe this is now done.

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment