New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730964 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Chopped focus is seen on Ubertray while tabbing

Project Member Reported by rkalavakuntla@chromium.org, Jun 8 2017

Issue description

Chrome Version:61.0.3123.0/9628.0.0 dev-channel Candy,Daisy,Minnie
OS:Chrome

What steps will reproduce the problem?
(1)Recover build ->Press tab until the focus reaches Ubertray and Observe the focus(kindly refer screenshot)

Actual:Chopped focus is seen on Ubertray while tabbing
Expected:Focus shouldn't get chopped

This is a Regression issue as same is working fine in  60.0.3112.20/9592.12.0 dev channel Minnie

@Tbuckley: please confirm the issue

Note:Issue is not seen in Windows,Linux OS




 
Actual (2).jpg
2.3 MB View Download
Expected.jpg
3.0 MB View Download

Comment 1 by ketakid@google.com, Aug 31 2017

tbuckley@ is this still an issue on the latest build and a stable blocker? Can you please update the bug accordingly?
Cc: zalcorn@chromium.org
Owner: wzang@chromium.org
This repros on latest canary: 62.0.3199.0

Note that it also affects the sign-in screen, so you don't need to powerwash to see the issue.

Might be related to the updated sign-in screen?

Comment 3 by wzang@chromium.org, Aug 31 2017

Cc: abodenha@chromium.org afakhry@chromium.org mkarkada@chromium.org wzang@chromium.org jdufault@chromium.org achuith@chromium.org dhadd...@chromium.org sdantul...@chromium.org r...@chromium.org
 Issue 750387  has been merged into this issue.

Comment 4 by wzang@chromium.org, Aug 31 2017

It happens in M61 as well. Ubertray is separate from sign-in screen and I'm not very familiar with it. If it's a RBS I might have to do a bisect.
Labels: -ReleaseBlock-Stable
I don't think this is serious enough to justify RBS. Please correct me if I'm missing something.

Comment 6 by wzang@chromium.org, Oct 7 2017

 Issue 772517  has been merged into this issue.

Comment 7 by wzang@chromium.org, Oct 18 2017

Labels: -M-61 M-63
Owner: est...@chromium.org
The bisect shows:

bad2bc6a7e2181d379955e19ac208db4b7da83a8 is the first bad commit

https://chromium-review.googlesource.com/c/chromium/src/+/516824

+estade, could you fix this?
Issue still reproducible on M63 beta 10032.39.0, 63.0.3239.50
Able to reproduce issue on latest (M-65) 65.0.3299.0/10277.0.0 dev channel Daisy,Kip,Candy,Reks.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96f9ed7dd14bce554da13e9c96c258e8afe15352

commit 96f9ed7dd14bce554da13e9c96c258e8afe15352
Author: Evan Stade <estade@chromium.org>
Date: Wed Jan 10 20:37:50 2018

Correct bounds of TrayBackgroundView focus rect.

These calculations, which are painfully complicated due to layout logic
being spread across multiple files, only work if there has already been
a layout. Before this patch, they were being called before any layout
occurred.

Bug:  730964 
Change-Id: I2debbd0d441685519c87343a257bfa980ec5f110
Reviewed-on: https://chromium-review.googlesource.com/857699
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528413}
[modify] https://crrev.com/96f9ed7dd14bce554da13e9c96c258e8afe15352/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/96f9ed7dd14bce554da13e9c96c258e8afe15352/ash/system/tray/tray_background_view.h

Comment 11 by estade@google.com, Jan 15 2018

Status: Fixed (was: Assigned)

Sign in to add a comment