New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730957 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Unwanted horizontal scrollbar is seen while adding person in chrome://md-settings/accounts

Project Member Reported by rkalavakuntla@chromium.org, Jun 8 2017

Issue description

Chrome Version: 61.0.3123.0/9628.0.0 dev-channel Candy,Daisy,Minnie
OS:chrome

What steps will reproduce the problem?
(1)Sign in to user->Launch chrome and navigate to chrome://md-settings/accounts
(2)Near Add person -> add a person and Observe(Kindly refer screenshot)

Actual:Unwanted horizontal scrollbar is seen while adding a person
Expected:No such Unwanted horizontal scrollbar should be seen

This is a Regression issue as same is working fine in 60.0.3112.20/9592.12.0 dev channel Minnie

@stevenjb: please confirm the issue

Note:Issue is not seen in Windows,Linux OS





 
Actual (2).jpg
3.8 MB View Download
Expected.jpg
2.7 MB View Download
Cc: dschuyler@chromium.org
Labels: -Pri-1 Pri-2
Labels: M-60
Also seen on M60 9592.15.0, 60.0.3112.26
@dschuyler: Could this be related to https://codereview.chromium.org/2926643004?

Comment 4 by dpa...@chromium.org, Jun 12 2017

Labels: -ReleaseBlock-Stable -M-60 Hotlist-MD-Settings-PeopleCrOS ReleaseBlock-Beta

Comment 5 by ketakid@google.com, Jun 19 2017

since this is also repro on M60 this is not a regression.
As per comment 5, I had rechecked the issue by testing this on 59.0.3071.91/9460.60.0 stable channel Daisy.Unable to Reproduce the issue.
This is a Regression issue, as it is not seen in M-59.

Kindly refer the video attached. Thanks!
730957.webm
796 KB View Download
I don't have a chrome book, but I tried to hack into the UI on a Linux where I didn't see a repro (though this is not conclusive).

In response to #3, it *could* be, but it looks to me like the bar is appearing in (on?) the button rather than the list (from the screen shots). Which would likely make it unrelated.
rkalavakuntla@ can you confirm on above.. eg. do you know if the scroll bar is over the Add user button? or is it at the bottom of the list of users?
Labels: -ReleaseBlock-Beta -Pri-2 ReleaseBlock-Stable Pri-1
@josafat: As per comment #8 After adding a person horizontal scrollbar is seen between the added person and focus of 'Add person' button (Please refer video)

Steps to Reproduce the issue:
(1)Navigate to chrome://md-settings/accounts and enable 'Restrict sign-in to the following users'
(2)Add person option is enabled  -> Now click on 'Add person' -> Enter any email id( added 'abc' person) After adding a person observe unnecessary horizontal scrollbar below that added person(please refer video)

Note:
Issue is not applicable to Windows,Linux OS.




Actual.webm
634 KB View Download
I have confirmed that:
The bug exists in 60.0.3112.41
The bug does not exist in 61.0.3136

I will test a dev build 60.0.3112.45 (which probably won't fix this), then try patching the CL suggested in comment #3.



Labels: -M-61 M-60
So the 60 branch doe shave https://codereview.chromium.org/2902363002.

I am investigating further to see if I can find a simple / safe fix.

I'm not sure however that this is really a P1 so may punt if it seems to subtle / complicated to fix for 60.

Labels: -Pri-1 M-61 Pri-2
OK, so I am pretty sure this particular issue was fixed on 61 by the paper-icon-button-light change: https://codereview.chromium.org/2848973003

I'm pretty certain that is not something that we want to merge to 60.

Instead I will put up a small patch to fix this just for user_list.html (if 'git cl upload' from my 3112 branch ever completes whatever it is doing or I figure out what I am doing wrong...)

Also, punting on this for 61 doesn't seem unreasonable, it's an obscure UI and only a minor aesthetic bug.

Labels: Merge-Request-60
Status: Started (was: Assigned)
"Merge" CL (it's really a branch specific fix, see previous comment) is:
https://codereview.chromium.org/2959543002/

This is fixed differently in 61 and we don't want to merge the much larger change to 60.

Project Member

Comment 15 by sheriffbot@chromium.org, Jun 23 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Screenshot from 60 with fix attached.

Screenshot 2017-06-23 at 16.18.51.png
61.2 KB View Download
Labels: -Merge-Review-60 Merge-Approved-60
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 24 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd0beb1515603576b1e7d12e4351cc5bc4cfd1c8

commit bd0beb1515603576b1e7d12e4351cc5bc4cfd1c8
Author: stevenjb <stevenjb@chromium.org>
Date: Sat Jun 24 01:02:08 2017

Settings: Users: Fix margins for restrict signins list

BUG= 730957 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2959543002
Cr-Commit-Position: refs/branch-heads/3112@{#461}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/bd0beb1515603576b1e7d12e4351cc5bc4cfd1c8/chrome/browser/resources/settings/people_page/user_list.html

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
ChromeOS 9592.71.0, 60.0.3112.80

Sign in to add a comment