Regression:Default focus to enter sync passphrase is seen misplaced |
||||||||||
Issue descriptionChrome Version:61.0.3123.0/9628.0.0 dev-channel Candy,Daisy,Minnie OS:Chrome Precondition:Account used for Sign in should have sync passphrase What steps will reproduce the problem? (1)Sign in to user->click to enter passphrase and Observe the default focus Actual:Default Focus is seen in search box Expected:instead,Default Focus should be seen in Passphrase text field This is a Regression issue as same is working fine in 60.0.3112.20/9592.12.0 dev Other info would be updated soon.
,
Jun 8 2017
Able to reproduce the issue on Windows 7,Ubuntu 14.04 & Mac 10.12.4 using latest Canary #61.0.3123.0 dev Manual Bisect Info: ------------------- Good build:61.0.3116.0(475722) Bad build :61.0.3117.0(476123) Using per-revision bisect providing the bisect results: You are probably looking for a change made after 476059 (known good), but no later than 476060 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/4c605f53266369c61044568d8e2dcbd77bc3a800..d84ddac6a6b61604f0057ccb8046144287f795ec Suspecting: https://chromium.googlesource.com/chromium/src/+/d84ddac6a6b61604f0057ccb8046144287f795ec Review-Url: https://codereview.chromium.org/2825203003 scottchen@:Could you please take a look into this issue and reassign if this issue is not related to your change. Thanks..!!
,
Jun 8 2017
Issue 730992 has been merged into this issue.
,
Jun 8 2017
,
Jun 9 2017
Just tested on ubuntu, version 61.0.3126.0 (Developer Build) unknown (64-bit). I wasn't able to reproduce. Clicking on "sync" goes to the sync sub-page and the focus correctly goes to the "enter passphrase" field. If you're still able to reproduce, please upload a video capture of the repro steps and assign back to me.
,
Jun 12 2017
As per the Comment 5,Tested this on Ubuntu 14.04 and Windows 7 with version 61.0.3126.0 dev. Still able to reproduce this issue with the mentioned steps Precondition:Account used for Sign in should have sync passphrase (1)Sign in to user->click to enter passphrase and Observe the default focus (Attached video with the repro steps for your reference) scottchen@:Could you please confirm the issue Thanks!
,
Jun 12 2017
,
Jun 13 2017
Thanks, I was able to reproduce following the video.
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88 commit 690256f7a5cfb0fe8e61cf19c8e026f3ac11af88 Author: scottchen <scottchen@chromium.org> Date: Wed Jun 14 20:05:17 2017 MD Settings: fix auto-focus on sync page. BUG= 730954 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2941433002 Cr-Commit-Position: refs/heads/master@{#479480} [modify] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/chrome/browser/resources/settings/people_page/compiled_resources2.gyp [modify] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/chrome/browser/resources/settings/people_page/sync_page.html [modify] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/chrome/browser/resources/settings/people_page/sync_page.js [modify] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/chrome/test/data/webui/settings/cr_settings_interactive_ui_tests.js [add] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/chrome/test/data/webui/settings/people_page_sync_page_interactive_test.js
,
Jun 14 2017
,
Jul 28 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by rkalavakuntla@chromium.org
, Jun 8 20172.7 MB
2.7 MB View Download
3.9 MB
3.9 MB View Download