New issue
Advanced search Search tips

Issue 730932 link

Starred by 1 user
Status: Duplicate
Merged: issue gerrit:217
Owner: ----
Closed: Jun 2017
Cc:
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug



Sign in to add a comment

Changes to files added in a rebase are not shown when diffing against the rebase (or later) patch set

Project Member Reported by ddorwin@chromium.org, Jun 8 2017 
* https://chromium-review.googlesource.com/c/517704/9 shows that content/renderer/media/media_factory.* have been modified.
* https://chromium-review.googlesource.com/c/517704/6..9 and https://chromium-review.googlesource.com/c/517704/6..7 show them as added, so I assume they were added as part of the rebase in PS7.

However, if I diff the latest PS against the rebase (https://chromium-review.googlesource.com/c/517704/7..9), these files are not listed.

This could lead to reviewers missing changes to files.

Comment 1 by aga...@chromium.org, Jun 8 2017

Status: WontFix (was: Unconfirmed)
I think we're both a little confused. Patch set 7, despite being named "rebaseonly", is not only a rebase. If it were, the media_factory.[cc|h] files would not have shown up in it.

You're right that those files first showed up in patchset 7, and your logic for determining that is correct.

However, I don't know why you'd choose to diff patchset 9 against patchset 7, and expect changes made in patchset 7 to show up in that. If you want to see changes made in patchset 7, diff against patchset 6, or against the Base.

Remember that diffing 6..9 is not "show me the changes against master which are in 9 but not in 6". It is "show me the changes from 6 to 9".

Comment 2 by aga...@chromium.org, Jun 8 2017

Mergedinto: gerrit:217
Status: Duplicate (was: WontFix)
Oh and also: looks like something that will solve this is actually being worked on already! https://gerrit-review.googlesource.com/c/105834/
►

Sign in to add a comment