New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 730905 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
calamity@chromium.org
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 658980
issue 735808



Sign in to add a comment

[MD Bookmarks] Focus should return to original target after dialog/menu

Project Member Reported by tsergeant@chromium.org, Jun 8 2017 
Steps to reproduce:

1. Tab through to bookmark list item
2. Hit F2 to open edit dialog
3. Hit ESC to close edit dialog

Expected behavior:

Focus should return to the list, letting me use the up/down keys still

Actual behavior:

Focus is dropped back to the body.

Comment 1 by tsergeant@chromium.org, Jun 22 2017

Blocking: 735808
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d

commit 57b2e8fda5f0cfa3aacdb926cb3a845d5921704d
Author: calamity <calamity@chromium.org>
Date: Thu Jun 29 18:46:58 2017

[MD Bookmarks] Restore focus after closing a dialog or context menu.

This CL makes dialogs in the bookmark manager restore focus to the
previously focused element after dismissal.

BUG= 730905 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2954273002
Cr-Commit-Position: refs/heads/master@{#483440}

[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/browser_resources.grd
[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[add] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/resources/md_bookmarks/dialog_focus_manager.html
[add] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/resources/md_bookmarks/dialog_focus_manager.js
[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/resources/md_bookmarks/edit_dialog.js
[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/resources/md_bookmarks/item.js
[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/resources/md_bookmarks/mouse_focus_behavior.js
[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js
[modify] https://crrev.com/57b2e8fda5f0cfa3aacdb926cb3a845d5921704d/tools/gritsettings/resource_ids

Comment 3 by calamity@chromium.org, Jun 30 2017

Status: Fixed (was: Available)
►

Sign in to add a comment