New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730904 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings: Navigation menu icons not centered

Project Member Reported by dpa...@chromium.org, Jun 8 2017

Issue description

When a navigation menu entry takes up two lines, the associated icon is not centered, see icons_top.png attachment.

Proposing to center those icons as shown in icons_centered.png.

Thoughts?
 
icons_top.png
45.9 KB View Download
icons_centered.png
47.9 KB View Download

Comment 1 by dbeam@chromium.org, Jun 8 2017

Cc: -bettes@chromium.org
Components: UI>Localization UI>Polish
Labels: Hotlist-MD-Settings-Navigation OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by kmaoy@google.com, Jul 4 2017

Components: -UI>Localization UI>Browser
Labels: Needs-TestConfirmation
Status: Unconfirmed (was: Assigned)
This  is not a localization bug. Can't confirm that it's still relevant to the current English UI.
Labels: -Needs-TestConfirmation hasbisect-per-revision
Status: Assigned (was: Unconfirmed)
Tested on Chrome Stable #59.0.3071.115 and Canary #61.0.3148.0 on Windows 10, and issue is reproducible. 
 
Using the per-revision bisect providing the bisect results,
 
Good Build:58.0.3014.0  (Revision:450840).
Bad Build:58.0.3015.0 (Revision:451180).
 
---
You are probably looking for a change made after 451006 (known good), but no later than 451007 (first known bad).
CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/953322582e01e05f831456fecea0d48af331f16f..f26ccb9043c276fb76b875f90361ef5b58acc510
 
From the CL above, assigning the issue to the owner concerned
 
@hcarmona: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned.
 
Review-URL:https://codereview.chromium.org/2651293003

Labels: -hasbisect-per-revision
Alan, I think this just needs your call on whether you prefer to have the icons at the top (with the first line of text) or centered on the wrapped text (where it may appear next to the middle line of text). 

Either way is easy - just say what you'd like.

Comment 6 by bettes@chromium.org, Jul 10 2017

Discussed offline, Lets go with icons_centered.png 

Comment 7 by dpa...@chromium.org, Jul 11 2017

Owner: dpa...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e37ce5a951d217c5997d0346f0473028bcbd4131

commit e37ce5a951d217c5997d0346f0473028bcbd4131
Author: dpapad <dpapad@chromium.org>
Date: Wed Jul 12 04:16:34 2017

MD Settings: Center icons in navigation menu.

Bug:  730904 
Change-Id: Id37a8a9c5d9e7ec5d5112ad2567a6c376c6e591e
Reviewed-on: https://chromium-review.googlesource.com/567332
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485848}
[modify] https://crrev.com/e37ce5a951d217c5997d0346f0473028bcbd4131/chrome/browser/resources/settings/settings_menu/settings_menu.html

Comment 9 by dpa...@chromium.org, Jul 12 2017

Status: Fixed (was: Started)
Labels: TE-Verified-M61 TE-Verified-61.0.3159.5
Tested this issue on Windows 7, Mac 10.12.5 & Ubuntu 14.04 using latest dev #61.0.3159.5 as per comment#0.

Observed that all the icons are placed centered on chrome://settings page after changing the language to Greek.As it is working as intended, adding TE verified labels.
Please find the attached screen cast for reference.
Thanks..!!
730904.mp4
561 KB View Download
Cc: dhadd...@chromium.org
Status: Verified (was: Fixed)
I have verified these changes on M62.

Sign in to add a comment