New issue
Advanced search Search tips

Issue 730888 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Can't add a card in PR UI

Project Member Reported by rouslan@chromium.org, Jun 8 2017

Issue description

Can't add a card in PR UI in canary on Android.
 
There's no "Add card" button.
Screenshot_20170607-202115.png
158 KB View Download
Cc: gogerald@chromium.org
Ganggui: any idea why "+ ADD CARD" would not be showing?
I guess you are supposed to fix the shipping address first,
I mean delivery address
Same happens if I fix the delivery address first. There's no "+ADD CARD".

Device: Pixel XL
Chrome version: 61.0.3142.3
OS: Android 7.0.99 Build/OPP2170420.019
URL: https://rsolomakhin.github.io/pr/delivery/
Screenshot (Jun 8, 2017 4-49-29 PM).png
258 KB View Download
You're absolutely correct. Great find!
Labels: M-60 Merge-Request-60
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 9 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 9 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/148b5260239ae50ad406af3e9f9aade045f2353d

commit 148b5260239ae50ad406af3e9f9aade045f2353d
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Jun 09 19:02:47 2017

[Merge M-60] Create and add AutofillPaymentApp deterministicaly before show is called.

BUG= 730888 
TBR=gogerald@chromium.org

(cherry picked from commit 5c01f655028db7670a72fdfefcb99282f08f56a3)

Review-Url: https://codereview.chromium.org/2925403002
Cr-Original-Commit-Position: refs/heads/master@{#478309}
Change-Id: I6fdde5f9ab159ef2ec43aaa6145f5bc07e6a190b
Reviewed-on: https://chromium-review.googlesource.com/529407
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#292}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/148b5260239ae50ad406af3e9f9aade045f2353d/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/148b5260239ae50ad406af3e9f9aade045f2353d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Status: Fixed (was: Assigned)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment