Can't add a card in PR UI |
|||||||
Issue descriptionCan't add a card in PR UI in canary on Android.
,
Jun 8 2017
Ganggui: any idea why "+ ADD CARD" would not be showing?
,
Jun 8 2017
I guess you are supposed to fix the shipping address first,
,
Jun 8 2017
I mean delivery address
,
Jun 8 2017
Same happens if I fix the delivery address first. There's no "+ADD CARD". Device: Pixel XL Chrome version: 61.0.3142.3 OS: Android 7.0.99 Build/OPP2170420.019 URL: https://rsolomakhin.github.io/pr/delivery/
,
Jun 8 2017
There looks have a bug here https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java?rcl=81f0c3d4bf1bea81d6a2209ffe46c456a742619c&l=514, mMerchantSupportsAutofillPaymentInstruments is no necessary has been set correctly here (https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java?rcl=81f0c3d4bf1bea81d6a2209ffe46c456a742619c&l=703) when calling show.
,
Jun 8 2017
You're absolutely correct. Great find!
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c01f655028db7670a72fdfefcb99282f08f56a3 commit 5c01f655028db7670a72fdfefcb99282f08f56a3 Author: gogerald <gogerald@chromium.org> Date: Fri Jun 09 16:50:12 2017 Create and add AutofillPaymentApp deterministicaly before show is called. BUG= 730888 Review-Url: https://codereview.chromium.org/2925403002 Cr-Commit-Position: refs/heads/master@{#478309} [modify] https://crrev.com/5c01f655028db7670a72fdfefcb99282f08f56a3/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java [modify] https://crrev.com/5c01f655028db7670a72fdfefcb99282f08f56a3/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
,
Jun 9 2017
,
Jun 9 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/148b5260239ae50ad406af3e9f9aade045f2353d commit 148b5260239ae50ad406af3e9f9aade045f2353d Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Fri Jun 09 19:02:47 2017 [Merge M-60] Create and add AutofillPaymentApp deterministicaly before show is called. BUG= 730888 TBR=gogerald@chromium.org (cherry picked from commit 5c01f655028db7670a72fdfefcb99282f08f56a3) Review-Url: https://codereview.chromium.org/2925403002 Cr-Original-Commit-Position: refs/heads/master@{#478309} Change-Id: I6fdde5f9ab159ef2ec43aaa6145f5bc07e6a190b Reviewed-on: https://chromium-review.googlesource.com/529407 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#292} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/148b5260239ae50ad406af3e9f9aade045f2353d/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java [modify] https://crrev.com/148b5260239ae50ad406af3e9f9aade045f2353d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
,
Jun 9 2017
,
Jun 27 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rouslan@chromium.org
, Jun 8 2017158 KB
158 KB View Download