New issue
Advanced search Search tips

Issue 730884 link

Starred by 1 user
Status: Fixed
Owner:
msw@chromium.org
Closed: Sep 2017
Cc:
jamescook@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 557406
issue 681072



Sign in to add a comment

mash: Refine WindowState::ignored_by_shelf_ meaning and usage

Project Member Reported by msw@chromium.org, Jun 8 2017 
mash: Refine WindowState::ignored_by_shelf_ meaning and usage

The WindowState::ignored_by_shelf_ flag seems to have mixed meanings:
 - don’t trigger shelf appearance changes on window overlap
 - don’t create ShelfWindowWatcher item, etc.
The second meaning is really my fault, I added that behavior.

We should disambiguate the meanings and maybe refine some related behavior:
 - make an aura::Window property to not create ShelfWindowWatcher items?
   (that would support property mirroring and transport for clients)
 - make a property for not triggering overlap appearance changes? (not sure if needed)

It might be possible to work around one or both of these flag in other ways:
 - put windows in other containers to avoid shelf items or overlap?
 - filter by window types/parenting, etc. to avoid shelf items or overlap?

Just some ideas...
This is related to (blocking)  Issue 557406 , and (not blocking?)  Issue 681072 .
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30f34f828ec3b91e86617e2af9732f0958a37a46

commit 30f34f828ec3b91e86617e2af9732f0958a37a46
Author: Mike Wasserman <msw@chromium.org>
Date: Tue Sep 05 23:32:43 2017

mash: Avoid ChromeLauncherController and ShelfWindowWatcher race.

Initialize the shelf item type for chrome app [panel] windows early.
The window type should be marked before adding it to a container.
(that prevents ash::ShelfWindowWatcher from ever creating a shelf item)
(otherwise, Ash and Chrome race to create a shelf items for windows)

TODO: Apply this window property similarly early in classic ash.
(we don't currently use ShelfWindowWatcher for unknown windows there)

Bug:  730884 ,  750334 
Change-Id: I67fbf0fa48ddfdb4c89500e1f4dd3606ac69d675
Reviewed-on: https://chromium-review.googlesource.com/644849
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499796}
[modify] https://crrev.com/30f34f828ec3b91e86617e2af9732f0958a37a46/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/30f34f828ec3b91e86617e2af9732f0958a37a46/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/30f34f828ec3b91e86617e2af9732f0958a37a46/chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc
[modify] https://crrev.com/30f34f828ec3b91e86617e2af9732f0958a37a46/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

Comment 2 by msw@chromium.org, Sep 11 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment