New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 730877 link

Starred by 1 user
Status: Fixed
Owner:
█ svaldez@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

URLDownloader::BeginDownload sets invalid referrer

Project Member Reported by jochen@chromium.org, Jun 8 2017 
it should invoke content::Referrer::SanitizeForRequest(url, referrer) to ensure we don't attempt to send an https referrer to an http url

Comment 1 by jochen@chromium.org, Jun 8 2017

Components: UI>Browser>Downloads
Labels: OS-All
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da5f4e24e21981cc72d2cf2baf3af78eefc79279

commit da5f4e24e21981cc72d2cf2baf3af78eefc79279
Author: svaldez <svaldez@chromium.org>
Date: Fri Jun 09 12:48:49 2017

Ensure that the referrer for HTTPS to HTTP downloads is dropped.

BUG= 730877 

Review-Url: https://codereview.chromium.org/2927123002
Cr-Commit-Position: refs/heads/master@{#478255}

[modify] https://crrev.com/da5f4e24e21981cc72d2cf2baf3af78eefc79279/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/da5f4e24e21981cc72d2cf2baf3af78eefc79279/content/browser/download/url_downloader.cc

Comment 3 by cbentzel@chromium.org, Sep 21 2017 

Is this fixed?

Comment 4 by svaldez@chromium.org, Sep 21 2017

Status: Fixed (was: Assigned)
Oops, yeah this should be fixed.
►

Sign in to add a comment