New issue
Advanced search Search tips

Issue 730876 link

Starred by 1 user
Status: Archived
Owner:
msw@chromium.org
Closed: Jul 2017
Cc:
jamescook@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 557406
issue 681072



Sign in to add a comment

mash: Determine why OnAppWindowAdded is only called in Mash

Project Member Reported by msw@chromium.org, Jun 8 2017 
mash: Determine why OnAppWindowAdded is only called in Mash

It would be good for this to be called regardless of Ash config.
AFAICT, ExtensionAppWindowLauncherController::OnAppWindowAdded is only called in Mash.
See TODOs at: https://codereview.chromium.org/2927693002/diff/60001/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
This is related to (blocking)  Issue 557406 , and (not blocking?)  Issue 681072 .
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89e3d6130cbaa99cab4ab8f55c3e30e4683ee9c7

commit 89e3d6130cbaa99cab4ab8f55c3e30e4683ee9c7
Author: Michael Wasserman <msw@chromium.org>
Date: Thu Jul 13 23:48:15 2017

Refine extension app window registration code.

Call RegisterApp from OnAppWindowAdded (for single- and multi-profile).
Remove workarounds and comments for configuration differences.
Fix a test that was expecting broken/contradictory behavior...

Bug:  730876 ,  557406 
Test: No behavior changes with extension window shelf icons.
Change-Id: Ifbfd64a6f107f0f651c8cc2c4d6bfa362f50c04c
Reviewed-on: https://chromium-review.googlesource.com/569260
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486545}
[modify] https://crrev.com/89e3d6130cbaa99cab4ab8f55c3e30e4683ee9c7/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/89e3d6130cbaa99cab4ab8f55c3e30e4683ee9c7/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/89e3d6130cbaa99cab4ab8f55c3e30e4683ee9c7/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.h
[modify] https://crrev.com/89e3d6130cbaa99cab4ab8f55c3e30e4683ee9c7/chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc

Comment 2 by msw@chromium.org, Jul 14 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment