New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 730874 link

Starred by 2 users
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Jun 2017
Cc:
█ pchalla@google.com
█ pchalla@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Print preview assertion fail when privet printer is deleted

Project Member Reported by rbpotter@chromium.org, Jun 8 2017 
Chrome Version: 58.0.3029.110, also canary 61.0.3122.0
OS: Win10, but probably not OS-specific

What steps will reproduce the problem?
(1) Register a local network printer in chrome://devices, which will add it
as a privet printer
(2) Print preview and select the privet printer from local destinations list
(3) Cancel preview
(4) Remove printer via cloudprint printer management page
(5) Print preview

What is the expected result?
Print preview selects some other destination relatively promptly, without errors.

What happens instead?
Print preview hangs for 10+ seconds before finding a different destination and outputs a JS error that an assertion failed since the capabilities value is null.

Appears to be due to the CACHED_DESTINATION event fired here: 
https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/data/destination_store.js?l=742

Probably need a check on capabilities like exists for the extension case:
https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/data/destination_store.js?l=759

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/607f9a11ab0971f435775b2b2276e44a0a544d8d

commit 607f9a11ab0971f435775b2b2276e44a0a544d8d
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jun 09 01:09:38 2017

Print Preview: Check capabilities before sending info ready

Check that capabilities is non-null before dispatching an INFO_READY
event that will trigger the print ticket store.

BUG= 730874 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2927703004
Cr-Commit-Position: refs/heads/master@{#478147}

[modify] https://crrev.com/607f9a11ab0971f435775b2b2276e44a0a544d8d/chrome/browser/resources/print_preview/data/destination_store.js

Comment 2 by jmukthavaram@chromium.org, Jun 13 2017

Labels: TE-NeedsTriageFromMTV
Unable to test this issue from chrome-hyd team as 'Delete' button is in disable to mode in cloud printer management page,hence we are not able to Remove printer as per the step 4.

Could some one from MTV team please look into this issue.Adding 'TE-NeedsTriageFromMTV' label to this issue.
Thanks in advance.

Comment 3 by manoranj...@chromium.org, Jun 13 2017

Cc: pchalla@chromium.org
Labels: -TE-NeedsTriageFromMTV
Seems like we need to have Admin privileges to delete the printer from chrome://devices.

Could someone from 'Cloud Print' team, please verify this?

Thank you!

Comment 4 by manoranj...@chromium.org, Jun 13 2017

Cc: pchalla@google.com

Comment 5 by pchalla@google.com, Jun 15 2017 

Tested this issue on chrome canary and 61.0.3131.0 canary and 61.0.3128.0 dev versions using Printer model: Brother MFC-J895Dw, unable to replicate this issue.

Comment 6 by manoranj...@chromium.org, Jun 15 2017

Labels: TE-Verified-M61
pchalla@, thank you so much for verifying this issue.

Comment 7 by rbpotter@chromium.org, Jun 21 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment