New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730868 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Ensure correct rendering of non-ascii URLs

Project Member Reported by vollick@chromium.org, Jun 7 2017

Issue description

We should not render the "missing glyph" boxes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be8255189966eb57a2c70ca3d57568af4b144e14

commit be8255189966eb57a2c70ca3d57568af4b144e14
Author: vollick <vollick@chromium.org>
Date: Thu Jun 08 01:58:18 2017

[vr] Fix incorrect negation in font fallback logic.

We were previously only adding empty fallback fonts.

BUG= 730868 

Review-Url: https://codereview.chromium.org/2924043003
Cr-Commit-Position: refs/heads/master@{#477857}

[modify] https://crrev.com/be8255189966eb57a2c70ca3d57568af4b144e14/chrome/browser/android/vr_shell/textures/ui_texture.cc
[modify] https://crrev.com/be8255189966eb57a2c70ca3d57568af4b144e14/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc

Labels: Merge-Request-60
Labels: -Merge-Request-60
Labels: Merge-Request-60
Labels: Proj-VR-Shell
Labels: VR-BBB
Labels: OS-Android
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 8 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 8 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d1df2d234cb96539f617695e1d10f01916c9b41

commit 1d1df2d234cb96539f617695e1d10f01916c9b41
Author: Ian Vollick <vollick@chromium.org>
Date: Thu Jun 08 18:44:45 2017

[vr] Fix incorrect negation in font fallback logic.

We were previously only adding empty fallback fonts.

BUG= 730868 

Review-Url: https://codereview.chromium.org/2924043003
Cr-Original-Commit-Position: refs/heads/master@{#477857}
Review-Url: https://codereview.chromium.org/2926303003 .
Cr-Commit-Position: refs/branch-heads/3112@{#261}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/1d1df2d234cb96539f617695e1d10f01916c9b41/chrome/browser/android/vr_shell/textures/ui_texture.cc
[modify] https://crrev.com/1d1df2d234cb96539f617695e1d10f01916c9b41/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc

Labels: -OS-Android
Status: Fixed (was: Started)

Sign in to add a comment