New issue
Advanced search Search tips

Issue 730853 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Uninstall extension dialog might have different icon than one used in app launchers.

Project Member Reported by khmel@chromium.org, Jun 7 2017

Issue description

Repo:

1. Unable ARC
2. Install Google docs as Chrome and Android apps
3. Make sure that Chrome version in app launcher is badged.
4. Try to uninstall Chrome version. Icon in uninstall dialog is unbadged
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df82202a267058499e2420cd8ef7c74899092c1

commit 0df82202a267058499e2420cd8ef7c74899092c1
Author: khmel <khmel@google.com>
Date: Fri Jun 23 03:15:42 2017

Fix uninstall extension dialog has different icon.

This CL sync icon used for extension dialog with default one used to
represent extension based app.
This additionally fixes following issues:
  - base class for uninstall dialog and implementation has own
  expectations for icon size. Now use only one source to define icon
  size.
  - Provide correct loading of icons for non-standard device scale
  factors.

For mechanical change in extension_uninstall_dialog_cocoa.mm
TBR=ellyjones@chromium.org

      desktop.

Bug:  730853 
Test: Manually on Cave (1.25 scale factor), Linux Chrome OS + Linux
Change-Id: Ib3d1c80d6883a079728b917efc726e9458b6bacb
Reviewed-on: https://chromium-review.googlesource.com/527527
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481802}
[modify] https://crrev.com/0df82202a267058499e2420cd8ef7c74899092c1/chrome/browser/extensions/chrome_app_icon.cc
[modify] https://crrev.com/0df82202a267058499e2420cd8ef7c74899092c1/chrome/browser/extensions/chrome_app_icon_service.cc
[modify] https://crrev.com/0df82202a267058499e2420cd8ef7c74899092c1/chrome/browser/extensions/chrome_app_icon_service.h
[modify] https://crrev.com/0df82202a267058499e2420cd8ef7c74899092c1/chrome/browser/extensions/extension_uninstall_dialog.cc
[modify] https://crrev.com/0df82202a267058499e2420cd8ef7c74899092c1/chrome/browser/extensions/extension_uninstall_dialog.h
[modify] https://crrev.com/0df82202a267058499e2420cd8ef7c74899092c1/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
[modify] https://crrev.com/0df82202a267058499e2420cd8ef7c74899092c1/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
[modify] https://crrev.com/0df82202a267058499e2420cd8ef7c74899092c1/extensions/browser/extension_icon_image.cc
[modify] https://crrev.com/0df82202a267058499e2420cd8ef7c74899092c1/extensions/browser/extension_icon_image.h
[modify] https://crrev.com/0df82202a267058499e2420cd8ef7c74899092c1/extensions/browser/extension_icon_image_unittest.cc

Comment 2 by khmel@chromium.org, Jun 28 2017

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment