URLRequest::GetRemoteEndpoint does not return last attempted endpoint address for failed requests |
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.96 Safari/537.36 Steps to reproduce the problem: 1. Make a request through the browser to a valid domain (e.g., google.com) for which the request fails (because the domain responds but does not respond to HTTP requests, for example). 2. When the request completes and ResourceDispatcherHostImpl::DidFinishLoading is called, examine the value of the IPEndPoint returned by loader->request()->GetRemoteEndpoint(). What is the expected behavior? The IP endpoint returned should contain the host and port for the resource request that was attempted but failed if a request was actually made. What went wrong? An empty IP endpoint is returned. This happens even if the domain in the URL resolves to a valid IP address and Chrome sends a request to the host, but the host does not respond. Did this work before? No Chrome version: 58.0.3029.96 Channel: n/a OS Version: Flash Version: GetSocketAddress, which should only return a host/port pair when the request was successful and a socket was established, functions as expected.
,
Jun 8 2017
,
Jun 8 2017
,
Jun 9 2017
Julia: It looks like GetRemoteEndpoint is only set when an HttpStream is created. Is this deliberate? I had thought that it was also set on at least some connection errors.
,
Jul 6 2017
Is there any plan to investigate this for the Chrome 60 branch? I have some metrics code that relies on GetRemoteEndpoint to provide host/port information for failed requests that will be part of that branch.
,
Jul 6 2017
I don't think anyone currently has any plans to work on this (And even if someone picked it up today, this seems way to low priority to warrant a merge).
,
Jul 7 2017
I started throwing together a CL yesterday, but it won't make it in time for M60.
,
Jul 7 2017
Okay, thank you! We will make note of the fact that any data we get before the change is merged (M61?) will not include failed requests.
,
Jul 12 2017
,
Jul 13 2017
,
May 23 2018
,
May 23 2018
[+dcreager] I believe this was needed for reporting.
,
May 23 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by uthakore@chromium.org
, Jun 7 2017