New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730847 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

URLRequest::GetRemoteEndpoint does not return last attempted endpoint address for failed requests

Project Member Reported by uthakore@google.com, Jun 7 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.96 Safari/537.36

Steps to reproduce the problem:
1. Make a request through the browser to a valid domain (e.g., google.com) for which the request fails (because the domain responds but does not respond to HTTP requests, for example).
2. When the request completes and ResourceDispatcherHostImpl::DidFinishLoading is called, examine the value of the IPEndPoint returned by loader->request()->GetRemoteEndpoint().

What is the expected behavior?
The IP endpoint returned should contain the host and port for the resource request that was attempted but failed if a request was actually made.

What went wrong?
An empty IP endpoint is returned. This happens even if the domain in the URL resolves to a valid IP address and Chrome sends a request to the host, but the host does not respond.

Did this work before? No 

Chrome version: 58.0.3029.96  Channel: n/a
OS Version: 
Flash Version: 

GetSocketAddress, which should only return a host/port pair when the request was successful and a socket was established, functions as expected.
 
Cc: juliatut...@chromium.org uthakore@chromium.org mmenke@chromium.org
Labels: Needs-Triage-M58
Cc: -uthakore@chromium.org
Julia:  It looks like GetRemoteEndpoint is only set when an HttpStream is created.  Is this deliberate?  I had thought that it was also set on at least some connection errors.
Is there any plan to investigate this for the Chrome 60 branch? I have some metrics code that relies on GetRemoteEndpoint to provide host/port information for failed requests that will be part of that branch.
I don't think anyone currently has any plans to work on this (And even if someone picked it up today, this seems way to low priority to warrant a merge).
Owner: juliatut...@chromium.org
Status: Started (was: Unconfirmed)
I started throwing together a CL yesterday, but it won't make it in time for M60.
Okay, thank you! We will make note of the fact that any data we get before the change is merged (M61?) will not include failed requests.
Components: Internals>Network
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 13 2017

Labels: Hotlist-Google
Owner: ----
Status: Available (was: Started)
Cc: -juliatut...@chromium.org dcreager@chromium.org
[+dcreager] I believe this was needed for reporting.
Labels: Network-Triaged

Sign in to add a comment