Issue metadata
Sign in to add a comment
|
Cursor regressions in ARC |
||||||||||||||||||||
Issue description1) Blurry cursor on low-DPI displays, due to bilinear filtering when scaling up the cursor surface. 2) Stale cursor on pointer enter. Pointer::SetCursor does not update the scale/rotation if neither the surface nor the hotspot changed. This went unnoticed because the client incorrectly forced a surface change on pointer enter.
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f86ddbbc48abb0d8c2ad6ee10a1728ff7e87e00c commit f86ddbbc48abb0d8c2ad6ee10a1728ff7e87e00c Author: domlaskowski <domlaskowski@chromium.org> Date: Tue Jun 13 18:35:58 2017 exo: Reparent pointer surface When the display configuration changes, the pointer surface must be reparented to the new primary display. A client-side bug previously forced a surface change on pointer enter, causing the surface to be reparented to the latest primary display. BUG= 730843 TEST=Verify correct parenting by printing window hierarchy. Review-Url: https://codereview.chromium.org/2934953002 Cr-Commit-Position: refs/heads/master@{#479073} [modify] https://crrev.com/f86ddbbc48abb0d8c2ad6ee10a1728ff7e87e00c/components/exo/pointer.cc [modify] https://crrev.com/f86ddbbc48abb0d8c2ad6ee10a1728ff7e87e00c/components/exo/pointer.h
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18ec3b79f56fe38260ada3658872ffacdb652f22 commit 18ec3b79f56fe38260ada3658872ffacdb652f22 Author: domlaskowski <domlaskowski@chromium.org> Date: Fri Jun 23 00:20:37 2017 exo: Select cursor capture scale at run time On low-DPI displays, the pointer surface was being scaled up using bilinear filtering, resulting in a slightly blurry cursor. This CL sets the capture scale to the largest DSF instead of a constant. BUG= 730843 TEST=minnie,caroline: Cursor is sharp on all displays. Review-Url: https://codereview.chromium.org/2933133002 Cr-Commit-Position: refs/heads/master@{#481738} [modify] https://crrev.com/18ec3b79f56fe38260ada3658872ffacdb652f22/components/exo/pointer.cc [modify] https://crrev.com/18ec3b79f56fe38260ada3658872ffacdb652f22/components/exo/pointer.h
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2f536007076bd932daa97b0864710eee29ebc1c commit c2f536007076bd932daa97b0864710eee29ebc1c Author: domlaskowski <domlaskowski@chromium.org> Date: Tue Jun 27 16:38:59 2017 exo: Fix cursor scaling for 1.25 DSF The cursor was scaled on displays whose DSF did not match the capture scale. However, no scaling is required between displays with 1.25 and 1.0 DSF, i.e. the 1.25 DSF cursor has the same pixel size but appears smaller. BUG= 730843 TEST=cave: Cursor is not scaled down on external 1.0 DSF display. Review-Url: https://codereview.chromium.org/2944063002 Cr-Commit-Position: refs/heads/master@{#482647} [modify] https://crrev.com/c2f536007076bd932daa97b0864710eee29ebc1c/components/exo/pointer.cc [modify] https://crrev.com/c2f536007076bd932daa97b0864710eee29ebc1c/components/exo/pointer.h [modify] https://crrev.com/c2f536007076bd932daa97b0864710eee29ebc1c/ui/display/manager/managed_display_info.cc [modify] https://crrev.com/c2f536007076bd932daa97b0864710eee29ebc1c/ui/display/manager/managed_display_info.h
,
Jun 27 2017
,
Jun 28 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 30 2017
,
Jul 3 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c2c1396f190aa4187e465eec839d74a5303bc96 commit 3c2c1396f190aa4187e465eec839d74a5303bc96 Author: domlaskowski <domlaskowski@chromium.org> Date: Wed Jul 05 20:07:03 2017 [M60] exo: Update cursor on wl_pointer::set_cursor The cursor scale and rotation must be updated on pointer enter, even though neither the surface nor the hotspot changed. TBR=reveman@chromium.org NOTRY=true NOPRESUBMIT=true BUG= 730843 TEST=caroline: Cursor is not stale on pointer enter. Review-Url: https://codereview.chromium.org/2935753002 Cr-Original-Commit-Position: refs/heads/master@{#478660} Review-Url: https://codereview.chromium.org/2968033002 Cr-Commit-Position: refs/branch-heads/3112@{#519} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/3c2c1396f190aa4187e465eec839d74a5303bc96/components/exo/pointer.cc
,
Jul 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4e93b49df0ede286e607c01d0308da4565ceb59 commit a4e93b49df0ede286e607c01d0308da4565ceb59 Author: domlaskowski <domlaskowski@chromium.org> Date: Wed Jul 05 20:14:24 2017 [M60] exo: Reparent pointer surface When the display configuration changes, the pointer surface must be reparented to the new primary display. A client-side bug previously forced a surface change on pointer enter, causing the surface to be reparented to the latest primary display. TBR=reveman@chromium.org NOTRY=true NOPRESUBMIT=true BUG= 730843 TEST=Verify correct parenting by printing window hierarchy. Review-Url: https://codereview.chromium.org/2934953002 Cr-Original-Commit-Position: refs/heads/master@{#479073} Review-Url: https://codereview.chromium.org/2968043002 Cr-Commit-Position: refs/branch-heads/3112@{#520} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/a4e93b49df0ede286e607c01d0308da4565ceb59/components/exo/pointer.cc [modify] https://crrev.com/a4e93b49df0ede286e607c01d0308da4565ceb59/components/exo/pointer.h
,
Jul 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c06e6b719fd79b91b6cb9dc9b2fbdf674f747146 commit c06e6b719fd79b91b6cb9dc9b2fbdf674f747146 Author: domlaskowski <domlaskowski@chromium.org> Date: Wed Jul 05 20:22:53 2017 [M60] exo: Select cursor capture scale at run time On low-DPI displays, the pointer surface was being scaled up using bilinear filtering, resulting in a slightly blurry cursor. This CL sets the capture scale to the largest DSF instead of a constant. TBR=reveman@chromium.org NOTRY=true NOPRESUBMIT=true BUG= 730843 TEST=minnie,caroline: Cursor is sharp on all displays. Review-Url: https://codereview.chromium.org/2933133002 Cr-Original-Commit-Position: refs/heads/master@{#481738} Review-Url: https://codereview.chromium.org/2969213003 Cr-Commit-Position: refs/branch-heads/3112@{#521} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/c06e6b719fd79b91b6cb9dc9b2fbdf674f747146/components/exo/pointer.cc [modify] https://crrev.com/c06e6b719fd79b91b6cb9dc9b2fbdf674f747146/components/exo/pointer.h
,
Jul 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a3265f698b93b716ef16a4333303ecea4663006 commit 0a3265f698b93b716ef16a4333303ecea4663006 Author: domlaskowski <domlaskowski@chromium.org> Date: Wed Jul 05 20:27:49 2017 [M60] exo: Fix cursor scaling for 1.25 DSF The cursor was scaled on displays whose DSF did not match the capture scale. However, no scaling is required between displays with 1.25 and 1.0 DSF, i.e. the 1.25 DSF cursor has the same pixel size but appears smaller. TBR=reveman@chromium.org,oshima@chromium.org NOTRY=true NOPRESUBMIT=true BUG= 730843 TEST=cave: Cursor is not scaled down on external 1.0 DSF display. Review-Url: https://codereview.chromium.org/2944063002 Cr-Original-Commit-Position: refs/heads/master@{#482647} Review-Url: https://codereview.chromium.org/2965113002 Cr-Commit-Position: refs/branch-heads/3112@{#522} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/0a3265f698b93b716ef16a4333303ecea4663006/components/exo/pointer.cc [modify] https://crrev.com/0a3265f698b93b716ef16a4333303ecea4663006/components/exo/pointer.h [modify] https://crrev.com/0a3265f698b93b716ef16a4333303ecea4663006/ui/display/manager/managed_display_info.cc [modify] https://crrev.com/0a3265f698b93b716ef16a4333303ecea4663006/ui/display/manager/managed_display_info.h
,
Jul 5 2017
,
Jan 22 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 12 2017