New issue
Advanced search Search tips

Issue 730838 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Controls should be auto-hidden in response to onplaying vs onplay

Project Member Reported by avayvod@chromium.org, Jun 7 2017 
Seems like this change: https://codereview.chromium.org/2499883002 changed when the controls hide timer is triggered (caught incidentally by media/controls/controls-cast-overlay-slow-fade.html).

The test relies on the hide timer to start after onplaying, but it now starts in onplay so the test fails sometimes (for some reason, consistently when using run-webkit-tests but not content_shell).

I'm open to changing the test to use onplay, but semantically controls should auto-hide when playback has actually started not when the player has stalled or failed to play.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8a72f003a04193cdacbeac76d9c5cb86e15072e

commit e8a72f003a04193cdacbeac76d9c5cb86e15072e
Author: Anton Vayvod <avayvod@google.com>
Date: Fri Jun 09 04:03:36 2017

Fixed controls-cast-overlay-fade-slow.html

Fixes the code checking whether we should show the overlay cast button
as well as the time when the controls are auto-hiding after playback
started.

Bug:  730723 , 730838 
Change-Id: I988c07a880d05c67090ccda8665b0b54acbfa2b1
Reviewed-on: https://chromium-review.googlesource.com/527574
Commit-Queue: Anton Vayvod <avayvod@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478195}
[modify] https://crrev.com/e8a72f003a04193cdacbeac76d9c5cb86e15072e/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/e8a72f003a04193cdacbeac76d9c5cb86e15072e/third_party/WebKit/LayoutTests/media/controls/controls-cast-overlay-slow-fade.html
[add] https://crrev.com/e8a72f003a04193cdacbeac76d9c5cb86e15072e/third_party/WebKit/LayoutTests/media/controls/controls-overlay-cast-button-autoplay-muted.html
[modify] https://crrev.com/e8a72f003a04193cdacbeac76d9c5cb86e15072e/third_party/WebKit/LayoutTests/media/controls/controls-overlay-cast-button.html
[modify] https://crrev.com/e8a72f003a04193cdacbeac76d9c5cb86e15072e/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/e8a72f003a04193cdacbeac76d9c5cb86e15072e/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp
[modify] https://crrev.com/e8a72f003a04193cdacbeac76d9c5cb86e15072e/third_party/WebKit/Source/core/html/media/AutoplayPolicy.h
[modify] https://crrev.com/e8a72f003a04193cdacbeac76d9c5cb86e15072e/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

Comment 2 by avayvod@chromium.org, Jun 9 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment