New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730832 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Sign in to add a comment

Metabug: Create UI for luci-config

Project Member Reported by hinoka@chromium.org, Jun 7 2017

Issue description

Currently luci-config uses API Explorer as a UI.  It would be nice to have a proper UI for luci-config.
 

Comment 1 by no...@chromium.org, Jun 7 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/bb34bc085032b88295f0215050c8735ea554b40b

commit bb34bc085032b88295f0215050c8735ea554b40b
Author: nodir <nodir@chromium.org>
Date: Thu Jun 08 18:11:32 2017

config_service: optimize projects.get_metadata

projects.get_metadata is used for all ACL checks for project config sets,
thus it must be fast. Also it never changes.

Cache it for 10m

R=hinoka@chromium.org, sergeyberezin@chromium.org
BUG= 730832 

Review-Url: https://codereview.chromium.org/2932733002

[modify] https://crrev.com/bb34bc085032b88295f0215050c8735ea554b40b/appengine/config_service/projects.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/2279363402929b7d5e45d5bb6591addab7824f2c

commit 2279363402929b7d5e45d5bb6591addab7824f2c
Author: cwpayton <cwpayton@google.com>
Date: Tue Jun 13 17:47:57 2017

config_service: improve landing page

config sets are now downloaded and searchable, but not clickable

BUG= 730832 

Review-Url: https://codereview.chromium.org/2935763003

[modify] https://crrev.com/2279363402929b7d5e45d5bb6591addab7824f2c/appengine/config_service/app.yaml
[modify] https://crrev.com/2279363402929b7d5e45d5bb6591addab7824f2c/appengine/config_service/ui/.gitignore
[modify] https://crrev.com/2279363402929b7d5e45d5bb6591addab7824f2c/appengine/config_service/ui/bower.json
[modify] https://crrev.com/2279363402929b7d5e45d5bb6591addab7824f2c/appengine/config_service/ui/index.html
[add] https://crrev.com/2279363402929b7d5e45d5bb6591addab7824f2c/appengine/config_service/ui/src/config-ui/config-card.html
[delete] https://crrev.com/d96c2be24ea3c769cce1cbe671af6786bb7ec1de/appengine/config_service/ui/src/config-ui/config-ui.html
[add] https://crrev.com/2279363402929b7d5e45d5bb6591addab7824f2c/appengine/config_service/ui/src/config-ui/front-page.html
[add] https://crrev.com/2279363402929b7d5e45d5bb6591addab7824f2c/appengine/config_service/ui/static/images/chromium.png
[rename] https://crrev.com/2279363402929b7d5e45d5bb6591addab7824f2c/appengine/config_service/ui/test/config-ui/front-page_test.html

Comment 8 by estaab@chromium.org, Jun 20 2017

Status: Available (was: Untriaged)
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/51155047e84961268eeffdfa2ec8a595ed4c21b4

commit 51155047e84961268eeffdfa2ec8a595ed4c21b4
Author: cwpayton <cwpayton@google.com>
Date: Wed Jun 21 15:42:33 2017

config_service: integrated working config set page with routing

The config-set-card elements on the front page now redirect to config-set pages that list the files of the config set. Currently the config-file-cards all link to gitiles.

BUG= 730832 

Review-Url: https://codereview.chromium.org/2953463002

[add] https://crrev.com/51155047e84961268eeffdfa2ec8a595ed4c21b4/appengine/config_service/ui/src/config-ui/config-file-card.html
[add] https://crrev.com/51155047e84961268eeffdfa2ec8a595ed4c21b4/appengine/config_service/ui/src/config-ui/config-set.html
[modify] https://crrev.com/51155047e84961268eeffdfa2ec8a595ed4c21b4/appengine/config_service/ui/src/config-ui/config-ui.html

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/71c3c10aecb784a070f19d47eabb4ccfebc6c6c2

commit 71c3c10aecb784a070f19d47eabb4ccfebc6c6c2
Author: cwpayton <cwpayton@google.com>
Date: Thu Jun 29 17:27:25 2017

config_service: Added google-signin-aware.html for Polymer 2.0.

This is the original file that was pulled from Scarygami's 2.0-preview branch
of the Google Web Component google-signin-aware. This CL is being uploaded
so that my changes to this file can be viewed in another CL.

The link to this particular file can be found here:
https://github.com/Scarygami/google-signin/blob/599547e042ae4e5dec21051953754eec93fe26ca/google-signin-aware.html

BUG= 730832 

Review-Url: https://codereview.chromium.org/2963963003

[add] https://crrev.com/71c3c10aecb784a070f19d47eabb4ccfebc6c6c2/appengine/config_service/ui/common/third-party/google-signin-aware.html

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/160ef2c6cacca9617e67c94b758ff4303e3fe839

commit 160ef2c6cacca9617e67c94b758ff4303e3fe839
Author: cwpayton <cwpayton@google.com>
Date: Fri Jun 30 00:15:39 2017

config_service: Add authentication to the UI.

Users can now sign in to view all projects and services.

This change involved creating a modified version of the google-signin-aware element that
works with Polymer 2.0. This modified file is in a third party folder.

Staging version can be found here: https://2941-71c3c10-tainted-cwpayton-dot-luci-config.appspot.com/newui

BUG= 730832 

Review-Url: https://codereview.chromium.org/2962703003

[modify] https://crrev.com/160ef2c6cacca9617e67c94b758ff4303e3fe839/appengine/config_service/app.yaml
[modify] https://crrev.com/160ef2c6cacca9617e67c94b758ff4303e3fe839/appengine/config_service/handlers.py
[modify] https://crrev.com/160ef2c6cacca9617e67c94b758ff4303e3fe839/appengine/config_service/ui/README.md
[modify] https://crrev.com/160ef2c6cacca9617e67c94b758ff4303e3fe839/appengine/config_service/ui/bower.json
[add] https://crrev.com/160ef2c6cacca9617e67c94b758ff4303e3fe839/appengine/config_service/ui/common/auth-signin.html
[rename] https://crrev.com/160ef2c6cacca9617e67c94b758ff4303e3fe839/appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html
[modify] https://crrev.com/160ef2c6cacca9617e67c94b758ff4303e3fe839/appengine/config_service/ui/src/config-ui/config-set.html
[modify] https://crrev.com/160ef2c6cacca9617e67c94b758ff4303e3fe839/appengine/config_service/ui/src/config-ui/config-ui.html
[modify] https://crrev.com/160ef2c6cacca9617e67c94b758ff4303e3fe839/appengine/config_service/ui/src/config-ui/front-page.html
[modify] https://crrev.com/160ef2c6cacca9617e67c94b758ff4303e3fe839/appengine/config_service/ui/static/index.html

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 6 2017

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/56121b33d24c5a9fb2a8aff8247cf52f749a6952

commit 56121b33d24c5a9fb2a8aff8247cf52f749a6952
Author: ayanaadylova <ayanaadylova@google.com>
Date: Tue Jul 11 00:26:39 2017

config_service: add last import validation and tests

In the front page user can see whether last import was successful or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Added tests for front-page and config-set page.

BUG= 730832 

Review-Url: https://codereview.chromium.org/2959833002

[modify] https://crrev.com/56121b33d24c5a9fb2a8aff8247cf52f749a6952/appengine/config_service/app.yaml
[modify] https://crrev.com/56121b33d24c5a9fb2a8aff8247cf52f749a6952/appengine/config_service/ui/src/config-ui/config-file-card.html
[modify] https://crrev.com/56121b33d24c5a9fb2a8aff8247cf52f749a6952/appengine/config_service/ui/src/config-ui/config-set-card.html
[modify] https://crrev.com/56121b33d24c5a9fb2a8aff8247cf52f749a6952/appengine/config_service/ui/src/config-ui/config-set.html
[modify] https://crrev.com/56121b33d24c5a9fb2a8aff8247cf52f749a6952/appengine/config_service/ui/src/config-ui/config-ui.html
[modify] https://crrev.com/56121b33d24c5a9fb2a8aff8247cf52f749a6952/appengine/config_service/ui/src/config-ui/front-page.html
[add] https://crrev.com/56121b33d24c5a9fb2a8aff8247cf52f749a6952/appengine/config_service/ui/static/elements.html
[modify] https://crrev.com/56121b33d24c5a9fb2a8aff8247cf52f749a6952/appengine/config_service/ui/static/index.html
[add] https://crrev.com/56121b33d24c5a9fb2a8aff8247cf52f749a6952/appengine/config_service/ui/test/config-ui/config-set_test.html
[modify] https://crrev.com/56121b33d24c5a9fb2a8aff8247cf52f749a6952/appengine/config_service/ui/test/config-ui/front-page_test.html
[add] https://crrev.com/56121b33d24c5a9fb2a8aff8247cf52f749a6952/appengine/config_service/ui/test/index.html

Blockedon: 740777
Blockedon: 740775
Blockedon: 740774
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/32ed948dea48cdeeb11ee7b4d8ab0465837f42c9

commit 32ed948dea48cdeeb11ee7b4d8ab0465837f42c9
Author: cwpayton <cwpayton@google.com>
Date: Tue Jul 11 21:44:19 2017

config_service: Fixed bug regarding None entries in latest_revisions dict.

Using the include_files option on config sets that had no latest revision
number caused a 503 Internal Server Error because there was no check for
None entries in the result from get_latest_revisions_async. This cl fixes
that by adding a check.

BUG= 730832 

Review-Url: https://codereview.chromium.org/2981473002

[modify] https://crrev.com/32ed948dea48cdeeb11ee7b4d8ab0465837f42c9/appengine/config_service/api.py

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/4d627a522380d34a18e57b534fa38f4180e418c3

commit 4d627a522380d34a18e57b534fa38f4180e418c3
Author: cwpayton <cwpayton@google.com>
Date: Thu Jul 13 03:37:10 2017

config_service: Changed lists from paper-items to paper-cards, fixed
search box, added shadows and slight animation.

BUG= 730832 

Review-Url: https://codereview.chromium.org/2977763002

[modify] https://crrev.com/4d627a522380d34a18e57b534fa38f4180e418c3/appengine/config_service/ui/bower.json
[modify] https://crrev.com/4d627a522380d34a18e57b534fa38f4180e418c3/appengine/config_service/ui/common/auth-signin.html
[modify] https://crrev.com/4d627a522380d34a18e57b534fa38f4180e418c3/appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html
[modify] https://crrev.com/4d627a522380d34a18e57b534fa38f4180e418c3/appengine/config_service/ui/src/config-ui/config-file-card.html
[modify] https://crrev.com/4d627a522380d34a18e57b534fa38f4180e418c3/appengine/config_service/ui/src/config-ui/config-set-card.html
[modify] https://crrev.com/4d627a522380d34a18e57b534fa38f4180e418c3/appengine/config_service/ui/src/config-ui/config-set.html
[modify] https://crrev.com/4d627a522380d34a18e57b534fa38f4180e418c3/appengine/config_service/ui/src/config-ui/config-ui.html
[modify] https://crrev.com/4d627a522380d34a18e57b534fa38f4180e418c3/appengine/config_service/ui/src/config-ui/front-page.html
[modify] https://crrev.com/4d627a522380d34a18e57b534fa38f4180e418c3/appengine/config_service/ui/test/config-ui/config-set_test.html
[modify] https://crrev.com/4d627a522380d34a18e57b534fa38f4180e418c3/appengine/config_service/ui/test/config-ui/front-page_test.html

Labels: -Type-Launch Type-Feature
Apparently Type=Launch makes the bug internal-only. Making this bug public again.
Blockedon: 742522
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/f16285c26e156183e6b896b6fa1966c4491fc70c

commit f16285c26e156183e6b896b6fa1966c4491fc70c
Author: ayanaadylova <ayanaadylova@google.com>
Date: Wed Jul 19 21:16:13 2017

config_service: README update

Updated README.md file inside ui folder.

BUG= 730832 

Review-Url: https://codereview.chromium.org/2985493002

[modify] https://crrev.com/f16285c26e156183e6b896b6fa1966c4491fc70c/appengine/config_service/ui/README.md

Blockedon: 747083
Blockedon: 747491
Blockedon: 747597
Blockedon: 748809
Blockedon: 748828
Blockedon: 749371

Comment 31 by no...@chromium.org, Jul 27 2017

Blockedon: 749533

Comment 32 by no...@chromium.org, Jul 27 2017

Blockedon: 749534

Comment 33 by no...@chromium.org, Jul 27 2017

Blockedon: 749537

Comment 34 by no...@chromium.org, Jul 27 2017

Blockedon: 749540

Comment 35 by no...@chromium.org, Jul 28 2017

Blockedon: 749995

Comment 36 by no...@chromium.org, Jul 28 2017

Blockedon: 749999

Comment 37 by no...@chromium.org, Jul 28 2017

Blockedon: 750003

Comment 38 by no...@chromium.org, Jul 28 2017

Blockedon: 750004

Comment 39 by no...@chromium.org, Jul 28 2017

Blockedon: 750005

Comment 40 by no...@chromium.org, Jul 28 2017

Blockedon: 750007

Comment 41 by no...@chromium.org, Jul 28 2017

Blockedon: 750008

Comment 42 by no...@chromium.org, Jul 28 2017

Blockedon: 750012
Blockedon: 753917

Comment 44 by no...@chromium.org, Aug 11 2017

Blockedon: 754521

Comment 45 by no...@chromium.org, Aug 15 2017

Status: Fixed (was: Available)
Thanks Cameron and Ayana for the implementation and Sergey and Ryan for hosting!

Sign in to add a comment