New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730783 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 703184



Sign in to add a comment

Tracker bug for UKM/NOKM integration with memory-infra UMA

Project Member Reported by primiano@chromium.org, Jun 7 2017

Issue description

Design doc will follow
 
Cc: tdres...@chromium.org
Cc: jchin...@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a5e138e54b594d560ca217a7244293a7442495d

commit 1a5e138e54b594d560ca217a7244293a7442495d
Author: Tomasz Mikolajewski <mtomasz@chromium.org>
Date: Tue Jul 11 08:30:05 2017

Revert "Add memory UKMs for existing UMA metrics."

This reverts commit 7fa78bb0faf51233cdb427da404134b95e2e87bd.

Reason for revert: Crashing browser process on null ptr dereference.

Original change's description:
> Add memory UKMs for existing UMA metrics.
> 
> Bug: 730783, 728707
> Change-Id: I744c73d36ca76d97eff1e202fa20ba5d4a9adb7b
> Reviewed-on: https://chromium-review.googlesource.com/531804
> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485159}

TBR=rkaplow@chromium.org,erikchen@chromium.org,jchinlee@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 730783, 728707
Change-Id: I0993305f4eb65343faf6678054de0d1c2d1fcddb
Reviewed-on: https://chromium-review.googlesource.com/566518
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485554}
[modify] https://crrev.com/1a5e138e54b594d560ca217a7244293a7442495d/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/1a5e138e54b594d560ca217a7244293a7442495d/chrome/browser/metrics/process_memory_metrics_emitter.h
[delete] https://crrev.com/ad9c419d606067ddc7ed322b1b9cfdc900727406/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/1a5e138e54b594d560ca217a7244293a7442495d/chrome/test/BUILD.gn
[modify] https://crrev.com/1a5e138e54b594d560ca217a7244293a7442495d/services/metrics/public/cpp/ukm_recorder.h
[modify] https://crrev.com/1a5e138e54b594d560ca217a7244293a7442495d/tools/metrics/ukm/ukm.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 11 2017

Labels: merge-merged-3154
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8a421ba69381f135dbaaa2eda587b6318e69d48

commit b8a421ba69381f135dbaaa2eda587b6318e69d48
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Tue Jul 11 15:28:50 2017

Revert "Add memory UKMs for existing UMA metrics."

This reverts commit 7fa78bb0faf51233cdb427da404134b95e2e87bd.

Reason for revert: Crashing browser process on null ptr dereference.

Original change's description:
> Add memory UKMs for existing UMA metrics.
>
> Bug: 730783, 728707
> Change-Id: I744c73d36ca76d97eff1e202fa20ba5d4a9adb7b
> Reviewed-on: https://chromium-review.googlesource.com/531804
> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485159}

TBR=erikchen@chromium.org, jchinlee@chromium.org, mtomasz@chromium.org, rkaplow@chromium.org


(cherry picked from commit 1a5e138e54b594d560ca217a7244293a7442495d)

Bug: 730783, 728707
Change-Id: I0993305f4eb65343faf6678054de0d1c2d1fcddb
Reviewed-on: https://chromium-review.googlesource.com/566518
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#485554}
Reviewed-on: https://chromium-review.googlesource.com/566889
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/branch-heads/3154@{#3}
Cr-Branched-From: 954c2e35872602531eff6a367007ebc60fd40b1d-refs/heads/master@{#485485}
[modify] https://crrev.com/b8a421ba69381f135dbaaa2eda587b6318e69d48/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/b8a421ba69381f135dbaaa2eda587b6318e69d48/chrome/browser/metrics/process_memory_metrics_emitter.h
[delete] https://crrev.com/bdc70f55482f6d779d325d679c4ab4791606a505/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/b8a421ba69381f135dbaaa2eda587b6318e69d48/chrome/test/BUILD.gn
[modify] https://crrev.com/b8a421ba69381f135dbaaa2eda587b6318e69d48/services/metrics/public/cpp/ukm_recorder.h
[modify] https://crrev.com/b8a421ba69381f135dbaaa2eda587b6318e69d48/tools/metrics/ukm/ukm.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c6c624f8431622a16d996e94673ed0b1989ea1c

commit 4c6c624f8431622a16d996e94673ed0b1989ea1c
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Wed Jul 12 21:56:16 2017

Reland "Add memory UKMs for existing UMA metrics."

This is a reland of 7fa78bb0faf51233cdb427da404134b95e2e87bd
Original change's description:
> Add memory UKMs for existing UMA metrics.
> 
> Bug: 730783, 728707
> Change-Id: I744c73d36ca76d97eff1e202fa20ba5d4a9adb7b
> Reviewed-on: https://chromium-review.googlesource.com/531804
> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485159}

Bug: 730783, 728707
Change-Id: I314ecfa620bbd317e2cd4164279eb86a2248bbfb
Reviewed-on: https://chromium-review.googlesource.com/567220
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486116}
[modify] https://crrev.com/4c6c624f8431622a16d996e94673ed0b1989ea1c/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/4c6c624f8431622a16d996e94673ed0b1989ea1c/chrome/browser/metrics/process_memory_metrics_emitter.h
[add] https://crrev.com/4c6c624f8431622a16d996e94673ed0b1989ea1c/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/4c6c624f8431622a16d996e94673ed0b1989ea1c/chrome/test/BUILD.gn
[modify] https://crrev.com/4c6c624f8431622a16d996e94673ed0b1989ea1c/services/metrics/public/cpp/ukm_recorder.h
[modify] https://crrev.com/4c6c624f8431622a16d996e94673ed0b1989ea1c/tools/metrics/ukm/ukm.xml

Comment 9 by l...@chromium.org, Jul 19 2017

Cc: l...@chromium.org matthalp@google.com
Labels: Hotlist-GRC
cc matthalp@ and myself
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d8d254c7eb403770bfc310cb9abe3406fac9503

commit 1d8d254c7eb403770bfc310cb9abe3406fac9503
Author: Erik Chen <erikchen@chromium.org>
Date: Sat Jul 29 18:53:01 2017

Plumb URLs through memory_instrumentation UKMs.

The URLs are obtained by creating a new interface CoordinationUnitIntrospector
on the resource_coordinator service. The implementation of this interface crawls
all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by
looking at associated FrameCoordinationUnits.

The interface for memory_instrumentation is modified slightly to include pid in
ProcessMemoryDump to allow correlation between the memory dump and the URLs
obtained from resource_coordinator. In a hypothetical future world where
memory_instrumentation and resource_coordinator live in the same service, this
can be removed.

Bug:730783

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70
Reviewed-on: https://chromium-review.googlesource.com/578482
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490668}
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/chrome/browser/DEPS
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/chrome/browser/metrics/process_memory_metrics_emitter.h
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[add] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.cc
[add] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.h
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/manifest.json
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/public/cpp/resource_coordinator_interface.h
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/public/interfaces/BUILD.gn
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/public/interfaces/coordination_unit.mojom
[add] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/public/interfaces/coordination_unit_introspector.mojom
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/resource_coordinator_service.cc
[modify] https://crrev.com/1d8d254c7eb403770bfc310cb9abe3406fac9503/services/resource_coordinator/resource_coordinator_service.h

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16169b07d2699afd7369f16176cae3447fed5499

commit 16169b07d2699afd7369f16176cae3447fed5499
Author: meade_UTC10 <meade@chromium.org>
Date: Sun Jul 30 05:07:15 2017

Revert "Plumb URLs through memory_instrumentation UKMs."

This reverts commit 1d8d254c7eb403770bfc310cb9abe3406fac9503.

Reason for revert: Broke
ProcessMemoryMetricsEmitterTest.FetchDuringTrace
ProcessMemoryMetricsEmitterTest.FetchAndEmitMetrics
ProcessMemoryMetricsEmitterTest.FetchThreeTimes

on chromium.win/Win7 Tests (dbg)(1)

First broken run: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61933


Original change's description:
> Plumb URLs through memory_instrumentation UKMs.
> 
> The URLs are obtained by creating a new interface CoordinationUnitIntrospector
> on the resource_coordinator service. The implementation of this interface crawls
> all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by
> looking at associated FrameCoordinationUnits.
> 
> The interface for memory_instrumentation is modified slightly to include pid in
> ProcessMemoryDump to allow correlation between the memory dump and the URLs
> obtained from resource_coordinator. In a hypothetical future world where
> memory_instrumentation and resource_coordinator live in the same service, this
> can be removed.
> 
> Bug:730783
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70
> Reviewed-on: https://chromium-review.googlesource.com/578482
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490668}

TBR=avi@chromium.org,dcheng@chromium.org,thestig@chromium.org,primiano@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,oysteine@chromium.org

Change-Id: I07a942b89aa22dcddd924fdcaeda025b6484b4eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 730783, 750476 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/593267
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490682}
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/chrome/browser/DEPS
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/chrome/browser/metrics/process_memory_metrics_emitter.h
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[delete] https://crrev.com/9f67c851ed4af1217033c61254525f6fdcbc2202/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.cc
[delete] https://crrev.com/9f67c851ed4af1217033c61254525f6fdcbc2202/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.h
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/manifest.json
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/public/cpp/resource_coordinator_interface.h
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/public/interfaces/BUILD.gn
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/public/interfaces/coordination_unit.mojom
[delete] https://crrev.com/9f67c851ed4af1217033c61254525f6fdcbc2202/services/resource_coordinator/public/interfaces/coordination_unit_introspector.mojom
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/resource_coordinator_service.cc
[modify] https://crrev.com/16169b07d2699afd7369f16176cae3447fed5499/services/resource_coordinator/resource_coordinator_service.h

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a0d5531fa05de14a820cc2677492da49017b716

commit 1a0d5531fa05de14a820cc2677492da49017b716
Author: Nico Weber <thakis@chromium.org>
Date: Sun Jul 30 17:16:56 2017

Revert "Plumb URLs through memory_instrumentation UKMs."

This reverts commit 1d8d254c7eb403770bfc310cb9abe3406fac9503.

Reason for revert: Fails on win7:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61933

Original change's description:
> Plumb URLs through memory_instrumentation UKMs.
> 
> The URLs are obtained by creating a new interface CoordinationUnitIntrospector
> on the resource_coordinator service. The implementation of this interface crawls
> all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by
> looking at associated FrameCoordinationUnits.
> 
> The interface for memory_instrumentation is modified slightly to include pid in
> ProcessMemoryDump to allow correlation between the memory dump and the URLs
> obtained from resource_coordinator. In a hypothetical future world where
> memory_instrumentation and resource_coordinator live in the same service, this
> can be removed.
> 
> Bug:730783
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70
> Reviewed-on: https://chromium-review.googlesource.com/578482
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490668}

TBR=avi@chromium.org,dcheng@chromium.org,thestig@chromium.org,primiano@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,oysteine@chromium.org

Change-Id: I0120cea65f8e95f787d15579e427b9b3bab86187
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 730783
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/593213
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490685}


"""
[  FAILED  ] ProcessMemoryMetricsEmitterTest.FetchDuringTrace, where TypeParam =  and GetParam() =  (11251 ms)
[318/319] ProcessMemoryMetricsEmitterTest.FetchDuringTrace (13614 ms)
Still waiting for the following processes to finish:
	".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=SSLUIWorkerFetchTest.MixedContentSettingsWithBlockingCSP/0 --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\w\ioqxms64\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir1892_32418\d1892_25998"
Still waiting for the following processes to finish:
	".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=SSLUIWorkerFetchTest.MixedContentSettingsWithBlockingCSP/0 --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\w\ioqxms64\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir1892_32418\d1892_25998"
[319/319] SSLUIWorkerFetchTest.MixedContentSettingsWithBlockingCSP/0 (41557 ms)
Retrying 1 test (retry #2)
[ RUN      ] ProcessMemoryMetricsEmitterTest.FetchDuringTrace
[936:5884:0729/130331.450:ERROR:direct_composition_surface_win.cc(1073)] Failing to detect HDR, couldn't retrieve D3D11 device from ANGLE.
[936:5884:0729/130331.495:INFO:media_foundation_video_encode_accelerator_win.cc(335)] Windows versions earlier than 8 are not supported.
../../chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc(201): error: Expected: (metrics[0]) <= (1000), actual: 1832 vs 1000
[2104:5840:0729/130336.805:ERROR:event_page_request_manager.cc(147)] An error encountered while waking the event page.
[2104:5840:0729/130336.805:ERROR:event_page_request_manager.cc(89)] Draining request queue. (queue-length=3)
[  FAILED  ] ProcessMemoryMetricsEmitterTest.FetchDuringTrace, where TypeParam =  and GetParam() =  (7455 ms)
[320/320] ProcessMemoryMetricsEmitterTest.FetchDuringTrace (8990 ms)
Retrying 1 test (retry #3)
[ RUN      ] ProcessMemoryMetricsEmitterTest.FetchDuringTrace
[4904:5464:0729/130340.561:ERROR:direct_composition_surface_win.cc(1073)] Failing to detect HDR, couldn't retrieve D3D11 device from ANGLE.
[4904:5464:0729/130340.612:INFO:media_foundation_video_encode_accelerator_win.cc(335)] Windows versions earlier than 8 are not supported.
../../chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc(201): error: Expected: (metrics[0]) <= (1000), actual: 1835 vs 1000
[3600:5660:0729/130347.581:ERROR:event_page_request_manager.cc(147)] An error encountered while waking the event page.
[3600:5660:0729/130347.581:ERROR:event_page_request_manager.cc(89)] Draining request queue. (queue-length=3)
[  FAILED  ] ProcessMemoryMetricsEmitterTest.FetchDuringTrace, where TypeParam =  and GetParam() =  (8369 ms)
[321/321] ProcessMemoryMetricsEmitterTest.FetchDuringTrace (10752 ms)
1 test failed:
    ProcessMemoryMetricsEmitterTest.FetchDuringTrace (../../chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc:274)
"""

This is line that's failing:
"""
  void CheckMemoryMetricWithName(const ukm::UkmSource* source,
                                 const char* name,
                                 bool can_be_zero) {
    std::vector<int64_t> metrics =
        test_ukm_recorder_.GetMetrics(*source, UkmEventName, name);
    ASSERT_EQ(1u, metrics.size());
    EXPECT_GE(metrics[0], can_be_zero ? 0 : 1);
    EXPECT_LE(metrics[0], 1000);
  }
"""


Sadly, I don't know which metric is failing.

The test previous had the following lines:
"""
  // As a sanity check, no memory stat should exceed 1 GB.
  int64_t maximum_expected_size = 1ll << 30;
"""

So I wonder if there's a unit conversion error? 
Cc: ajwong@chromium.org
It looks like GetProcessMemoryInfo has slightly different (?) behavior on 64-bit Chrome and 32-bit Chrome. In 64-bit Chrome, Resident ~180MB, and PMM ~60MB for a renderer. In 32-bit Chrome, both are about 450MB. So for two renderers, and some other stats, TotalMemoryFootprint > 1GB.

ajwong@, any idea why PagefileUsage/PrivateUsage/CommitCharge is so much more higher for 32-bit Chrome? 
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/173bf304fcb1a0a4ae819170d2297587386d3679

commit 173bf304fcb1a0a4ae819170d2297587386d3679
Author: Erik Chen <erikchen@chromium.org>
Date: Mon Jul 31 06:06:21 2017

[Reland #1] Plumb URLs through memory_instrumentation UKMs.

The original CL added more end-to-end tests. They set a limit of 1 GB as a
"sanity check". On 32-bit Windows, each renderer has ~500MB of committed
memory. Across multiple renderers, this easily exceeds the limit. This reland
updates the "sanity checks" to be 4 GB instead.

> The URLs are obtained by creating a new interface CoordinationUnitIntrospector
> on the resource_coordinator service. The implementation of this interface crawls
> all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by
> looking at associated FrameCoordinationUnits.
>
> The interface for memory_instrumentation is modified slightly to include pid in
> ProcessMemoryDump to allow correlation between the memory dump and the URLs
> obtained from resource_coordinator. In a hypothetical future world where
> memory_instrumentation and resource_coordinator live in the same service, this
> can be removed.
>
> Bug:730783
>
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70
> Reviewed-on: https://chromium-review.googlesource.com/578482
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490668}


Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I98d979303b095ee386228ac93d234fe8c8367b3e
Bug: 
TBR: thestig@chromium.org, oysteine@chromium.org, rkaplow@chromium.org, avi@chromium.org, primiano@chromium.org, dcheng@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/592539
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490713}
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/chrome/browser/DEPS
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/chrome/browser/metrics/process_memory_metrics_emitter.h
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[add] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.cc
[add] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.h
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/manifest.json
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/public/cpp/resource_coordinator_interface.h
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/public/interfaces/BUILD.gn
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/public/interfaces/coordination_unit.mojom
[add] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/public/interfaces/coordination_unit_introspector.mojom
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/resource_coordinator_service.cc
[modify] https://crrev.com/173bf304fcb1a0a4ae819170d2297587386d3679/services/resource_coordinator/resource_coordinator_service.h

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6d9db6224fcd47ddb64f2a43dc1eb1955a9f393

commit c6d9db6224fcd47ddb64f2a43dc1eb1955a9f393
Author: erikchen <erikchen@chromium.org>
Date: Fri Aug 04 01:23:53 2017

Only report root frames in GetProcessToURLMap.

This allows the memory-infra UKMs to correctly report the URL of the root frame
for each process, since there is no way to report multiple URLs [for child
frames].

Bug: 730783
Change-Id: I342b3a76d543c8f9e4b0e2edc34f88d331e8b4e1
Reviewed-on: https://chromium-review.googlesource.com/601164
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491904}
[modify] https://crrev.com/c6d9db6224fcd47ddb64f2a43dc1eb1955a9f393/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b56172dbfda101625a9598a630bbe6dfe00afc85

commit b56172dbfda101625a9598a630bbe6dfe00afc85
Author: Siddhartha <ssid@chromium.org>
Date: Sat Mar 03 07:00:33 2018

MemoryInfra: Add UKM for background dump providers

This cl adds ukm for background memory dump providers. This only adds
the providers approved in the privacy review:
https://docs.google.com/document/d/1mzRM7TzDHo-blauk5nfG34zX_4_amCoshPE1iptoOdQ
UMA for these metrics will be added in next cl.

BUG=730783

Change-Id: Ife23dd28cd443725a7b8a6d74ba532220f4bb46f
Reviewed-on: https://chromium-review.googlesource.com/939904
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540745}
[modify] https://crrev.com/b56172dbfda101625a9598a630bbe6dfe00afc85/base/trace_event/memory_infra_background_whitelist.cc
[modify] https://crrev.com/b56172dbfda101625a9598a630bbe6dfe00afc85/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/b56172dbfda101625a9598a630bbe6dfe00afc85/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/b56172dbfda101625a9598a630bbe6dfe00afc85/tools/metrics/ukm/ukm.xml

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d22d7c84ad346299aa01bf195656e846a228d2e

commit 5d22d7c84ad346299aa01bf195656e846a228d2e
Author: Siddhartha <ssid@chromium.org>
Date: Wed Mar 14 17:05:54 2018

MemoryInfra: Group site_storage dumps and enable missing providers in background mode.

The site_storage dumps do not have child categories and the graph
processor is unable to group them by type of storage. So, group the
dumps under correct child dumps to get metrics.
Also enable missing MDP in background mode: FontCaches, BlobStorage.

BUG=730783

Change-Id: I07d0cf8a98c53c4eaaceda3c05610bd765df6222
Reviewed-on: https://chromium-review.googlesource.com/961530
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543109}
[modify] https://crrev.com/5d22d7c84ad346299aa01bf195656e846a228d2e/base/trace_event/memory_infra_background_whitelist.cc
[modify] https://crrev.com/5d22d7c84ad346299aa01bf195656e846a228d2e/content/browser/dom_storage/dom_storage_context_impl.cc
[modify] https://crrev.com/5d22d7c84ad346299aa01bf195656e846a228d2e/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/5d22d7c84ad346299aa01bf195656e846a228d2e/content/browser/dom_storage/session_storage_database.cc
[modify] https://crrev.com/5d22d7c84ad346299aa01bf195656e846a228d2e/storage/browser/blob/blob_storage_context.cc

Comment 19 by ssid@chromium.org, Mar 14 2018

Owner: ssid@chromium.org

Comment 20 by l...@chromium.org, Mar 14 2018

Cc: -l...@chromium.org -matthalp@google.com

Comment 21 by l...@chromium.org, Mar 14 2018

Labels: -Hotlist-GRC
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edcb9adc4b06a3b4467b7b87900c73c495fcffeb

commit edcb9adc4b06a3b4467b7b87900c73c495fcffeb
Author: Siddhartha <ssid@chromium.org>
Date: Thu Mar 15 21:13:45 2018

MemoryInfra: Report all provider metrics to UKM

Most of the metrics were added to UKM in:
https://chromium-review.googlesource.com/c/chromium/src/+/939904
Some metrics were missed due to privacy review being stale.
This CL adds the remaining metrics after updating privacy doc

BUG=730783

Change-Id: Iec4cc7d6cc4f90c7fb57a9bd8cad23eef7e3dce9
Reviewed-on: https://chromium-review.googlesource.com/961538
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543497}
[modify] https://crrev.com/edcb9adc4b06a3b4467b7b87900c73c495fcffeb/base/trace_event/memory_infra_background_whitelist.cc
[modify] https://crrev.com/edcb9adc4b06a3b4467b7b87900c73c495fcffeb/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/edcb9adc4b06a3b4467b7b87900c73c495fcffeb/tools/metrics/ukm/ukm.xml

Project Member

Comment 23 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a66d53518f36bc237cb1930ee4698dd03c5f7c50

commit a66d53518f36bc237cb1930ee4698dd03c5f7c50
Author: Siddhartha <ssid@chromium.org>
Date: Thu Mar 15 23:54:13 2018

MemoryInfra: Remove Summary mode whitelist

The summary and background mode use the same set of MDPs now.
So, remove duplicate list.

BUG=730783

Change-Id: I3568d797d5bab3d36df658feb22df28d8ea786a4
Reviewed-on: https://chromium-review.googlesource.com/961554
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Hector Dearman <hjd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543553}
[modify] https://crrev.com/a66d53518f36bc237cb1930ee4698dd03c5f7c50/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/a66d53518f36bc237cb1930ee4698dd03c5f7c50/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/a66d53518f36bc237cb1930ee4698dd03c5f7c50/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/a66d53518f36bc237cb1930ee4698dd03c5f7c50/base/trace_event/memory_dump_provider_info.cc
[modify] https://crrev.com/a66d53518f36bc237cb1930ee4698dd03c5f7c50/base/trace_event/memory_dump_provider_info.h
[modify] https://crrev.com/a66d53518f36bc237cb1930ee4698dd03c5f7c50/base/trace_event/memory_infra_background_whitelist.cc
[modify] https://crrev.com/a66d53518f36bc237cb1930ee4698dd03c5f7c50/base/trace_event/memory_infra_background_whitelist.h
[modify] https://crrev.com/a66d53518f36bc237cb1930ee4698dd03c5f7c50/base/trace_event/memory_peak_detector_unittest.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60082e2a5fb58e860cde485f72a125424060903f

commit 60082e2a5fb58e860cde485f72a125424060903f
Author: Siddhartha <ssid@chromium.org>
Date: Mon Mar 19 22:47:47 2018

Add UMA for all the memory metrics in UKM

The memory metrics added in UKM were not recorded in UMA. Add metrics
in UMA for all these metrics.
Removed duplicate UMA metrics: <Process>2.PrivateMemoryFootprint and
<Process>2.Resident.

BUG=730783

Change-Id: I568a7d455fd37e48532c722a1ddb7feff4fa05f0
Reviewed-on: https://chromium-review.googlesource.com/961384
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544194}
[modify] https://crrev.com/60082e2a5fb58e860cde485f72a125424060903f/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/60082e2a5fb58e860cde485f72a125424060903f/tools/metrics/histograms/histograms.xml

Project Member

Comment 25 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4382945f4666ea40d8b474f1389974ab140011b

commit c4382945f4666ea40d8b474f1389974ab140011b
Author: Siddhartha <ssid@chromium.org>
Date: Fri Mar 23 01:24:15 2018

MemoryInfra: Remove the summary struct since we use graph processing

Remove old temporary code that is unused.

BUG=730783

Change-Id: I086fd90ccf8aa0f47f315efaf832ba76476fc951
Reviewed-on: https://chromium-review.googlesource.com/966968
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Hector Dearman <hjd@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545327}
[modify] https://crrev.com/c4382945f4666ea40d8b474f1389974ab140011b/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/c4382945f4666ea40d8b474f1389974ab140011b/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/c4382945f4666ea40d8b474f1389974ab140011b/chrome/browser/profiling_host/background_profiling_triggers_unittest.cc
[modify] https://crrev.com/c4382945f4666ea40d8b474f1389974ab140011b/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[modify] https://crrev.com/c4382945f4666ea40d8b474f1389974ab140011b/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
[modify] https://crrev.com/c4382945f4666ea40d8b474f1389974ab140011b/services/resource_coordinator/public/cpp/memory_instrumentation/global_memory_dump.cc
[modify] https://crrev.com/c4382945f4666ea40d8b474f1389974ab140011b/services/resource_coordinator/public/cpp/memory_instrumentation/global_memory_dump.h
[modify] https://crrev.com/c4382945f4666ea40d8b474f1389974ab140011b/services/resource_coordinator/public/mojom/memory_instrumentation/memory_instrumentation.mojom

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment