New issue
Advanced search Search tips

Issue 730774 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

BattOr agent fails with error message about reference counting

Project Member Reported by charliea@chromium.org, Jun 7 2017

Issue description

Call stack:

[0607/160536.180855:INFO:battor_finder.cc(44)] Found BattOr with display name BattOr_v3.2.1 at path /dev/ttyUSB0
StartTracing
[0607/160538.441019:FATAL:ref_counted.h(73)] Check failed: CalledOnValidSequence(). 
#0 0x7f86599b392b base::debug::StackTrace::StackTrace()
#1 0x7f86599b262c base::debug::StackTrace::StackTrace()
#2 0x7f8659a261c3 logging::LogMessage::~LogMessage()
#3 0x000000424a0f base::subtle::RefCountedBase::AddRef()
#4 0x0000004247d5 base::RefCounted<>::AddRef()
#5 0x0000004247b9 scoped_refptr<>::AddRef()
#6 0x00000043da05 scoped_refptr<>::scoped_refptr()
#7 0x00000043d980 std::_Head_base<>::_Head_base<>()
#8 0x00000043e339 _ZNSt11_Tuple_implILm0EJ13scoped_refptrIN6device15SerialIoHandlerEEN4base8internal13PassedWrapperINS4_4FileEEEEEC2IPS2_JS8_EvEEOT_DpOT0_
#9 0x00000043e1f2 _ZNSt5tupleIJ13scoped_refptrIN6device15SerialIoHandlerEEN4base8internal13PassedWrapperINS4_4FileEEEEEC2IPS2_S8_vEEOT_OT0_
#10 0x00000043e0a1 _ZN4base8internal9BindStateIMN6device15SerialIoHandlerEFvNS_4FileEEJ13scoped_refptrIS3_ENS0_13PassedWrapperIS4_EEEEC2IS6_JPS3_SA_EEESt17integral_constantIbLb0EEPFvvEOT_DpOT0_
#11 0x00000043db9a _ZN4base8internal9BindStateIMN6device15SerialIoHandlerEFvNS_4FileEEJ13scoped_refptrIS3_ENS0_13PassedWrapperIS4_EEEEC2IS6_JPS3_SA_EEEPFvvEOT_DpOT0_
#12 0x00000043dad2 _ZN4base13BindRepeatingIMN6device15SerialIoHandlerEFvNS_4FileEEJPS2_NS_8internal13PassedWrapperIS3_EEEEENS_8CallbackINS7_22MakeUnboundRunTypeImplIT_JDpT0_EE4TypeELNS7_8CopyModeE1ELNS7_10RepeatModeE1EEEOSC_DpOSD_
#13 0x00000043c739 _ZN4base4BindIMN6device15SerialIoHandlerEFvNS_4FileEEJPS2_NS_8internal13PassedWrapperIS3_EEEEENS_8CallbackINS7_22MakeUnboundRunTypeImplIT_JDpT0_EE4TypeELNS7_8CopyModeE1ELNS7_10RepeatModeE1EEEOSC_DpOSD_
#14 0x00000043af57 device::SerialIoHandler::StartOpen()
#15 0x00000043d3b1 _ZN4base8internal13FunctorTraitsIMN6device15SerialIoHandlerEFvRKSs13scoped_refptrINS_22SingleThreadTaskRunnerEEEvE6InvokeIRKS6_IS3_EJS5_RKS8_EEEvSA_OT_DpOT0_
#16 0x00000043d27b _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN6device15SerialIoHandlerEFvRKSs13scoped_refptrINS_22SingleThreadTaskRunnerEEEJRKS8_IS5_ES7_RKSA_EEEvOT_DpOT0_
#17 0x00000043d1f4 _ZN4base8internal7InvokerINS0_9BindStateIMN6device15SerialIoHandlerEFvRKSs13scoped_refptrINS_22SingleThreadTaskRunnerEEEJS7_IS4_ESsS9_EEEFvvEE7RunImplIRKSB_RKSt5tupleIJSC_SsS9_EEJLm0ELm1ELm2EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#18 0x00000043d0cc _ZN4base8internal7InvokerINS0_9BindStateIMN6device15SerialIoHandlerEFvRKSs13scoped_refptrINS_22SingleThreadTaskRunnerEEEJS7_IS4_ESsS9_EEEFvvEE3RunEPNS0_13BindStateBaseE
#19 0x7f865996f10e _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#20 0x7f86599b957e base::debug::TaskAnnotator::RunTask()
#21 0x7f8659b8212b base::internal::TaskTracker::PerformRunTask()
#22 0x7f8659b84883 base::internal::TaskTrackerPosix::PerformRunTask()
#23 0x7f8659b8131d base::internal::TaskTracker::RunNextTask()
#24 0x7f8659b6eb31 base::internal::SchedulerWorker::Thread::ThreadMain()
#25 0x7f8659b902ea base::(anonymous namespace)::ThreadFunc()
#26 0x7f8659e3e184 start_thread
#27 0x7f8657db7bed clone

Aborted (core dumped)

This seems to be failing since gab@'s work on  bug 676387 .
 
Owner: charliea@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38a020a390d2e6a4e3ffe4cef863daf11b31440f

commit 38a020a390d2e6a4e3ffe4cef863daf11b31440f
Author: Charlie Andrews <charliea@chromium.org>
Date: Thu Jun 08 14:48:21 2017

Make SerialIoHandler RefCountedThreadSafe instead of just RefCounted

We pass this object around to different threads and sequences, so we
should be using atomic reference counting.

Bug:  730774 
Change-Id: If0a90dd1ac9016259a4d22533d3468dc7976469f
Reviewed-on: https://chromium-review.googlesource.com/527696
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477963}
[modify] https://crrev.com/38a020a390d2e6a4e3ffe4cef863daf11b31440f/device/serial/serial_io_handler.h

Status: Fixed (was: Assigned)

Sign in to add a comment