New issue
Advanced search Search tips

Issue 730771 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Hitting "submit" on software keyboard hides it instead of submitting the CVC dialog.

Project Member Reported by rouslan@chromium.org, Jun 7 2017

Issue description

Hitting "submit" on software keyboard hides it instead of submitting the CVC dialog.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/105ac643a506f1a5cf822d0ebca27e718c46a892

commit 105ac643a506f1a5cf822d0ebca27e718c46a892
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Jun 12 18:17:34 2017

CVC unmask dialog usability improvement.

Before this patch, hitting the software keyboard's "submit" button in
the CVC unmask dialog would hide the software keyboard and recenter the
dialog vertically. This would cause the user to hunt for the "Confirm"
button on the dialog at a new location. The user would be even more
frustrated if they instead accidentally tapped outside of the CVC
dialog, which cancels the CVC unmask.

This patch adds an editor action listener for the CVC number field in
the CVC unmask dialog. Whenever the user hits "submit" button on their
software keyboard in the CVC dialog, the listener checks if the dialog's
"confirm" button is enabled and, if so, clicks it. This patch also
changes the default software keyboard action on expiration date from
"submit" to "next field".

After this patch, hitting the software keyboard's "submit" button in the
CVC unmask dialog will perform the CVC unmask.

Bug:  730771 ,  687438 
Change-Id: Ie8d93e1df214c7fd5494dd0da64a3b94fb1861b9
Reviewed-on: https://chromium-review.googlesource.com/527500
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478685}
[modify] https://crrev.com/105ac643a506f1a5cf822d0ebca27e718c46a892/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml
[modify] https://crrev.com/105ac643a506f1a5cf822d0ebca27e718c46a892/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
[modify] https://crrev.com/105ac643a506f1a5cf822d0ebca27e718c46a892/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestExpiredLocalCardTest.java
[modify] https://crrev.com/105ac643a506f1a5cf822d0ebca27e718c46a892/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java
[modify] https://crrev.com/105ac643a506f1a5cf822d0ebca27e718c46a892/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment