Using back button to close a tab sees original content toggle size |
|||
Issue descriptionA recent CL allowed the back button to close a tab and return to the previous tab, if there is no history on the new tab. This works well. When returning to the previous tab, the content first shows correctly, but then quickly toggles to a zoomed version and back. mthiesse@ indicated that this is expected behavior, as the tab configures itself, and then VR reconfigures the tab (or some semblance of this). I reproduced this spawning a tab via badssl.com's "Safe browsing" test suite link, but it's likely reproducible anywhere.
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64d448d5f2a145aee27eb2648d8c7324add3a6a9 commit 64d448d5f2a145aee27eb2648d8c7324add3a6a9 Author: mthiesse <mthiesse@chromium.org> Date: Fri Jun 16 16:25:18 2017 Reparent all tabs when entering/exiting VR. This fixes the issue where tabs would resize incorrectly at first when opening or closing tabs, by reparenting all tabs when entering VR, making sure that tabs are created in the right window, and restoring the original window when done. BUG= 730758 Review-Url: https://codereview.chromium.org/2938253002 Cr-Commit-Position: refs/heads/master@{#480067} [modify] https://crrev.com/64d448d5f2a145aee27eb2648d8c7324add3a6a9/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java [modify] https://crrev.com/64d448d5f2a145aee27eb2648d8c7324add3a6a9/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Jun 16 2017
,
Jun 23 2017
Verified in Chrome Canary 61.0.3138.0
,
Jun 23 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vollick@chromium.org
, Jun 15 2017Status: Assigned (was: Untriaged)