New issue
Advanced search Search tips

Issue 730717 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
agrieve@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

diff tool didn't handle disappear or new sections in after.size file

Project Member Reported by bshe@chromium.org, Jun 7 2017 
When diff before.size and after.size. It is possible that:
1. section exists in before.size is removed in after.size
2. section exists in after.size didn't exist in before.size
This might results error like this one:
tools/binary_size/libsupersize/diff.py", line 186, in <dictcomp>
    for k, v in before.section_sizes.iteritems()}
KeyError: u'.data.rel.ro.local'
Or new section didn't included in the report.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7624780cbd20f45ccd6718905838ec67bf79e8b

commit a7624780cbd20f45ccd6718905838ec67bf79e8b
Author: bshe <bshe@chromium.org>
Date: Thu Jun 08 17:26:08 2017

Handling disappear or new sections in after.size file

BUG= 730717 

Review-Url: https://codereview.chromium.org/2928783002
Cr-Commit-Position: refs/heads/master@{#478011}

[modify] https://crrev.com/a7624780cbd20f45ccd6718905838ec67bf79e8b/tools/binary_size/libsupersize/diff.py
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by agrieve@chromium.org, Jun 11 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment