New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730712 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

[VrShell] Loading indicator colors are incorrect, background and foreground are swapped

Project Member Reported by amp@chromium.org, Jun 7 2017

Issue description

This was mixed up in the conversion from hard coded colors to a centralized color scheme.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9576b7bd92fc9c368cd0200a0105b8244396bd3f

commit 9576b7bd92fc9c368cd0200a0105b8244396bd3f
Author: Adam Parker <amp@google.com>
Date: Wed Jun 07 20:23:55 2017

[VrShell] Fix incorrect loading indicator colors.

This also reorganizes the names to always have foreground first.

Bug:  730712 
Change-Id: Iad914ead69489069f5f07d6d7cf6ef7adae17053
Reviewed-on: https://chromium-review.googlesource.com/527533
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477750}
[modify] https://crrev.com/9576b7bd92fc9c368cd0200a0105b8244396bd3f/chrome/browser/android/vr_shell/color_scheme.cc
[modify] https://crrev.com/9576b7bd92fc9c368cd0200a0105b8244396bd3f/chrome/browser/android/vr_shell/color_scheme.h

Comment 2 by amp@chromium.org, Jun 7 2017

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 7 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by amp@chromium.org, Jun 8 2017

This was merged with 3b7fa075a1b778e4763b6edc3085a14dc5ad5508, but the bot isn't working apparently.

Comment 5 by amp@chromium.org, Jun 8 2017

Labels: -Merge-Approved-60 merge-merged-3112
Status: Fixed (was: Started)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b7fa075a1b778e4763b6edc3085a14dc5ad5508

commit	3b7fa075a1b778e4763b6edc3085a14dc5ad5508
Author:	amp <amp@chromium.org>
Date: Thu Jun 08 01:31:37 2017
committer	Commit Bot <commit-bot@chromium.org>	Thu Jun 08 01:31:37 2017
tree	4dca1edb4af9eb35b3bb85d2bc3420376708785a
parent	d317f0434ffd4eacbe8f4f412da254a411cf34ea [diff]
[VrShell] Fix incorrect loading indicator colors.

This also reorganizes the names to always have foreground first.

Change-Id: Iad914ead69489069f5f07d6d7cf6ef7adae17053
Reviewed-on: https://chromium-review.googlesource.com/527533
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#477750}
Review-Url: https://codereview.chromium.org/2932573002
Cr-Commit-Position: refs/branch-heads/3112@{#245}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] chrome/browser/android/vr_shell/color_scheme.cc
[modify] chrome/browser/android/vr_shell/color_scheme.h

Sign in to add a comment