New issue
Advanced search Search tips

Issue 730696 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Buildbucket doesn't handle `buildbot reconfig` sighup

Project Member Reported by mbjorge@chromium.org, Jun 7 2017

Issue description

When I try to use buildbots 'reconfig' command to reload the master.cfg (to pick up new builders / new bots), buildbucket only seems to do a single poll cycle and then stops polling for new builds.

If I stop/restart he master, it works again as expected.

$ buildbot reconfig .
sending SIGHUP to process 1058
2017-06-07 17:37:20+0000 [-] beginning configuration update
2017-06-07 17:37:20+0000 [-] Loading configuration from 'master.cfg'
2017-06-07 17:37:21+0000 [-] removing scheduler 'force'
2017-06-07 17:37:21+0000 [-] adding scheduler 'force'
2017-06-07 17:37:21+0000 [-] [buildbucket] integrator stopped
2017-06-07 17:37:21+0000 [-] (TCP Port 8010 Closed)
2017-06-07 17:37:21+0000 [-] Stopping factory <buildbot.status.web.baseweb.RotateLogSite instance at 0x7f8de466f2d8>
2017-06-07 17:37:21+0000 [-] [buildbucket] integrator started
2017-06-07 17:37:21+0000 [-] [buildbucket] Requesting for all not yet completed build requests. This may take a long time...
2017-06-07 17:37:21+0000 [-] WebStatus using (public_html)
2017-06-07 17:37:21+0000 [-] RotateLogSite starting on 8010
2017-06-07 17:37:21+0000 [-] Starting factory <buildbot.status.web.baseweb.RotateLogSite instance at 0x7f8de447e050>
2017-06-07 17:37:21+0000 [-] Setting up http.log rotating 10 files of 10000000 bytes each
2017-06-07 17:37:21+0000 [-] configuration update complete

Reconfiguration appears to have completed successfully.


2017-06-07 17:37:23+0000 [-] [buildbucket] Received 1 build requests
2017-06-07 17:37:23+0000 [-] [buildbucket] Loaded current leases from the database: {u'8977427924365150992': {'build_request': BuildRequestGateway(brid=519), 'key': u'875095972'}}
2017-06-07 17:37:23+0000 [-] [buildbucket] Sending heartbeats for 1 leases
2017-06-07 17:37:23+0000 [-] [buildbucket] polling builds...
2017-06-07 17:37:23+0000 [-] [buildbucket] got 0 builds
<no more polling messages after this first one>
 

Comment 1 by no...@chromium.org, Jun 7 2017

Components: Infra>Platform>Buildbucket
Labels: -Infra-BuildBucket

Comment 2 by no...@chromium.org, Jun 7 2017

Cc: no...@chromium.org
Owner: ----
Status: Available (was: Untriaged)
reconfig does not work for chrome-infra, that's why this feature is not a priority for us. Contributions welcome
Makes sense. After looking around the docs some more, I think I'll be able to do `buildbot restart --clean` and get basically the same effect. 

And TBH, I think I trust a restart more than buildbot's reconfig, which seems to be pretty brittle anyways.
Status: WontFix (was: Available)

Sign in to add a comment