UserGestureIndicator cleanup: avoid allocation of no-op instances |
||||||
Issue descriptionThe constructor currently allows passing a null token parameter which is effectively a no-op. We have a bunch of callers that doesn't seem to know about the no-op usage, and unnecessarily creates an UGI instance. Here is one example: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp?rcl=f6750aae23ef4c4fd8e500f092bff269ca277abc&l=500
,
Jun 7 2017
,
Jun 8 2017
While trying (unsuccessfully) to wrap UGI/UGT inside LocalFrame methods (to move towards our new simple design behind a flag), I realized that we will have to preserve the stack-allocated UGIs we have today, in order to maintain current behavior. Result: I will have to /rely/ on those stack-allocated no-op UGIs instead of removing them!
,
Aug 15 2017
It seems that after we fix Issue 755160 , no-op UGIs would become unnecessary. In other works, we won't /have to/ rely on stack-allocation. So cleanup seems more logical again.
,
Nov 1 2017
,
May 8 2018
,
Sep 28
Let's avoid any UAv1 related cleanups. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mustaq@chromium.org
, Jun 7 2017