Clean up chromium's use of depot_tools |
|||||||||
Issue descriptionThere are many places in chromium that depend on having a copy of depot_tools present in order to function. Until recently (see bug 367876 and the change in crrev.com/477414), we just assumed we could find a copy somewhere on the system, and relied on the logic in //build/find_depot_tools.py to find it. However, nearly all of the time that copy was unpinned. This had some good aspects, and some bad aspects. depot_tools has two main purposes: 1) as a bootstrapping mechanism for checkouts (to ensure you have python, git, and fetch / gclient) 2) as a cross-project place to put generally useful development tools like git-cl, gsutil, or ninja) We need to figure out a better mechanism for handling the two different cases ASAP.
,
Jun 15 2017
,
Jun 23 2017
dropping to P2 since this doesn't seem to be causing real problems, mostly so I make sure I prioritize some other work ahead of this. But we still need to do this work ...
,
Jul 11 2017
,
Aug 18 2017
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd2839ebeaefbc8a0e66b98b4bea08bb72d95b94 commit dd2839ebeaefbc8a0e66b98b4bea08bb72d95b94 Author: Nodir Turakulov <nodir@google.com> Date: Fri Aug 18 22:47:06 2017 Fix depot_tools path resolution path_finder searches for depot_tools is present in the sys.path or env. This does not work on LUCI. depot_tools was depsed into src.git, so a better way to implement this (and that's what other "find depot tools" scripts do now) is to expect depot_tools to be in //src/third_party. R=dranke@chromium.org BUG= 756945 , 730686 Change-Id: Ie7b6480704fa07921e30efabdc11aef80a9a969e Reviewed-on: https://chromium-review.googlesource.com/621874 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#495721} [modify] https://crrev.com/dd2839ebeaefbc8a0e66b98b4bea08bb72d95b94/third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder.py [modify] https://crrev.com/dd2839ebeaefbc8a0e66b98b4bea08bb72d95b94/third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder_unittest.py
,
Sep 1 2017
Pawel, this is something you can be thinking about ...
,
Oct 10 2017
,
Dec 1 2017
Removing myself from bugs because of team transfer, back to re-triage. See https://goto.google.com/phajdan-goodbye-chrome (Google-internal) and issue 783662 . In case of any questions, feel free to ask - use phajdan@google.com for a faster response.
,
Jan 29 2018
,
Oct 19
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dpranke@chromium.org
, Jun 8 2017