New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730661 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-06-26
OS: Linux , Windows , Mac
Pri: 2
Type: Feature
Team-Accessibility



Sign in to add a comment

Should not apply `minimum font size` to <canvas>

Reported by zcyzcy88...@gmail.com, Jun 7 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

Example URL:

Steps to reproduce the problem:
1. turn on `minimum font size` in setting
2. visit <canvas> text (example: https://codepen.io/anon/pen/bRVdGV)

What is the expected behavior?

What went wrong?
<canvas> text applied `minimum font size`, so they inflated.

Although a11y is important, it is break the expect font size.
Imagine here is a <canvas> Photoshop, I try add text to picture, I can't make text small than `minimum font size`.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: all  Channel: n/a
OS Version: all
Flash Version: 

This also cause  Issue 720207 .
 
Components: -Blink Blink>Canvas
Components: Blink>Fonts
Labels: Needs-Milestone
Cc: kkaluri@chromium.org
Labels: -Needs-Milestone M-61 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.5 with chrome #59.0.3071.86 Canary #61.0.3123.0 and also in earlier version #30.0.1549.0, hence marking it as untriaged. 

Attaching a screen-cast for reference
730661.mp4
1.5 MB View Download
Cc: krajshree@chromium.org ajha@chromium.org
 Issue 720207  has been merged into this issue.
Components: -Blink>Fonts Blink>Accessibility
Labels: -Type-Bug Needs-Feedback Type-Feature
NextAction: 2017-06-26
This is technically a feature request, and the only way we would implement this, I think, is to somehow be able to disable the minimum font. There are use cases where the minimum font size should still kick in.

Accessibility, could you indicate whether you think the original request is an acceptable thing to do?

Marking Needs-Feedback until Accessibility weigh in.
Hmmm, this just seems like a bug to me. Canvas is a pixel API, I feel like it should be more deterministic and shouldn't be affected by system settings, especially a minimum like this that can't be overridden by the author.

I think that <canvas> is already outside the scope of what we can control accessibility for. Authors are certainly able to make a canvas-based UI accessible with some extra effort, but there's almost nothing we can do if the author doesn't want to do that.

Note that text drawn into a canvas by default won't be selectable, won't be accessible to screen readers, won't be speakable via select-to-speak features (macOS and Chrome OS both have this), and won't be affected by high contrast mode on browsers that respect system colors like Edge. I'm okay with that because it's a low-level API and authors shouldn't be using it for accessible text just like they shouldn't be using Flash or images for text.

Comment 8 by junov@chromium.org, Jun 13 2017

Owner: fs...@chromium.org

Comment 9 by junov@chromium.org, Jun 13 2017

Status: Assigned (was: Untriaged)
I agree with dmazzoni@. Besides the notion of enforcing a minimum font size is sort of futile in the first place because font style resolution (where the minimum is applied) happens upstream of the application of the 2D context's transform, so text can be scaled arbitrarily anyways.

Comment 10 by fs...@chromium.org, Jun 14 2017

Cc: e...@chromium.org junov@chromium.org dmazz...@chromium.org bunge...@chromium.org fs...@chromium.org brajkumar@chromium.org
 Issue 727428  has been merged into this issue.

Comment 11 by fs...@chromium.org, Jun 14 2017

Status: Started (was: Assigned)
Fixed it!

There's still the possibility of min font being applied in the case that the font size specified on Canvas is proportional to the parent element. In that case, the parent element will still be bounded by min font size, in which case we will inherit it.

That said, for most cases - where the size is directly specified - we will respect that and completely ignore min font size. :)

The CL is under review. Once it gets on, you can probably try it on canary.


Comment 12 by fs...@chromium.org, Jun 20 2017

Status: Fixed (was: Started)
Gerrit seems to be a bit shy on posting bug emails, but here it is:
https://chromium-review.googlesource.com/c/535275/

Feel free to check on canary in a couple days to make sure it's working. But it's working. :)

it's interesting that this bug has been around for so long but never reported. But here we are.

Donerino! Thanks for reporting.
The NextAction date has arrived: 2017-06-26

Sign in to add a comment