New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730658 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: ----



Sign in to add a comment

Add unittests to triage_suspected_cl.py

Project Member Reported by st...@chromium.org, Jun 7 2017

Issue description

There is some "# pragma: no cover" in that file, we should get rid of them and add unittest instead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d4effada1386b2c49b179f9df70f05454024c408

commit d4effada1386b2c49b179f9df70f05454024c408
Author: Chan <chanli@chromium.org>
Date: Wed Jun 07 22:48:48 2017

Add unittests for triage_suspected_cl.py

Bug:  730658 
Change-Id: I8ade331631f2cf885d787a0c4525d6ca71cf6eae
Reviewed-on: https://chromium-review.googlesource.com/527326
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/d4effada1386b2c49b179f9df70f05454024c408/appengine/findit/handlers/triage_suspected_cl.py
[modify] https://crrev.com/d4effada1386b2c49b179f9df70f05454024c408/appengine/findit/handlers/test/triage_suspected_cl_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d4effada1386b2c49b179f9df70f05454024c408

commit d4effada1386b2c49b179f9df70f05454024c408
Author: Chan <chanli@chromium.org>
Date: Wed Jun 07 22:48:48 2017

Add unittests for triage_suspected_cl.py

Bug:  730658 
Change-Id: I8ade331631f2cf885d787a0c4525d6ca71cf6eae
Reviewed-on: https://chromium-review.googlesource.com/527326
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/d4effada1386b2c49b179f9df70f05454024c408/appengine/findit/handlers/triage_suspected_cl.py
[modify] https://crrev.com/d4effada1386b2c49b179f9df70f05454024c408/appengine/findit/handlers/test/triage_suspected_cl_test.py

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/10f8637e68e7474ccdc41e3d117697b515a21b28

commit 10f8637e68e7474ccdc41e3d117697b515a21b28
Author: Katie Thomas <katthomas@google.com>
Date: Thu Jun 08 17:54:46 2017

Sign in to add a comment