New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730655 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Shift layer position for sticky element to avoid passing local offset to cc

Project Member Reported by yigu@chromium.org, Jun 7 2017

Issue description

We should be able to offset layer position by -main_thread_sticky_offset in CLM, as if the main thread never applied its sticky offset. That way we don't need to pass the local offset to cc.
 

Comment 1 by yigu@chromium.org, Jun 7 2017

Components: Internals>Compositing
Labels: Hotlist-ThreadedRendering
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23b68f6ceca08d1d213d4af869ba8336c9aa597a

commit 23b68f6ceca08d1d213d4af869ba8336c9aa597a
Author: yigu <yigu@chromium.org>
Date: Tue Jun 13 12:35:07 2017

Shifting layer position for sticky element to avoid passing unnecessary
variable to cc.

BUG= 730655 
TEST=CompositedLayerMappingTest.LayerPositionForStickyElement
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2929873002
Cr-Commit-Position: refs/heads/master@{#478983}

[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/cc/blink/web_layer_impl.h
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/cc/layers/layer.cc
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/cc/layers/layer.h
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/cc/trees/property_tree.cc
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/cc/trees/transform_node.h
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
[modify] https://crrev.com/23b68f6ceca08d1d213d4af869ba8336c9aa597a/third_party/WebKit/public/platform/WebLayer.h

Comment 3 by yigu@chromium.org, Jun 13 2017

Status: Fixed (was: Assigned)

Sign in to add a comment