New issue
Advanced search Search tips

Issue 730644 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Gerrit merged message does not tell the chromium sequence number nor link to anything

Project Member Reported by danakj@chromium.org, Jun 7 2017

Issue description

The message is "Change has been successfully rebased and submitted as f4730d5033656a932a06a3d6465fd3be9591b9c3 by Commit Bot"

Which requires me to git fetch/git f4730d503 to figure out what the CL commit sequence number is, which is what we use for various tools like perf bots.

Alternatively, rietveld doesn't either, but the message is a link to the CL which does contain the sequence number.
 
The process which posts the "rebased and submitted" message unfortunately *can't* include the sequence number -- the sequence number is added by a plugin, but that message is sent by gerrit core, and doesn't know the plugin exists. If you wanted to get a message including the commit position, we'd have to send two messages, and I bet that we'd have many more people mad about the spam.

So instead, the message already has a link to the review (all messages from gerrit do), and we're counting on that to provide the context.

Is the gmail/inbox smartlink to the review not sufficient?
I don't see any link here: https://chromium-review.googlesource.com/c/506430#message-dc0d69661c05f9189a5aa744de6b90f08622876e

I guess I'm not coming at this from the email, I could search my inbox instead of doing git show f4730d503, though that would be slower yet. I'm coming at this from the point of having a link to a review and trying to determine it's commit index from the web.
Scroll up. The commit message on that review page contains the Cr-Commit-Position footer.
Status: WontFix (was: Untriaged)
Ohh, that gets changed on commit, and its behind Show More. Ok that is sufficient, thanks! I wouldn't have found that on my own.

Sign in to add a comment