New issue
Advanced search Search tips

Issue 730631 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
aga...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Inconsistent keyboard shortcuts in poly gerrit

Project Member Reported by danakj@chromium.org, Jun 7 2017 
Shift-j/k moves to the next comment across files like rietveld did.
But j/k does not move to the next comment inside a file. Sadness.

Also doing reviews with rietveld used j and n which are beside each other. Now polygerrit is using mostly ] and n which are very far from each other requiring a bunch more hand strain and looking at keyboard.

Comment 1 by aga...@chromium.org, Jun 7 2017

Status: WontFix (was: Untriaged)
For the most part, we're not going to be changing PolyGerrit keyboard shortcuts to accommodate folks coming from Rietveld. There are too many other people already accustomed to Gerrit's shortcuts, and adding options is not something we want to do.

If you go into settings and choose "expand inline" by default, then you won't need to use ] to move between files; they'll all expand in the single page. (There are other problems with the keyboard shortcuts in this mode, but we're working on them.)

Having j/k move line-by-line instead of comment-by-comment is not going to change, I'm sorry.

Comment 2 by danakj@chromium.org, Jun 7 2017 

> If you go into settings and choose "expand inline" by default, then you won't need to use ] to move between files; they'll all expand in the single page

Yeh.. sorry this isn't feasible for larger patches. :( It takes a long time to load and then makes a huge page where it's very difficult to understand the context of any given diff chunk. Moving between files is really important to me for reviewing patches across 10+ files.
►

Sign in to add a comment