Exit to 2D when encountering URLs with strong RTL characters |
|||||||
Issue descriptionThis is not currently handled by the VR shell, so we should bail.
,
Jun 7 2017
,
Jun 7 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b2fdca8a155a7a575cb43e35c330593a54f6d2c commit 1b2fdca8a155a7a575cb43e35c330593a54f6d2c Author: Ian Vollick <vollick@chromium.org> Date: Wed Jun 07 20:46:40 2017 [vr] Exit to 2D when encountering URLs with strong RTL characters BUG= 730619 Review-Url: https://codereview.chromium.org/2925053004 Cr-Original-Commit-Position: refs/heads/master@{#477747} Review-Url: https://codereview.chromium.org/2930783002 . Cr-Commit-Position: refs/branch-heads/3112@{#232} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/1b2fdca8a155a7a575cb43e35c330593a54f6d2c/chrome/browser/android/vr_shell/textures/url_bar_texture.cc [modify] https://crrev.com/1b2fdca8a155a7a575cb43e35c330593a54f6d2c/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc [modify] https://crrev.com/1b2fdca8a155a7a575cb43e35c330593a54f6d2c/chrome/browser/android/vr_shell/ui_unsupported_mode.h [modify] https://crrev.com/1b2fdca8a155a7a575cb43e35c330593a54f6d2c/tools/metrics/histograms/enums.xml
,
Jun 7 2017
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b2fdca8a155a7a575cb43e35c330593a54f6d2c commit 1b2fdca8a155a7a575cb43e35c330593a54f6d2c Author: Ian Vollick <vollick@chromium.org> Date: Wed Jun 07 20:46:40 2017 [vr] Exit to 2D when encountering URLs with strong RTL characters BUG= 730619 Review-Url: https://codereview.chromium.org/2925053004 Cr-Original-Commit-Position: refs/heads/master@{#477747} Review-Url: https://codereview.chromium.org/2930783002 . Cr-Commit-Position: refs/branch-heads/3112@{#232} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/1b2fdca8a155a7a575cb43e35c330593a54f6d2c/chrome/browser/android/vr_shell/textures/url_bar_texture.cc [modify] https://crrev.com/1b2fdca8a155a7a575cb43e35c330593a54f6d2c/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc [modify] https://crrev.com/1b2fdca8a155a7a575cb43e35c330593a54f6d2c/chrome/browser/android/vr_shell/ui_unsupported_mode.h [modify] https://crrev.com/1b2fdca8a155a7a575cb43e35c330593a54f6d2c/tools/metrics/histograms/enums.xml
,
Jun 22 2017
Verified in Chrome Canary 61.0.3138.0
,
Jun 30 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 7 2017